* [PATCH net-next] hv_netvsc: Fix the list processing for network change event
@ 2016-04-21 23:13 Haiyang Zhang
2016-04-22 8:49 ` Vitaly Kuznetsov
2016-04-25 3:28 ` David Miller
0 siblings, 2 replies; 3+ messages in thread
From: Haiyang Zhang @ 2016-04-21 23:13 UTC (permalink / raw)
To: davem, netdev
Cc: haiyangz, kys, olaf, vkuznets, linux-kernel, driverdev-devel
RNDIS_STATUS_NETWORK_CHANGE event is handled as two "half events" --
media disconnect & connect. The second half should be added to the list
head, not to the tail. So all events are processed in normal order.
Signed-off-by: Haiyang Zhang <haiyangz@microsoft.com>
Reviewed-by: K. Y. Srinivasan <kys@microsoft.com>
---
drivers/net/hyperv/netvsc_drv.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/net/hyperv/netvsc_drv.c b/drivers/net/hyperv/netvsc_drv.c
index bfdb568a..ba3f3f3 100644
--- a/drivers/net/hyperv/netvsc_drv.c
+++ b/drivers/net/hyperv/netvsc_drv.c
@@ -1125,7 +1125,7 @@ static void netvsc_link_change(struct work_struct *w)
netif_tx_stop_all_queues(net);
event->event = RNDIS_STATUS_MEDIA_CONNECT;
spin_lock_irqsave(&ndev_ctx->lock, flags);
- list_add_tail(&event->list, &ndev_ctx->reconfig_events);
+ list_add(&event->list, &ndev_ctx->reconfig_events);
spin_unlock_irqrestore(&ndev_ctx->lock, flags);
reschedule = true;
}
--
1.7.4.1
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH net-next] hv_netvsc: Fix the list processing for network change event
2016-04-21 23:13 [PATCH net-next] hv_netvsc: Fix the list processing for network change event Haiyang Zhang
@ 2016-04-22 8:49 ` Vitaly Kuznetsov
2016-04-25 3:28 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: Vitaly Kuznetsov @ 2016-04-22 8:49 UTC (permalink / raw)
To: Haiyang Zhang; +Cc: davem, netdev, kys, olaf, linux-kernel, driverdev-devel
Haiyang Zhang <haiyangz@microsoft.com> writes:
> RNDIS_STATUS_NETWORK_CHANGE event is handled as two "half events" --
> media disconnect & connect. The second half should be added to the list
> head, not to the tail. So all events are processed in normal order.
>
Thanks,
this matters when we get some other events in between these two halves.
Reviewed-by: Vitaly Kuznetsov <vkuznets@redhat.com>
> Signed-off-by: Haiyang Zhang <haiyangz@microsoft.com>
> Reviewed-by: K. Y. Srinivasan <kys@microsoft.com>
> ---
> drivers/net/hyperv/netvsc_drv.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/net/hyperv/netvsc_drv.c b/drivers/net/hyperv/netvsc_drv.c
> index bfdb568a..ba3f3f3 100644
> --- a/drivers/net/hyperv/netvsc_drv.c
> +++ b/drivers/net/hyperv/netvsc_drv.c
> @@ -1125,7 +1125,7 @@ static void netvsc_link_change(struct work_struct *w)
> netif_tx_stop_all_queues(net);
> event->event = RNDIS_STATUS_MEDIA_CONNECT;
> spin_lock_irqsave(&ndev_ctx->lock, flags);
> - list_add_tail(&event->list, &ndev_ctx->reconfig_events);
> + list_add(&event->list, &ndev_ctx->reconfig_events);
> spin_unlock_irqrestore(&ndev_ctx->lock, flags);
> reschedule = true;
> }
--
Vitaly
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH net-next] hv_netvsc: Fix the list processing for network change event
2016-04-21 23:13 [PATCH net-next] hv_netvsc: Fix the list processing for network change event Haiyang Zhang
2016-04-22 8:49 ` Vitaly Kuznetsov
@ 2016-04-25 3:28 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: David Miller @ 2016-04-25 3:28 UTC (permalink / raw)
To: haiyangz; +Cc: netdev, kys, olaf, vkuznets, linux-kernel, driverdev-devel
From: Haiyang Zhang <haiyangz@microsoft.com>
Date: Thu, 21 Apr 2016 16:13:01 -0700
> RNDIS_STATUS_NETWORK_CHANGE event is handled as two "half events" --
> media disconnect & connect. The second half should be added to the list
> head, not to the tail. So all events are processed in normal order.
>
> Signed-off-by: Haiyang Zhang <haiyangz@microsoft.com>
> Reviewed-by: K. Y. Srinivasan <kys@microsoft.com>
Applied, thanks.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-04-25 3:28 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-04-21 23:13 [PATCH net-next] hv_netvsc: Fix the list processing for network change event Haiyang Zhang
2016-04-22 8:49 ` Vitaly Kuznetsov
2016-04-25 3:28 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome