* [PATCH] staging/serial2002: Fix filp_open usage
@ 2010-02-22 18:04 OGAWA Hirofumi
2010-02-24 1:56 ` Greg KH
0 siblings, 1 reply; 2+ messages in thread
From: OGAWA Hirofumi @ 2010-02-22 18:04 UTC (permalink / raw)
To: Greg Kroah-Hartman; +Cc: linux-kernel
Signed-off-by: OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>
---
drivers/staging/comedi/drivers/serial2002.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff -puN drivers/staging/comedi/drivers/serial2002.c~serial2002-filp_open-fix drivers/staging/comedi/drivers/serial2002.c
--- linux-2.6/drivers/staging/comedi/drivers/serial2002.c~serial2002-filp_open-fix 2010-02-22 23:22:27.000000000 +0900
+++ linux-2.6-hirofumi/drivers/staging/comedi/drivers/serial2002.c 2010-02-22 23:22:27.000000000 +0900
@@ -397,7 +397,7 @@ static void serial_2002_open(struct come
char port[20];
sprintf(port, "/dev/ttyS%d", devpriv->port);
- devpriv->tty = filp_open(port, 0, O_RDWR);
+ devpriv->tty = filp_open(port, O_RDWR, 0);
if (IS_ERR(devpriv->tty)) {
printk("serial_2002: file open error = %ld\n",
PTR_ERR(devpriv->tty));
_
--
OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [PATCH] staging/serial2002: Fix filp_open usage
2010-02-22 18:04 [PATCH] staging/serial2002: Fix filp_open usage OGAWA Hirofumi
@ 2010-02-24 1:56 ` Greg KH
0 siblings, 0 replies; 2+ messages in thread
From: Greg KH @ 2010-02-24 1:56 UTC (permalink / raw)
To: OGAWA Hirofumi; +Cc: linux-kernel
On Tue, Feb 23, 2010 at 03:04:42AM +0900, OGAWA Hirofumi wrote:
>
> Signed-off-by: OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>
> ---
>
> drivers/staging/comedi/drivers/serial2002.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff -puN drivers/staging/comedi/drivers/serial2002.c~serial2002-filp_open-fix drivers/staging/comedi/drivers/serial2002.c
> --- linux-2.6/drivers/staging/comedi/drivers/serial2002.c~serial2002-filp_open-fix 2010-02-22 23:22:27.000000000 +0900
> +++ linux-2.6-hirofumi/drivers/staging/comedi/drivers/serial2002.c 2010-02-22 23:22:27.000000000 +0900
> @@ -397,7 +397,7 @@ static void serial_2002_open(struct come
> char port[20];
>
> sprintf(port, "/dev/ttyS%d", devpriv->port);
> - devpriv->tty = filp_open(port, 0, O_RDWR);
> + devpriv->tty = filp_open(port, O_RDWR, 0);
Oh wow that code is scary :)
I'll queue this up and remember to nuke the whole thing soon...
thanks,
greg k-h
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2010-02-24 3:36 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2010-02-22 18:04 [PATCH] staging/serial2002: Fix filp_open usage OGAWA Hirofumi
2010-02-24 1:56 ` Greg KH
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®