Re: [2.6 patch] add include/asm-avr32/xor.h

["Mike Frysinger" <vapier.adi@gmail.com>]

On Mon, Apr 14, 2008 at 5:46 PM, Sebastian Siewior
<linux-crypto@ml.breakpoint.cc> wrote:
> * Adrian Bunk | 2008-04-14 21:15:36 [+0300]:
>  >> >601f75e99c076c16e2648f4860cac4fc6ce187ea diff --git a/include/asm-avr32/xor.h b/include/asm-avr32/xor.h
>  >> >new file mode 100644
>  >> >index 0000000..99c87aa
>  >> >--- /dev/null
>  >> >+++ b/include/asm-avr32/xor.h
>  >> >@@ -0,0 +1,6 @@
>  >> >+#ifndef _ASM_XOR_H
>  >> >+#define _ASM_XOR_H
>  >> >+
>  >> >+#include <asm-generic/xor.h>
>  >> >+
>  >> >+#endif
>  >>
>  >> What about providing <linux/xor.h> which includes the right file from
>  >> asm/ or asm-generic/ depending on HAVE_.* ?
>  >
>  >Where's the advantage?
>
>  This week you are going through avr32. The same fixup is required for
>  blackfin or cris if my ls isn't lying. So either you fix every arch
>  with this missing include or you provide a generic include and every
>  arch that provides a private xor.h includes it. From what I can see
>  almost every arch includes the generic except for x86 & sparc so most
>  xor.h files are identical copies and this is probably as bad as a
>  trailing white space :)

indeed.  the less work for arches the better :).
-mike