mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Mike Frysinger" <vapier.adi@gmail.com>
To: "Dan Williams" <dan.j.williams@intel.com>
Cc: "Adrian Bunk" <bunk@kernel.org>,
	"Sebastian Siewior" <linux-crypto@ml.breakpoint.cc>,
	hskinnemoen@atmel.com, herbert@gondor.apana.org.au,
	davem@davemloft.net, linux-crypto@vger.kernel.org,
	linux-kernel@vger.kernel.org, shannon.nelson@intel.com
Subject: Re: [2.6 patch] add include/asm-avr32/xor.h
Date: Mon, 14 Apr 2008 20:47:03 -0400	[thread overview]
Message-ID: <8bd0f97a0804141747q482c808aiac03713a6afa0adf@mail.gmail.com> (raw)
In-Reply-To: <e9c3a7c20804141645k6bdb075ax25e57f41e45e5105@mail.gmail.com>

On Mon, Apr 14, 2008 at 7:45 PM, Dan Williams <dan.j.williams@intel.com> wrote:
> On Mon, Apr 14, 2008 at 3:30 PM, Mike Frysinger <vapier.adi@gmail.com> wrote:
>  > On Mon, Apr 14, 2008 at 6:27 PM, Dan Williams <dan.j.williams@intel.com> wrote:
> >  >  "arches" did not have to go through and figure out the fun little stub
>  >  >  file for xor.h.  Adrian already made your "life easier".
>  >
>  >  actually he didnt.  he posted a fix for avr32.  i dont care about
>  >  avr32, i'm a blackfin guy.  he also wouldnt have had to do anything at
>  >  all if everything was handled with indirection in linux/xor.h.
>  >
>  >  your point also is irrelevant in the case of new architectures.  poor
>  >  microblaze for example.
>
>  Don't get me wrong I see the pain-reducing-value in codifying all the
>  features that have architecture specific aspects with HAVE_* config
>  variables.  But in this case I think a 6 line patch per new arch gets
>  the immediate job done.

sure ... i see the original patch as OK to get things working now
(especially as that is how the xor stuff is currently architected).
bigger picture is to go the common route proposed by Sebastian.  now
just need to sucker someone into doing the footwork :).
-mike

      reply	other threads:[~2008-04-15  0:47 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-04-14 14:16 Adrian Bunk
2008-04-14 18:11 ` Sebastian Siewior
2008-04-14 18:15   ` Adrian Bunk
2008-04-14 21:46     ` Sebastian Siewior
2008-04-14 21:50       ` Mike Frysinger
2008-04-14 22:01       ` Adrian Bunk
2008-04-14 22:11         ` Mike Frysinger
2008-04-14 22:27           ` Dan Williams
2008-04-14 22:30             ` Mike Frysinger
2008-04-14 23:45               ` Dan Williams
2008-04-15  0:47                 ` Mike Frysinger [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8bd0f97a0804141747q482c808aiac03713a6afa0adf@mail.gmail.com \
    --to=vapier.adi@gmail.com \
    --cc=bunk@kernel.org \
    --cc=dan.j.williams@intel.com \
    --cc=davem@davemloft.net \
    --cc=herbert@gondor.apana.org.au \
    --cc=hskinnemoen@atmel.com \
    --cc=linux-crypto@ml.breakpoint.cc \
    --cc=linux-crypto@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=shannon.nelson@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®