[RFC] Device addition to the tlv320adcx140 and tas2562

[RFC] Device addition to the tlv320adcx140 and tas2562

[Dan Murphy]

Hello

Looking for guidance on how to move forward with adding a device to 
existing drivers.

For the TLV320adcx140 driver I have another device which is register and 
bitmap compatible but it does not support Analog microphones or Line In 
like the x140.

Should I add a new driver specifically for this part or should I add the 
new audio maps, widgets and controls to the existing driver?  This would 
make this existing driver really big in terms of LoC and object size.

Similar question for the TAS2562.  I have a new device that is register 
and bitmap compatible but removes the I/V sense. Adding this new device 
to the existing driver wouldn't be as intrusive as the x140 as the audio 
map and controls are much simpler

Dan

Re: [RFC] Device addition to the tlv320adcx140 and tas2562

[Mark Brown]

[-- Attachment #1: Type: text/plain, Size: 906 bytes --]

On Wed, Sep 09, 2020 at 10:01:51AM -0500, Dan Murphy wrote:

> For the TLV320adcx140 driver I have another device which is register and
> bitmap compatible but it does not support Analog microphones or Line In like
> the x140.

> Should I add a new driver specifically for this part or should I add the new
> audio maps, widgets and controls to the existing driver?  This would make
> this existing driver really big in terms of LoC and object size.

Are they sharing anything (eg, the code is the same but the data tables
vary) or is it just two unrelated devices?

> Similar question for the TAS2562.  I have a new device that is register and
> bitmap compatible but removes the I/V sense. Adding this new device to the
> existing driver wouldn't be as intrusive as the x140 as the audio map and
> controls are much simpler

That definitely sounds like sharing the driver makes sense.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]