From: "Arnd Bergmann" <arnd@arndb.de>
To: "Yi-De Wu (吳一德)" <yi-de.wu@mediatek.com>,
"Yingshiuan Pan (潘穎軒)" <yingshiuan.pan@mediatek.com>,
"Ze-yu Wang (王澤宇)" <ze-yu.wang@mediatek.com>,
"Jonathan Corbet" <corbet@lwn.net>,
"Catalin Marinas" <catalin.marinas@arm.com>,
"Will Deacon" <will@kernel.org>,
"Matthias Brugger" <matthias.bgg@gmail.com>,
"AngeloGioacchino Del Regno"
<angelogioacchino.delregno@collabora.com>
Cc: linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
Linux-Arch <linux-arch@vger.kernel.org>,
linux-mediatek@lists.infradead.org,
"Krzysztof Kozlowski" <krzysztof.kozlowski+dt@linaro.org>,
"Rob Herring" <robh+dt@kernel.org>,
"Conor.Dooley" <conor.dooley@microchip.com>,
"Conor Dooley" <conor+dt@kernel.org>,
"Trilok Soni" <quic_tsoni@quicinc.com>,
"dbrazdil@google.com" <dbrazdil@google.com>,
"Jades Shih (施向玨)" <jades.shih@mediatek.com>,
"Miles Chen" <miles.chen@mediatek.com>,
"Ivan Tseng (曾志軒)" <ivan.tseng@mediatek.com>,
"MY Chuang (莊明躍)" <my.chuang@mediatek.com>,
"Shawn Hsiao (蕭志祥)" <shawn.hsiao@mediatek.com>,
"PeiLun Suei (隋培倫)" <peilun.suei@mediatek.com>,
"Liju-clr Chen (陳麗如)" <liju-clr.chen@mediatek.com>,
"Chi-shen Yeh (葉奇軒)" <chi-shen.yeh@mediatek.com>
Subject: Re: [PATCH v4 5/9] virt: geniezone: Add irqfd support
Date: Tue, 27 Jun 2023 11:29:52 +0200 [thread overview]
Message-ID: <8c50cf74-fd21-4b86-8ac8-1445ff242d48@app.fastmail.com> (raw)
In-Reply-To: <20230609085214.31071-6-yi-de.wu@mediatek.com>
On Fri, Jun 9, 2023, at 10:52, Yi-De Wu wrote:
>
> /**
> * gzvm_hypercall_wrapper()
> @@ -72,6 +73,11 @@ static inline gzvm_vcpu_id_t
> get_vcpuid_from_tuple(unsigned int tuple)
> return (gzvm_vcpu_id_t)(tuple & 0xffff);
> }
>
> +struct gzvm_vcpu_hwstate {
> + __u32 nr_lrs;
> + __u64 lr[GIC_V3_NR_LRS];
> +};
This is not a good definition for a hardware data structure, as there
is architecture specific implicit padding between the two members.
Better add an explicit '__u32 __pad;' in the middle to make it clear
what the actual layout is and make it portable.
If this is an interface to the hypervisor, it should probably also
use explicit endianess, using __le32 and __le64 instead of __u32
and __u64, along with the corresponding accessors.
Arnd
next prev parent reply other threads:[~2023-06-27 9:30 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-09 8:52 [PATCH v4 0/9] GenieZone hypervisor drivers Yi-De Wu
2023-06-09 8:52 ` [PATCH v4 1/9] docs: geniezone: Introduce GenieZone hypervisor Yi-De Wu
2023-06-15 11:47 ` kernel test robot
2023-06-09 8:52 ` [PATCH v4 2/9] virt: geniezone: Add GenieZone hypervisor support Yi-De Wu
2023-06-09 15:22 ` Krzysztof Kozlowski
2023-07-21 8:46 ` Yi-De Wu (吳一德)
2023-07-22 1:29 ` Trilok Soni
2023-06-09 8:52 ` [PATCH v4 3/9] virt: geniezone: Add vcpu support Yi-De Wu
2023-06-09 8:52 ` [PATCH v4 4/9] virt: geniezone: Add irqchip support for virtual interrupt injection Yi-De Wu
2023-06-12 7:49 ` AngeloGioacchino Del Regno
2023-06-09 8:52 ` [PATCH v4 5/9] virt: geniezone: Add irqfd support Yi-De Wu
2023-06-12 7:57 ` AngeloGioacchino Del Regno
[not found] ` <6120750daede4eb40fb4d44ed68ba58e5716e038.camel@mediatek.com>
2023-06-27 9:27 ` Arnd Bergmann
2023-06-27 9:29 ` Arnd Bergmann [this message]
2023-06-09 8:52 ` [PATCH v4 6/9] virt: geniezone: Add ioeventfd support Yi-De Wu
2023-06-09 8:52 ` [PATCH v4 7/9] virt: geniezone: Add memory region support Yi-De Wu
2023-06-12 8:01 ` AngeloGioacchino Del Regno
2023-06-09 8:52 ` [PATCH v4 8/9] virt: geniezone: Add dtb config support Yi-De Wu
2023-06-12 8:02 ` AngeloGioacchino Del Regno
2023-06-09 8:52 ` [PATCH v4 9/9] virt: geniezone: Add virtual timer support Yi-De Wu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8c50cf74-fd21-4b86-8ac8-1445ff242d48@app.fastmail.com \
--to=arnd@arndb.de \
--cc=angelogioacchino.delregno@collabora.com \
--cc=catalin.marinas@arm.com \
--cc=chi-shen.yeh@mediatek.com \
--cc=conor+dt@kernel.org \
--cc=conor.dooley@microchip.com \
--cc=corbet@lwn.net \
--cc=dbrazdil@google.com \
--cc=ivan.tseng@mediatek.com \
--cc=jades.shih@mediatek.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=liju-clr.chen@mediatek.com \
--cc=linux-arch@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=miles.chen@mediatek.com \
--cc=my.chuang@mediatek.com \
--cc=peilun.suei@mediatek.com \
--cc=quic_tsoni@quicinc.com \
--cc=robh+dt@kernel.org \
--cc=shawn.hsiao@mediatek.com \
--cc=will@kernel.org \
--cc=yi-de.wu@mediatek.com \
--cc=yingshiuan.pan@mediatek.com \
--cc=ze-yu.wang@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®