Re: [PATCH v4 2/9] virt: geniezone: Add GenieZone hypervisor support

[Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>]

On 09/06/2023 10:52, Yi-De Wu wrote:
> From: "Yingshiuan Pan" <yingshiuan.pan@mediatek.com>
> 
> GenieZone is MediaTek hypervisor solution, and it is running in EL2
> stand alone as a type-I hypervisor. This patch exports a set of ioctl
> interfaces for userspace VMM (e.g., crosvm) to operate guest VMs
> lifecycle (creation and destroy) on GenieZone.

...

> +static int gzvm_drv_probe(void)
> +{
> +	int ret;
> +
> +	if (gzvm_arch_probe() != 0) {
> +		pr_err("Not found available conduit\n");
> +		return -ENODEV;
> +	}
> +
> +	ret = misc_register(&gzvm_dev);
> +	if (ret)
> +		return ret;
> +	gzvm_debug_dev = &gzvm_dev;
> +
> +	return 0;
> +}
> +
> +static int gzvm_drv_remove(void)
> +{
> +	destroy_all_vm();
> +	misc_deregister(&gzvm_dev);
> +	return 0;
> +}
> +
> +static int gzvm_dev_init(void)
> +{
> +	return gzvm_drv_probe();

So for every system and architecture you want to: probe, run some SMC
and then print error that it is not othe system you wanted.

I don't think this is what we want. You basically pollute all of other
users just to have your hypervisor guest additions...


Best regards,
Krzysztof