mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Arnd Bergmann" <arnd@arndb.de>
To: "Yi-De Wu (吳一德)" <Yi-De.Wu@mediatek.com>,
	"AngeloGioacchino Del Regno"
	<angelogioacchino.delregno@collabora.com>,
	"Jonathan Corbet" <corbet@lwn.net>,
	"Catalin Marinas" <catalin.marinas@arm.com>,
	"Yingshiuan Pan (潘穎軒)" <Yingshiuan.Pan@mediatek.com>,
	"Matthias Brugger" <matthias.bgg@gmail.com>,
	"Ze-yu Wang (王澤宇)" <Ze-yu.Wang@mediatek.com>,
	"Will Deacon" <will@kernel.org>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"linux-mediatek@lists.infradead.org"
	<linux-mediatek@lists.infradead.org>,
	"Rob Herring" <robh+dt@kernel.org>,
	"MY Chuang (莊明躍)" <MY.Chuang@mediatek.com>,
	"Trilok Soni" <quic_tsoni@quicinc.com>,
	"Conor.Dooley" <conor.dooley@microchip.com>,
	"PeiLun Suei (隋培倫)" <PeiLun.Suei@mediatek.com>,
	"Liju-clr Chen (陳麗如)" <Liju-clr.Chen@mediatek.com>,
	"Jades Shih (施向玨)" <jades.shih@mediatek.com>,
	"Conor Dooley" <conor+dt@kernel.org>,
	"dbrazdil@google.com" <dbrazdil@google.com>,
	"linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>,
	"krzysztof.kozlowski+dt@linaro.org"
	<krzysztof.kozlowski+dt@linaro.org>,
	"Shawn Hsiao (蕭志祥)" <shawn.hsiao@mediatek.com>,
	Linux-Arch <linux-arch@vger.kernel.org>,
	"linux-doc@vger.kernel.org" <linux-doc@vger.kernel.org>,
	"Ivan Tseng (曾志軒)" <ivan.tseng@mediatek.com>,
	"Chi-shen Yeh (葉奇軒)" <Chi-shen.Yeh@mediatek.com>
Subject: Re: [PATCH v4 5/9] virt: geniezone: Add irqfd support
Date: Tue, 27 Jun 2023 11:27:34 +0200	[thread overview]
Message-ID: <d0bca239-2711-4268-a36c-7c3434982ab1@app.fastmail.com> (raw)
In-Reply-To: <6120750daede4eb40fb4d44ed68ba58e5716e038.camel@mediatek.com>

On Tue, Jun 27, 2023, at 09:54, Yi-De Wu (吳一德) wrote:

>> ..snip.. 
>> > diff --git a/drivers/virt/geniezone/gzvm_main.c b/drivers/virt/geniezone/gzvm_main.c > index 230970cb0953..e62c046d76b3 100644 > --- a/drivers/virt/geniezone/gzvm_main.c > +++ b/drivers/virt/geniezone/gzvm_main.c > @@ -113,11 +113,12 @@ static int gzvm_drv_probe(void) >   return ret; >   gzvm_debug_dev = &gzvm_dev; >   > -return 0; > +return gzvm_drv_irqfd_init(); 
>> ret = gzvm_drv_irqfd_init(); if (ret) return ret; 

Something went wrong with the quoting up here, please make sure to
use plaintext email instead of html.

>> return 0; 
>
> We're wondering the pros and cons for this coding style.
> Could you kindly give us some hint for possibly we could miss it somewhere.
>
> Some other suggestion had been made by AOSP reviewer on the very line 
> mentioned. As a consequence, we'd like to dig in the rationale behind 
> such debate.
> https://android-review.googlesource.com/c/kernel/common/+/2574178/comment/f23bbd52_e3b14396/

I think most developers prefer the shorter form here, and I've
seen cleanup patches actually changing the longer version to that.

     Arnd

  parent reply	other threads:[~2023-06-27  9:28 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-06-09  8:52 [PATCH v4 0/9] GenieZone hypervisor drivers Yi-De Wu
2023-06-09  8:52 ` [PATCH v4 1/9] docs: geniezone: Introduce GenieZone hypervisor Yi-De Wu
2023-06-15 11:47   ` kernel test robot
2023-06-09  8:52 ` [PATCH v4 2/9] virt: geniezone: Add GenieZone hypervisor support Yi-De Wu
2023-06-09 15:22   ` Krzysztof Kozlowski
2023-07-21  8:46     ` Yi-De Wu (吳一德)
2023-07-22  1:29       ` Trilok Soni
2023-06-09  8:52 ` [PATCH v4 3/9] virt: geniezone: Add vcpu support Yi-De Wu
2023-06-09  8:52 ` [PATCH v4 4/9] virt: geniezone: Add irqchip support for virtual interrupt injection Yi-De Wu
2023-06-12  7:49   ` AngeloGioacchino Del Regno
2023-06-09  8:52 ` [PATCH v4 5/9] virt: geniezone: Add irqfd support Yi-De Wu
2023-06-12  7:57   ` AngeloGioacchino Del Regno
     [not found]     ` <6120750daede4eb40fb4d44ed68ba58e5716e038.camel@mediatek.com>
2023-06-27  9:27       ` Arnd Bergmann [this message]
2023-06-27  9:29   ` Arnd Bergmann
2023-06-09  8:52 ` [PATCH v4 6/9] virt: geniezone: Add ioeventfd support Yi-De Wu
2023-06-09  8:52 ` [PATCH v4 7/9] virt: geniezone: Add memory region support Yi-De Wu
2023-06-12  8:01   ` AngeloGioacchino Del Regno
2023-06-09  8:52 ` [PATCH v4 8/9] virt: geniezone: Add dtb config support Yi-De Wu
2023-06-12  8:02   ` AngeloGioacchino Del Regno
2023-06-09  8:52 ` [PATCH v4 9/9] virt: geniezone: Add virtual timer support Yi-De Wu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d0bca239-2711-4268-a36c-7c3434982ab1@app.fastmail.com \
    --to=arnd@arndb.de \
    --cc=Chi-shen.Yeh@mediatek.com \
    --cc=Liju-clr.Chen@mediatek.com \
    --cc=MY.Chuang@mediatek.com \
    --cc=PeiLun.Suei@mediatek.com \
    --cc=Yi-De.Wu@mediatek.com \
    --cc=Yingshiuan.Pan@mediatek.com \
    --cc=Ze-yu.Wang@mediatek.com \
    --cc=angelogioacchino.delregno@collabora.com \
    --cc=catalin.marinas@arm.com \
    --cc=conor+dt@kernel.org \
    --cc=conor.dooley@microchip.com \
    --cc=corbet@lwn.net \
    --cc=dbrazdil@google.com \
    --cc=ivan.tseng@mediatek.com \
    --cc=jades.shih@mediatek.com \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=linux-arch@vger.kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mediatek@lists.infradead.org \
    --cc=matthias.bgg@gmail.com \
    --cc=quic_tsoni@quicinc.com \
    --cc=robh+dt@kernel.org \
    --cc=shawn.hsiao@mediatek.com \
    --cc=will@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®