* [PATCH] soc: mediatek: SVS: Fix MT8192 GPU node name
@ 2023-05-31 6:35 Chen-Yu Tsai
2023-05-31 8:12 ` AngeloGioacchino Del Regno
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Chen-Yu Tsai @ 2023-05-31 6:35 UTC (permalink / raw)
To: Matthias Brugger, AngeloGioacchino Del Regno
Cc: Chen-Yu Tsai, Nícolas F . R . A . Prado, linux-mediatek,
linux-arm-kernel, linux-kernel
Device tree node names should be generic. The planned device node name
for the GPU, according to the bindings and posted DT changes, is "gpu",
not "mali".
Fix the GPU node name in the SVS driver to follow.
Fixes: 0bbb09b2af9d ("soc: mediatek: SVS: add mt8192 SVS GPU driver")
Signed-off-by: Chen-Yu Tsai <wenst@chromium.org>
---
drivers/soc/mediatek/mtk-svs.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/soc/mediatek/mtk-svs.c b/drivers/soc/mediatek/mtk-svs.c
index 81585733c8a9..3a2f97cd5272 100644
--- a/drivers/soc/mediatek/mtk-svs.c
+++ b/drivers/soc/mediatek/mtk-svs.c
@@ -2061,9 +2061,9 @@ static int svs_mt8192_platform_probe(struct svs_platform *svsp)
svsb = &svsp->banks[idx];
if (svsb->type == SVSB_HIGH)
- svsb->opp_dev = svs_add_device_link(svsp, "mali");
+ svsb->opp_dev = svs_add_device_link(svsp, "gpu");
else if (svsb->type == SVSB_LOW)
- svsb->opp_dev = svs_get_subsys_device(svsp, "mali");
+ svsb->opp_dev = svs_get_subsys_device(svsp, "gpu");
if (IS_ERR(svsb->opp_dev))
return dev_err_probe(svsp->dev, PTR_ERR(svsb->opp_dev),
--
2.41.0.rc0.172.g3f132b7071-goog
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] soc: mediatek: SVS: Fix MT8192 GPU node name
2023-05-31 6:35 [PATCH] soc: mediatek: SVS: Fix MT8192 GPU node name Chen-Yu Tsai
@ 2023-05-31 8:12 ` AngeloGioacchino Del Regno
2023-05-31 9:18 ` Alexandre Mergnat
2023-06-09 14:35 ` Matthias Brugger
2 siblings, 0 replies; 4+ messages in thread
From: AngeloGioacchino Del Regno @ 2023-05-31 8:12 UTC (permalink / raw)
To: Chen-Yu Tsai, Matthias Brugger
Cc: Nícolas F . R . A . Prado, linux-mediatek, linux-arm-kernel,
linux-kernel
Il 31/05/23 08:35, Chen-Yu Tsai ha scritto:
> Device tree node names should be generic. The planned device node name
> for the GPU, according to the bindings and posted DT changes, is "gpu",
> not "mali".
>
> Fix the GPU node name in the SVS driver to follow.
>
> Fixes: 0bbb09b2af9d ("soc: mediatek: SVS: add mt8192 SVS GPU driver")
> Signed-off-by: Chen-Yu Tsai <wenst@chromium.org>
Hahaha, I was about to send the same patch! :D
Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
> ---
> drivers/soc/mediatek/mtk-svs.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/soc/mediatek/mtk-svs.c b/drivers/soc/mediatek/mtk-svs.c
> index 81585733c8a9..3a2f97cd5272 100644
> --- a/drivers/soc/mediatek/mtk-svs.c
> +++ b/drivers/soc/mediatek/mtk-svs.c
> @@ -2061,9 +2061,9 @@ static int svs_mt8192_platform_probe(struct svs_platform *svsp)
> svsb = &svsp->banks[idx];
>
> if (svsb->type == SVSB_HIGH)
> - svsb->opp_dev = svs_add_device_link(svsp, "mali");
> + svsb->opp_dev = svs_add_device_link(svsp, "gpu");
> else if (svsb->type == SVSB_LOW)
> - svsb->opp_dev = svs_get_subsys_device(svsp, "mali");
> + svsb->opp_dev = svs_get_subsys_device(svsp, "gpu");
>
> if (IS_ERR(svsb->opp_dev))
> return dev_err_probe(svsp->dev, PTR_ERR(svsb->opp_dev),
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] soc: mediatek: SVS: Fix MT8192 GPU node name
2023-05-31 6:35 [PATCH] soc: mediatek: SVS: Fix MT8192 GPU node name Chen-Yu Tsai
2023-05-31 8:12 ` AngeloGioacchino Del Regno
@ 2023-05-31 9:18 ` Alexandre Mergnat
2023-06-09 14:35 ` Matthias Brugger
2 siblings, 0 replies; 4+ messages in thread
From: Alexandre Mergnat @ 2023-05-31 9:18 UTC (permalink / raw)
To: Chen-Yu Tsai, Matthias Brugger, AngeloGioacchino Del Regno
Cc: Nícolas F . R . A . Prado, linux-mediatek, linux-arm-kernel,
linux-kernel
On 31/05/2023 08:35, Chen-Yu Tsai wrote:
> Device tree node names should be generic. The planned device node name
> for the GPU, according to the bindings and posted DT changes, is "gpu",
> not "mali".
>
> Fix the GPU node name in the SVS driver to follow.
Reviewed-by: Alexandre Mergnat <amergnat@baylibre.com>
--
Regards,
Alexandre
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] soc: mediatek: SVS: Fix MT8192 GPU node name
2023-05-31 6:35 [PATCH] soc: mediatek: SVS: Fix MT8192 GPU node name Chen-Yu Tsai
2023-05-31 8:12 ` AngeloGioacchino Del Regno
2023-05-31 9:18 ` Alexandre Mergnat
@ 2023-06-09 14:35 ` Matthias Brugger
2 siblings, 0 replies; 4+ messages in thread
From: Matthias Brugger @ 2023-06-09 14:35 UTC (permalink / raw)
To: Chen-Yu Tsai, AngeloGioacchino Del Regno
Cc: Nícolas F . R . A . Prado, linux-mediatek, linux-arm-kernel,
linux-kernel
On 31/05/2023 08:35, Chen-Yu Tsai wrote:
> Device tree node names should be generic. The planned device node name
> for the GPU, according to the bindings and posted DT changes, is "gpu",
> not "mali".
>
> Fix the GPU node name in the SVS driver to follow.
>
> Fixes: 0bbb09b2af9d ("soc: mediatek: SVS: add mt8192 SVS GPU driver")
> Signed-off-by: Chen-Yu Tsai <wenst@chromium.org>
Applied, thanks
> ---
> drivers/soc/mediatek/mtk-svs.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/soc/mediatek/mtk-svs.c b/drivers/soc/mediatek/mtk-svs.c
> index 81585733c8a9..3a2f97cd5272 100644
> --- a/drivers/soc/mediatek/mtk-svs.c
> +++ b/drivers/soc/mediatek/mtk-svs.c
> @@ -2061,9 +2061,9 @@ static int svs_mt8192_platform_probe(struct svs_platform *svsp)
> svsb = &svsp->banks[idx];
>
> if (svsb->type == SVSB_HIGH)
> - svsb->opp_dev = svs_add_device_link(svsp, "mali");
> + svsb->opp_dev = svs_add_device_link(svsp, "gpu");
> else if (svsb->type == SVSB_LOW)
> - svsb->opp_dev = svs_get_subsys_device(svsp, "mali");
> + svsb->opp_dev = svs_get_subsys_device(svsp, "gpu");
>
> if (IS_ERR(svsb->opp_dev))
> return dev_err_probe(svsp->dev, PTR_ERR(svsb->opp_dev),
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2023-06-09 14:35 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-05-31 6:35 [PATCH] soc: mediatek: SVS: Fix MT8192 GPU node name Chen-Yu Tsai
2023-05-31 8:12 ` AngeloGioacchino Del Regno
2023-05-31 9:18 ` Alexandre Mergnat
2023-06-09 14:35 ` Matthias Brugger
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®