Re: [PATCH v4 18/19] drm/mediatek: Add support for multiple mmsys in the one mediatek-drm driver

["Paul-pl Chen (陳柏霖)" <Paul-pl.Chen@mediatek.com>]

On Wed, 2025-09-10 at 14:24 +0200, AngeloGioacchino Del Regno wrote:
> 
> External email : Please do not click links or open attachments until
> you have verified the sender or the content.
> 
> 
> Il 28/08/25 10:07, Paul Chen ha scritto:
> > From: Nancy Lin <nancy.lin@mediatek.com>
> > 
> > To support multiple mmsys instances in the one mediatek-drm
> > instance,
> > providing improved flexibility and scalability by the following
> > changes:
> > 
> > 1. Add DDP_COMPONENT_DRM_OVLSYS_ADAPTOR* to probe the
> >    ovlsys_adaptor drivers and support different mmsys composition.
> > 2. Added new component types MTK_DISP_VIRTUAL to support the
> >    routing to virtual display components.
> > 3. Added and adjusted the existed structure or interface to extend
> >    the support of multiple mmsys instances.
> > 4. Modified the component matching and binding logic to support
> >    multiple mmsys instances.
> 
> This commit is huge and a bit difficult to read, but also you have
> split the
> changes description in four points.
> 
> Please, split this in four commits, for each of the changes that
> you're actually
> describing in the description of this single one: this not only makes
> reviewing a
> bit easier, but will help understanding what's being done in case any
> uncaught
> regression shows up "after the fact".
> 
> Thanks,
> Angelo
> 

Hi Angelo, 

Sure, I will split this commit to four commits to make sure every
commit have only one changes. 

Best, Paul
> 
> > 
> > Signed-off-by: Nancy Lin <nancy.lin@mediatek.com>
> > Signed-off-by: Paul-pl Chen <paul-pl.chen@mediatek.com>
> > ---
> >   drivers/gpu/drm/mediatek/mtk_crtc.c     | 342
> > +++++++++++++++++++-----
> >   drivers/gpu/drm/mediatek/mtk_crtc.h     |   6 +-
> >   drivers/gpu/drm/mediatek/mtk_ddp_comp.c | 105 +++++---
> >   drivers/gpu/drm/mediatek/mtk_ddp_comp.h |   2 +
> >   drivers/gpu/drm/mediatek/mtk_drm_drv.c  |  85 +++---
> >   drivers/gpu/drm/mediatek/mtk_drm_drv.h  |  13 +
> >   6 files changed, 421 insertions(+), 132 deletions(-)
> >