mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: John Garry <john.garry@huawei.com>
To: <jejb@linux.vnet.ibm.com>, <martin.petersen@oracle.com>
Cc: <linuxarm@huawei.com>, <linux-scsi@vger.kernel.org>,
	<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 0/7] hisi_sas: Misc bugfixes and an optimisation patch
Date: Thu, 4 Oct 2018 16:30:44 +0100	[thread overview]
Message-ID: <8e8d0006-a887-ddf3-0179-49d2370abc68@huawei.com> (raw)
In-Reply-To: <1537801594-207139-1-git-send-email-john.garry@huawei.com>

On 24/09/2018 16:06, John Garry wrote:
> This patchset introduces mostly more minor/obscure bugfixes for the
> driver.

Hi Martin,

Can you please consider merging this patchset?

Thanks,
John

>
> Also included is an optimisation to use the block layer tag for the IPTT
> indexing. This quite a nice optimisation as it means we don't have to
> evaluate this in the driver - it was a bit of a bottle-neck.
>
> However it does block us in future from enabling SCSI MQ in the driver.
> This is because the IPTT index must be a unique value per HBA. However,
> if we switched to SCSI MQ, the block layer tag becomes unique per queue,
> and not per HBA.
>
> Having said this, testing has shown that performance is better by using
> this block layer tag instead of enabling SCSI MQ in the driver.
>
> Luo Jiaxing (2):
>   scsi: hisi_sas: Feed back linkrate(max/min) when re-attached
>   scsi: hisi_sas: Move evaluation of hisi_hba in hisi_sas_task_prep()
>
> Xiang Chen (5):
>   scsi: hisi_sas: Fix the race between IO completion and timeout for
>     SMP/internal IO
>   scsi: hisi_sas: Free slot later in slot_complete_vx_hw()
>   scsi: hisi_sas: unmask interrupts ent72 and ent74
>   scsi: hisi_sas: Use block layer tag instead for IPTT
>   scsi: hisi_sas: Update v3 hw AIP_LIMIT and CFG_AGING_TIME register
>     values
>
>  drivers/scsi/hisi_sas/hisi_sas.h       |   3 +-
>  drivers/scsi/hisi_sas/hisi_sas_main.c  | 154 ++++++++++++++++++++++++---------
>  drivers/scsi/hisi_sas/hisi_sas_v1_hw.c |   1 -
>  drivers/scsi/hisi_sas/hisi_sas_v2_hw.c |  11 +--
>  drivers/scsi/hisi_sas/hisi_sas_v3_hw.c |  15 ++--
>  5 files changed, 130 insertions(+), 54 deletions(-)
>



  parent reply	other threads:[~2018-10-04 15:31 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-09-24 15:06 John Garry
2018-09-24 15:06 ` [PATCH 1/7] scsi: hisi_sas: Feed back linkrate(max/min) when re-attached John Garry
2018-09-24 15:06 ` [PATCH 2/7] scsi: hisi_sas: Move evaluation of hisi_hba in hisi_sas_task_prep() John Garry
2018-09-24 15:06 ` [PATCH 3/7] scsi: hisi_sas: Fix the race between IO completion and timeout for SMP/internal IO John Garry
2018-09-24 15:06 ` [PATCH 4/7] scsi: hisi_sas: Free slot later in slot_complete_vx_hw() John Garry
2018-09-24 15:06 ` [PATCH 5/7] scsi: hisi_sas: unmask interrupts ent72 and ent74 John Garry
2018-09-24 15:06 ` [PATCH 6/7] scsi: hisi_sas: Use block layer tag instead for IPTT John Garry
2018-09-24 15:06 ` [PATCH 7/7] scsi: hisi_sas: Update v3 hw AIP_LIMIT and CFG_AGING_TIME register values John Garry
2018-10-04 15:30 ` John Garry [this message]
2018-10-11  1:58 ` [PATCH 0/7] hisi_sas: Misc bugfixes and an optimisation patch Martin K. Petersen
2018-10-11  6:36   ` Christoph Hellwig
2018-10-11  9:59     ` John Garry
2018-10-11 10:15       ` Christoph Hellwig
2018-10-11 13:12         ` John Garry
2018-10-11 13:32           ` Ming Lei
2018-10-11 14:07             ` John Garry
2018-10-11 23:36               ` Ming Lei
2018-10-12  9:02                 ` John Garry
2018-10-12 13:30                   ` Ming Lei
2018-10-12 10:47   ` John Garry
2018-10-16  4:28     ` Martin K. Petersen
2018-10-16  8:28       ` John Garry

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8e8d0006-a887-ddf3-0179-49d2370abc68@huawei.com \
    --to=john.garry@huawei.com \
    --cc=jejb@linux.vnet.ibm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=linuxarm@huawei.com \
    --cc=martin.petersen@oracle.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®