mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Neil Armstrong <neil.armstrong@linaro.org>
To: Matt Smith <matthew.j.smith2@outlook.com>
Cc: Jessica Zhang <jessica.zhang@oss.qualcomm.com>,
	Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
	Maxime Ripard <mripard@kernel.org>,
	Thomas Zimmermann <tzimmermann@suse.de>,
	David Airlie <airlied@gmail.com>, Simona Vetter <simona@ffwll.ch>,
	dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] drm/panel: osd-osd101t2587-53ts: migrate to mipi_dsi_turn_on_peripheral_multi
Date: Tue, 16 Dec 2025 11:15:31 +0100	[thread overview]
Message-ID: <8ef57d2e-9a43-434f-89d6-e99c0892abef@linaro.org> (raw)
In-Reply-To: <e80fd81e-fba2-4385-9fed-9d82b2e5b2cf@linaro.org>

On 11/20/25 08:52, Neil Armstrong wrote:
> On 11/20/25 03:25, Matt Smith wrote:
>> Documentation/gpu/todo.rst lists to transition away from using
>> deprecated methods in drm_mipi_dsi.c, so migrating from
>> mipi_dsi_turn_on_peripheral to mipi_dsi_turn_on_peripheral_multi.
>>
>> Used commit e139c0eb22ce ("drm/panel: mantix-mlaf057we51: transition
>> to mipi_dsi wrapped functions") as a reference.
>>
>> Signed-off-by: Matt Smith <matthew.j.smith2@outlook.com>
>> ---
>>   drivers/gpu/drm/panel/panel-osd-osd101t2587-53ts.c | 11 ++++++-----
>>   1 file changed, 6 insertions(+), 5 deletions(-)
>>
>> diff --git a/drivers/gpu/drm/panel/panel-osd-osd101t2587-53ts.c b/drivers/gpu/drm/panel/panel-osd-osd101t2587-53ts.c
>> index 2334b77f348c..45baf2c238d2 100644
>> --- a/drivers/gpu/drm/panel/panel-osd-osd101t2587-53ts.c
>> +++ b/drivers/gpu/drm/panel/panel-osd-osd101t2587-53ts.c
>> @@ -58,13 +58,14 @@ static int osd101t2587_panel_prepare(struct drm_panel *panel)
>>   static int osd101t2587_panel_enable(struct drm_panel *panel)
>>   {
>>          struct osd101t2587_panel *osd101t2587 = ti_osd_panel(panel);
>> -       int ret;
>>
>> -       ret = mipi_dsi_turn_on_peripheral(osd101t2587->dsi);
>> -       if (ret)
>> -               return ret;
>> +       struct mipi_dsi_multi_context dsi_ctx = {
>> +               .dsi = osd101t2587->dsi
>> +       };
>>
>> -       return ret;
>> +       mipi_dsi_turn_on_peripheral_multi(&dsi_ctx);
>> +
>> +       return dsi_ctx.accum_err;
>>   }
>>
>>   static const struct drm_display_mode default_mode_osd101t2587 = {
>> -- 
>> 2.49.0
>>
> 
> Reviewed-by: Neil Armstrong <neil.armstrong@linaro.org>

This doesn't apply anymore, please rebase.

Neil

      reply	other threads:[~2025-12-16 10:15 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-11-20  2:25 Matt Smith
2025-11-20  7:52 ` Neil Armstrong
2025-12-16 10:15   ` Neil Armstrong [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8ef57d2e-9a43-434f-89d6-e99c0892abef@linaro.org \
    --to=neil.armstrong@linaro.org \
    --cc=airlied@gmail.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=jessica.zhang@oss.qualcomm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=maarten.lankhorst@linux.intel.com \
    --cc=matthew.j.smith2@outlook.com \
    --cc=mripard@kernel.org \
    --cc=simona@ffwll.ch \
    --cc=tzimmermann@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®