* [PATCH] drm/panel: osd-osd101t2587-53ts: migrate to mipi_dsi_turn_on_peripheral_multi
@ 2025-11-20 2:25 Matt Smith
2025-11-20 7:52 ` Neil Armstrong
0 siblings, 1 reply; 3+ messages in thread
From: Matt Smith @ 2025-11-20 2:25 UTC (permalink / raw)
To: Neil Armstrong
Cc: Jessica Zhang, Maarten Lankhorst, Maxime Ripard,
Thomas Zimmermann, David Airlie, Simona Vetter, dri-devel,
linux-kernel
Documentation/gpu/todo.rst lists to transition away from using
deprecated methods in drm_mipi_dsi.c, so migrating from
mipi_dsi_turn_on_peripheral to mipi_dsi_turn_on_peripheral_multi.
Used commit e139c0eb22ce ("drm/panel: mantix-mlaf057we51: transition
to mipi_dsi wrapped functions") as a reference.
Signed-off-by: Matt Smith <matthew.j.smith2@outlook.com>
---
drivers/gpu/drm/panel/panel-osd-osd101t2587-53ts.c | 11 ++++++-----
1 file changed, 6 insertions(+), 5 deletions(-)
diff --git a/drivers/gpu/drm/panel/panel-osd-osd101t2587-53ts.c b/drivers/gpu/drm/panel/panel-osd-osd101t2587-53ts.c
index 2334b77f348c..45baf2c238d2 100644
--- a/drivers/gpu/drm/panel/panel-osd-osd101t2587-53ts.c
+++ b/drivers/gpu/drm/panel/panel-osd-osd101t2587-53ts.c
@@ -58,13 +58,14 @@ static int osd101t2587_panel_prepare(struct drm_panel *panel)
static int osd101t2587_panel_enable(struct drm_panel *panel)
{
struct osd101t2587_panel *osd101t2587 = ti_osd_panel(panel);
- int ret;
- ret = mipi_dsi_turn_on_peripheral(osd101t2587->dsi);
- if (ret)
- return ret;
+ struct mipi_dsi_multi_context dsi_ctx = {
+ .dsi = osd101t2587->dsi
+ };
- return ret;
+ mipi_dsi_turn_on_peripheral_multi(&dsi_ctx);
+
+ return dsi_ctx.accum_err;
}
static const struct drm_display_mode default_mode_osd101t2587 = {
--
2.49.0
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] drm/panel: osd-osd101t2587-53ts: migrate to mipi_dsi_turn_on_peripheral_multi
2025-11-20 2:25 [PATCH] drm/panel: osd-osd101t2587-53ts: migrate to mipi_dsi_turn_on_peripheral_multi Matt Smith
@ 2025-11-20 7:52 ` Neil Armstrong
2025-12-16 10:15 ` Neil Armstrong
0 siblings, 1 reply; 3+ messages in thread
From: Neil Armstrong @ 2025-11-20 7:52 UTC (permalink / raw)
To: Matt Smith
Cc: Jessica Zhang, Maarten Lankhorst, Maxime Ripard,
Thomas Zimmermann, David Airlie, Simona Vetter, dri-devel,
linux-kernel
On 11/20/25 03:25, Matt Smith wrote:
> Documentation/gpu/todo.rst lists to transition away from using
> deprecated methods in drm_mipi_dsi.c, so migrating from
> mipi_dsi_turn_on_peripheral to mipi_dsi_turn_on_peripheral_multi.
>
> Used commit e139c0eb22ce ("drm/panel: mantix-mlaf057we51: transition
> to mipi_dsi wrapped functions") as a reference.
>
> Signed-off-by: Matt Smith <matthew.j.smith2@outlook.com>
> ---
> drivers/gpu/drm/panel/panel-osd-osd101t2587-53ts.c | 11 ++++++-----
> 1 file changed, 6 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/gpu/drm/panel/panel-osd-osd101t2587-53ts.c b/drivers/gpu/drm/panel/panel-osd-osd101t2587-53ts.c
> index 2334b77f348c..45baf2c238d2 100644
> --- a/drivers/gpu/drm/panel/panel-osd-osd101t2587-53ts.c
> +++ b/drivers/gpu/drm/panel/panel-osd-osd101t2587-53ts.c
> @@ -58,13 +58,14 @@ static int osd101t2587_panel_prepare(struct drm_panel *panel)
> static int osd101t2587_panel_enable(struct drm_panel *panel)
> {
> struct osd101t2587_panel *osd101t2587 = ti_osd_panel(panel);
> - int ret;
>
> - ret = mipi_dsi_turn_on_peripheral(osd101t2587->dsi);
> - if (ret)
> - return ret;
> + struct mipi_dsi_multi_context dsi_ctx = {
> + .dsi = osd101t2587->dsi
> + };
>
> - return ret;
> + mipi_dsi_turn_on_peripheral_multi(&dsi_ctx);
> +
> + return dsi_ctx.accum_err;
> }
>
> static const struct drm_display_mode default_mode_osd101t2587 = {
> --
> 2.49.0
>
Reviewed-by: Neil Armstrong <neil.armstrong@linaro.org>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] drm/panel: osd-osd101t2587-53ts: migrate to mipi_dsi_turn_on_peripheral_multi
2025-11-20 7:52 ` Neil Armstrong
@ 2025-12-16 10:15 ` Neil Armstrong
0 siblings, 0 replies; 3+ messages in thread
From: Neil Armstrong @ 2025-12-16 10:15 UTC (permalink / raw)
To: Matt Smith
Cc: Jessica Zhang, Maarten Lankhorst, Maxime Ripard,
Thomas Zimmermann, David Airlie, Simona Vetter, dri-devel,
linux-kernel
On 11/20/25 08:52, Neil Armstrong wrote:
> On 11/20/25 03:25, Matt Smith wrote:
>> Documentation/gpu/todo.rst lists to transition away from using
>> deprecated methods in drm_mipi_dsi.c, so migrating from
>> mipi_dsi_turn_on_peripheral to mipi_dsi_turn_on_peripheral_multi.
>>
>> Used commit e139c0eb22ce ("drm/panel: mantix-mlaf057we51: transition
>> to mipi_dsi wrapped functions") as a reference.
>>
>> Signed-off-by: Matt Smith <matthew.j.smith2@outlook.com>
>> ---
>> drivers/gpu/drm/panel/panel-osd-osd101t2587-53ts.c | 11 ++++++-----
>> 1 file changed, 6 insertions(+), 5 deletions(-)
>>
>> diff --git a/drivers/gpu/drm/panel/panel-osd-osd101t2587-53ts.c b/drivers/gpu/drm/panel/panel-osd-osd101t2587-53ts.c
>> index 2334b77f348c..45baf2c238d2 100644
>> --- a/drivers/gpu/drm/panel/panel-osd-osd101t2587-53ts.c
>> +++ b/drivers/gpu/drm/panel/panel-osd-osd101t2587-53ts.c
>> @@ -58,13 +58,14 @@ static int osd101t2587_panel_prepare(struct drm_panel *panel)
>> static int osd101t2587_panel_enable(struct drm_panel *panel)
>> {
>> struct osd101t2587_panel *osd101t2587 = ti_osd_panel(panel);
>> - int ret;
>>
>> - ret = mipi_dsi_turn_on_peripheral(osd101t2587->dsi);
>> - if (ret)
>> - return ret;
>> + struct mipi_dsi_multi_context dsi_ctx = {
>> + .dsi = osd101t2587->dsi
>> + };
>>
>> - return ret;
>> + mipi_dsi_turn_on_peripheral_multi(&dsi_ctx);
>> +
>> + return dsi_ctx.accum_err;
>> }
>>
>> static const struct drm_display_mode default_mode_osd101t2587 = {
>> --
>> 2.49.0
>>
>
> Reviewed-by: Neil Armstrong <neil.armstrong@linaro.org>
This doesn't apply anymore, please rebase.
Neil
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2025-12-16 10:15 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2025-11-20 2:25 [PATCH] drm/panel: osd-osd101t2587-53ts: migrate to mipi_dsi_turn_on_peripheral_multi Matt Smith
2025-11-20 7:52 ` Neil Armstrong
2025-12-16 10:15 ` Neil Armstrong
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®