From: Chao Yu <yuchao0@huawei.com>
To: Yunlong Song <yunlong.song@huawei.com>, <jaegeuk@kernel.org>,
<chao@kernel.org>, <yunlong.song@icloud.com>
Cc: <miaoxie@huawei.com>, <bintian.wang@huawei.com>,
<shengyong1@huawei.com>, <heyunlei@huawei.com>,
<linux-fsdevel@vger.kernel.org>,
<linux-f2fs-devel@lists.sourceforge.net>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2] f2fs: check segment type in __f2fs_replace_block
Date: Thu, 4 Jan 2018 13:56:33 +0800 [thread overview]
Message-ID: <8f04c997-cfed-1ee2-9b10-37955ce15f9e@huawei.com> (raw)
In-Reply-To: <1515037705-23984-1-git-send-email-yunlong.song@huawei.com>
Please add simple description here to explain why we need to add this, even
though this change is very simple.
On 2018/1/4 11:48, Yunlong Song wrote:
> Signed-off-by: Yunlong Song <yunlong.song@huawei.com>
> ---
> fs/f2fs/segment.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/fs/f2fs/segment.c b/fs/f2fs/segment.c
> index 890d483..e3bbabf 100644
> --- a/fs/f2fs/segment.c
> +++ b/fs/f2fs/segment.c
> @@ -2719,6 +2719,8 @@ void __f2fs_replace_block(struct f2fs_sb_info *sbi, struct f2fs_summary *sum,
> se = get_seg_entry(sbi, segno);
> type = se->type;
>
> + f2fs_bug_on(sbi, se->valid_blocks && IS_NODESEG(type));
> +
> down_write(&SM_I(sbi)->curseg_lock);
>
> if (!recover_curseg) {
>
next prev parent reply other threads:[~2018-01-04 5:56 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-30 7:42 [PATCH] f2fs: check segment type before recover data Yunlong Song
2018-01-02 6:49 ` Chao Yu
2018-01-02 11:02 ` Yunlong Song
2018-01-04 1:38 ` Chao Yu
2018-01-03 20:04 ` Jaegeuk Kim
2018-01-04 3:48 ` [PATCH v2] f2fs: check segment type in __f2fs_replace_block Yunlong Song
2018-01-04 5:56 ` Chao Yu [this message]
2018-01-04 6:24 ` [PATCH v3] " Yunlong Song
2018-01-04 6:54 ` Jaegeuk Kim
2018-01-04 7:02 ` [PATCH v4] " Yunlong Song
2018-01-04 7:10 ` Jaegeuk Kim
2018-01-04 7:22 ` Chao Yu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8f04c997-cfed-1ee2-9b10-37955ce15f9e@huawei.com \
--to=yuchao0@huawei.com \
--cc=bintian.wang@huawei.com \
--cc=chao@kernel.org \
--cc=heyunlei@huawei.com \
--cc=jaegeuk@kernel.org \
--cc=linux-f2fs-devel@lists.sourceforge.net \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=miaoxie@huawei.com \
--cc=shengyong1@huawei.com \
--cc=yunlong.song@huawei.com \
--cc=yunlong.song@icloud.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®