* [PATCH] scsi: qedf: Remove unesseary function call
@ 2026-10-29 16:04 Jesse Taube
2026-10-29 16:36 ` Laurence Oberman
2026-10-29 21:15 ` John Meneghini
0 siblings, 2 replies; 3+ messages in thread
From: Jesse Taube @ 2026-10-29 16:04 UTC (permalink / raw)
To: Martin K. Petersen
Cc: linux-scsi, linux-kernel, James E.J. Bottomley,
Nimal Prabudoss I, jmeneghi, Nilesh Javali, Manish Rangankar,
GR-ETH-Storage-Upstream, Jesse Taube
The result of `skb_transport_header` was unused. Calling this function
warned when `skb_transport_header_was_set` returned false causing a
panic on debug kernels.
Signed-off-by: Jesse Taube <jtaubepe@redhat.com>
---
drivers/scsi/qedf/qedf_main.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/scsi/qedf/qedf_main.c b/drivers/scsi/qedf/qedf_main.c
index da429b3a4283..f2bc0ac684e0 100644
--- a/drivers/scsi/qedf/qedf_main.c
+++ b/drivers/scsi/qedf/qedf_main.c
@@ -2496,7 +2496,6 @@ static void qedf_recv_frame(struct qedf_ctx *qedf,
/* Pull the header */
hp = (struct fcoe_hdr *)skb->data;
- fh = (struct fc_frame_header *) skb_transport_header(skb);
skb_pull(skb, sizeof(struct fcoe_hdr));
fr_len = skb->len - sizeof(struct fcoe_crc_eof);
--
2.56.0
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] scsi: qedf: Remove unesseary function call
2026-10-29 16:04 [PATCH] scsi: qedf: Remove unesseary function call Jesse Taube
@ 2026-10-29 16:36 ` Laurence Oberman
2026-10-29 21:15 ` John Meneghini
1 sibling, 0 replies; 3+ messages in thread
From: Laurence Oberman @ 2026-10-29 16:36 UTC (permalink / raw)
To: Jesse Taube, Martin K. Petersen
Cc: linux-scsi, linux-kernel, James E.J. Bottomley,
Nimal Prabudoss I, jmeneghi, Nilesh Javali, Manish Rangankar,
GR-ETH-Storage-Upstream
On Thu, 2026-10-29 at 12:04 -0400, Jesse Taube wrote:
> The result of `skb_transport_header` was unused. Calling this
> function
> warned when `skb_transport_header_was_set` returned false causing a
> panic on debug kernels.
>
> Signed-off-by: Jesse Taube <jtaubepe@redhat.com>
> ---
> drivers/scsi/qedf/qedf_main.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/scsi/qedf/qedf_main.c
> b/drivers/scsi/qedf/qedf_main.c
> index da429b3a4283..f2bc0ac684e0 100644
> --- a/drivers/scsi/qedf/qedf_main.c
> +++ b/drivers/scsi/qedf/qedf_main.c
> @@ -2496,7 +2496,6 @@ static void qedf_recv_frame(struct qedf_ctx
> *qedf,
>
> /* Pull the header */
> hp = (struct fcoe_hdr *)skb->data;
> - fh = (struct fc_frame_header *) skb_transport_header(skb);
> skb_pull(skb, sizeof(struct fcoe_hdr));
> fr_len = skb->len - sizeof(struct fcoe_crc_eof);
>
Looks good
Reviewed-by: Laurence Oberman <loberman@redhat.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] scsi: qedf: Remove unesseary function call
2026-10-29 16:04 [PATCH] scsi: qedf: Remove unesseary function call Jesse Taube
2026-10-29 16:36 ` Laurence Oberman
@ 2026-10-29 21:15 ` John Meneghini
1 sibling, 0 replies; 3+ messages in thread
From: John Meneghini @ 2026-10-29 21:15 UTC (permalink / raw)
To: Martin K. Petersen, Nilesh Javali, Manish Rangankar
Cc: linux-scsi, linux-kernel, James E.J. Bottomley,
Nimal Prabudoss I, GR-ETH-Storage-Upstream, Jesse Taube
Reviewed-by: John Meneghini <jmeneghi@redhat.com>
Nilesh or Manish now that you are on the MAINTAINERS list for this file, can we get an ACK from you?
I really want Martin to merge this so we can move forward with some of these bugs, and he needs your ACK.
Thanks,
/John
On 10/29/26 12:04, Jesse Taube wrote:
> The result of `skb_transport_header` was unused. Calling this function
> warned when `skb_transport_header_was_set` returned false causing a
> panic on debug kernels.
>
> Signed-off-by: Jesse Taube <jtaubepe@redhat.com>
> ---
> drivers/scsi/qedf/qedf_main.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/scsi/qedf/qedf_main.c b/drivers/scsi/qedf/qedf_main.c
> index da429b3a4283..f2bc0ac684e0 100644
> --- a/drivers/scsi/qedf/qedf_main.c
> +++ b/drivers/scsi/qedf/qedf_main.c
> @@ -2496,7 +2496,6 @@ static void qedf_recv_frame(struct qedf_ctx *qedf,
>
> /* Pull the header */
> hp = (struct fcoe_hdr *)skb->data;
> - fh = (struct fc_frame_header *) skb_transport_header(skb);
> skb_pull(skb, sizeof(struct fcoe_hdr));
> fr_len = skb->len - sizeof(struct fcoe_crc_eof);
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2026-10-29 21:15 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-10-29 16:04 [PATCH] scsi: qedf: Remove unesseary function call Jesse Taube
2026-10-29 16:36 ` Laurence Oberman
2026-10-29 21:15 ` John Meneghini
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®