[PATCH V2] x86/idt: traceponit.c: fix comment for irq vector tracepoints

[PATCH V2] x86/idt: traceponit.c: fix comment for irq vector tracepoints

[sunliming]

Commit:

  4b9a8dca0e58 ("x86/idt: Remove the tracing IDT completely")

removed the 'tracing IDT' from arch/x86/kernel/tracepoint.c,
but left related comment. So that the comment become anachronistic.
Just remove the comment.

Signed-off-by: sunliming <sunliming@kylinos.cn>
---
 arch/x86/kernel/tracepoint.c | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/arch/x86/kernel/tracepoint.c b/arch/x86/kernel/tracepoint.c
index fcfc077afe2d..065191022035 100644
--- a/arch/x86/kernel/tracepoint.c
+++ b/arch/x86/kernel/tracepoint.c
@@ -1,9 +1,6 @@
 // SPDX-License-Identifier: GPL-2.0
 /*
- * Code for supporting irq vector tracepoints.
- *
  * Copyright (C) 2013 Seiji Aguchi <seiji.aguchi@hds.com>
- *
  */
 #include <linux/jump_label.h>
 #include <linux/atomic.h>
-- 
2.25.1

Re: [PATCH V2] x86/idt: traceponit.c: fix comment for irq vector tracepoints

[Dave Hansen]

On 5/26/22 04:08, sunliming wrote:
> 
> diff --git a/arch/x86/kernel/tracepoint.c b/arch/x86/kernel/tracepoint.c
> index fcfc077afe2d..065191022035 100644
> --- a/arch/x86/kernel/tracepoint.c
> +++ b/arch/x86/kernel/tracepoint.c
> @@ -1,9 +1,6 @@
>  // SPDX-License-Identifier: GPL-2.0
>  /*
> - * Code for supporting irq vector tracepoints.
> - *
>   * Copyright (C) 2013 Seiji Aguchi <seiji.aguchi@hds.com>
> - *
>   */
>  #include <linux/jump_label.h>
>  #include <linux/atomic.h>

While I'm also generally careful about removing others' copyrights, Mr.
Aguchi only touched this file once and all of the code from that one
touch appears to be gone to me.  Shouldn't we just zap the whole comment?

Re: [PATCH V2] x86/idt: traceponit.c: fix comment for irq vector tracepoints

[Steven Rostedt]

On Thu, 26 May 2022 09:24:31 -0700
Dave Hansen <dave.hansen@intel.com> wrote:

> On 5/26/22 04:08, sunliming wrote:
> > 
> > diff --git a/arch/x86/kernel/tracepoint.c b/arch/x86/kernel/tracepoint.c
> > index fcfc077afe2d..065191022035 100644
> > --- a/arch/x86/kernel/tracepoint.c
> > +++ b/arch/x86/kernel/tracepoint.c
> > @@ -1,9 +1,6 @@
> >  // SPDX-License-Identifier: GPL-2.0
> >  /*
> > - * Code for supporting irq vector tracepoints.
> > - *
> >   * Copyright (C) 2013 Seiji Aguchi <seiji.aguchi@hds.com>
> > - *
> >   */
> >  #include <linux/jump_label.h>
> >  #include <linux/atomic.h>  
> 
> While I'm also generally careful about removing others' copyrights, Mr.
> Aguchi only touched this file once and all of the code from that one
> touch appears to be gone to me.  Shouldn't we just zap the whole comment?

Perhaps, but that's a different change than this is addressing. This is
only addressing fixing the comments about the removal of the code.

But looking at the history of this file. Seiji created it, but the only
code that remains in the file was mostly added by Thomas. The only lines
that Seiji has now is the whitespace and the brackets.

I would still have the removal of the copyright as a separate patch.

-- Steve