* [PATCH] thermal/drivers/airoha: Fix a device node reference leak in airoha_thermal_probe()
@ 2026-01-23 11:55 Felix Gu
2026-01-28 16:56 ` Lukasz Luba
0 siblings, 1 reply; 2+ messages in thread
From: Felix Gu @ 2026-01-23 11:55 UTC (permalink / raw)
To: Rafael J. Wysocki, Daniel Lezcano, Zhang Rui, Lukasz Luba,
Christian Marangi
Cc: linux-pm, linux-kernel, Felix Gu
In airoha_thermal_probe() function, chip-scu node is acquired through
of_parse_phandle(), but it fails to release this reference if
syscon_node_to_regmap() returns an error.
Add the missing of_node_put() call to the error path to ensure the
reference count is properly decremented.
Fixes: 42de37f40e1b ("thermal/drivers: Add support for Airoha EN7581 thermal sensor")
Signed-off-by: Felix Gu <ustc.gu@gmail.com>
---
drivers/thermal/airoha_thermal.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/thermal/airoha_thermal.c b/drivers/thermal/airoha_thermal.c
index b9fd6bfc88e5..308ea846ba26 100644
--- a/drivers/thermal/airoha_thermal.c
+++ b/drivers/thermal/airoha_thermal.c
@@ -431,8 +431,10 @@ static int airoha_thermal_probe(struct platform_device *pdev)
return -EINVAL;
priv->chip_scu = syscon_node_to_regmap(chip_scu_np);
- if (IS_ERR(priv->chip_scu))
+ if (IS_ERR(priv->chip_scu)) {
+ of_node_put(chip_scu_np);
return PTR_ERR(priv->chip_scu);
+ }
of_address_to_resource(chip_scu_np, 0, &priv->scu_adc_res);
of_node_put(chip_scu_np);
---
base-commit: a0c666c25aeefd16f4b088c6549a6fb6b65a8a1d
change-id: 20260123-airoha-ccd6a16a6ef6
Best regards,
--
Felix Gu <ustc.gu@gmail.com>
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] thermal/drivers/airoha: Fix a device node reference leak in airoha_thermal_probe()
2026-01-23 11:55 [PATCH] thermal/drivers/airoha: Fix a device node reference leak in airoha_thermal_probe() Felix Gu
@ 2026-01-28 16:56 ` Lukasz Luba
0 siblings, 0 replies; 2+ messages in thread
From: Lukasz Luba @ 2026-01-28 16:56 UTC (permalink / raw)
To: Felix Gu
Cc: linux-pm, Christian Marangi, linux-kernel, Rafael J. Wysocki,
Daniel Lezcano, Zhang Rui
Hi Felix,
On 1/23/26 11:55, Felix Gu wrote:
> In airoha_thermal_probe() function, chip-scu node is acquired through
> of_parse_phandle(), but it fails to release this reference if
> syscon_node_to_regmap() returns an error.
> Add the missing of_node_put() call to the error path to ensure the
> reference count is properly decremented.
>
> Fixes: 42de37f40e1b ("thermal/drivers: Add support for Airoha EN7581 thermal sensor")
> Signed-off-by: Felix Gu <ustc.gu@gmail.com>
> ---
> drivers/thermal/airoha_thermal.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/thermal/airoha_thermal.c b/drivers/thermal/airoha_thermal.c
> index b9fd6bfc88e5..308ea846ba26 100644
> --- a/drivers/thermal/airoha_thermal.c
> +++ b/drivers/thermal/airoha_thermal.c
> @@ -431,8 +431,10 @@ static int airoha_thermal_probe(struct platform_device *pdev)
> return -EINVAL;
>
> priv->chip_scu = syscon_node_to_regmap(chip_scu_np);
> - if (IS_ERR(priv->chip_scu))
> + if (IS_ERR(priv->chip_scu)) {
> + of_node_put(chip_scu_np);
> return PTR_ERR(priv->chip_scu);
> + }
>
> of_address_to_resource(chip_scu_np, 0, &priv->scu_adc_res);
> of_node_put(chip_scu_np);
Thank you for the patch, LGTM.
Reviewed-by: Lukasz Luba <lukasz.luba@arm.com>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2026-01-28 16:56 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-01-23 11:55 [PATCH] thermal/drivers/airoha: Fix a device node reference leak in airoha_thermal_probe() Felix Gu
2026-01-28 16:56 ` Lukasz Luba
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®