mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
To: Rik van Riel <riel@surriel.com>, linux-kernel@vger.kernel.org
Cc: kernel-team@meta.com, Ingo Molnar <mingo@redhat.com>,
	Peter Zijlstra <peterz@infradead.org>,
	Juri Lelli <juri.lelli@redhat.com>,
	Vincent Guittot <vincent.guittot@linaro.org>,
	Thomas Gleixner <tglx@linutronix.de>,
	Dietmar Eggemann <dietmar.eggemann@arm.com>,
	Steven Rostedt <rostedt@goodmis.org>,
	Ben Segall <bsegall@google.com>, Mel Gorman <mgorman@suse.de>,
	Valentin Schneider <vschneid@redhat.com>,
	K Prateek Nayak <kprateek.nayak@amd.com>
Subject: Re: [PATCH] sched/mmcid: fix OOB clear_bit when CID is MM_CID_UNSET in fixup path
Date: Tue, 16 Jun 2026 15:38:40 -0400	[thread overview]
Message-ID: <902df747-5564-4762-b588-39b58d969536@efficios.com> (raw)
In-Reply-To: <d307ca42-b45c-421a-aa85-9de2ec4755e6@efficios.com>

On 2026-06-16 12:09, Mathieu Desnoyers wrote:
> On 2026-06-16 10:53, Rik van Riel wrote:
[...]
> 
> Did you try changing this to the following (completely untested) check 
> instead:
> 
>    if (!cid_in_transit(cid) && !(cid & MM_CID_UNSET)) { ?

Note: "MM_CID_UNSET" is technically a flag (bit 31), but is always set
with a value store and used with an equality check, so you may prefer:

   if (cid != MM_CID_UNSET && !cid_in_transit(cid)) {

Thanks,

Mathieu

> 
> Thanks,
> 
> Mathieu
> 
>>                   cid = cid_to_transit_cid(cid);
>>                   rq->curr->mm_cid.cid = cid;
>>                   pcp->cid = cid;
> 
> 


-- 
Mathieu Desnoyers
EfficiOS Inc.
https://www.efficios.com

  reply	other threads:[~2026-06-16 19:38 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-06-16 14:53 Rik van Riel
2026-06-16 16:09 ` Mathieu Desnoyers
2026-06-16 19:38   ` Mathieu Desnoyers [this message]
2026-06-16 19:56 Rik van Riel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=902df747-5564-4762-b588-39b58d969536@efficios.com \
    --to=mathieu.desnoyers@efficios.com \
    --cc=bsegall@google.com \
    --cc=dietmar.eggemann@arm.com \
    --cc=juri.lelli@redhat.com \
    --cc=kernel-team@meta.com \
    --cc=kprateek.nayak@amd.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mgorman@suse.de \
    --cc=mingo@redhat.com \
    --cc=peterz@infradead.org \
    --cc=riel@surriel.com \
    --cc=rostedt@goodmis.org \
    --cc=tglx@linutronix.de \
    --cc=vincent.guittot@linaro.org \
    --cc=vschneid@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®