mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Siddharth Vadapalli <s-vadapalli@ti.com>
To: Roger Quadros <rogerq@kernel.org>
Cc: Siddharth Vadapalli <s-vadapalli@ti.com>, <nm@ti.com>,
	<vigneshr@ti.com>, <afd@ti.com>, <kristo@kernel.org>,
	<robh@kernel.org>, <krzk+dt@kernel.org>, <conor+dt@kernel.org>,
	<devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
	<linux-arm-kernel@lists.infradead.org>, <u-kumar1@ti.com>,
	<danishanwar@ti.com>, <srk@ti.com>
Subject: Re: [PATCH v5 1/7] arm64: dts: ti: am62p: Rename am62p-{}.dtsi to am62p-j722s-common-{}.dtsi
Date: Fri, 7 Jun 2024 16:58:34 +0530	[thread overview]
Message-ID: <902f024a-b0a1-4a0a-94e2-7cec064a91c6@ti.com> (raw)
In-Reply-To: <92af5f36-0c21-4b6e-adde-fcf21b540291@kernel.org>

On Thu, Jun 06, 2024 at 10:51:27AM +0300, Roger Quadros wrote:

[...]

> >  5 files changed, 10 insertions(+), 7 deletions(-)
> >  rename arch/arm64/boot/dts/ti/{k3-am62p-main.dtsi => k3-am62p-j722s-common-main.dtsi} (99%)
> >  rename arch/arm64/boot/dts/ti/{k3-am62p-mcu.dtsi => k3-am62p-j722s-common-mcu.dtsi} (98%)
> >  rename arch/arm64/boot/dts/ti/{k3-am62p-wakeup.dtsi => k3-am62p-j722s-common-wakeup.dtsi} (97%)
> >  rename arch/arm64/boot/dts/ti/{k3-am62p.dtsi => k3-am62p-j722s-common.dtsi} (97%)
> 
> This is not correct.
> If J722 has different CBASS components than AM62p then we should leave k3-am62p.dtsi
> as it is and introduce a new k3-j722.dtsi with relevant CBASS components.

Roger,

The existing hierarchy prior to this series is as follows:
k3-am62p.dtsi = k3-am62p-main.dtsi + k3-am62p-mcu.dtsi +
		k3-am62p-wakeup.dtsi + k3-am62p-thermal.dtsi + <delta-1>
k3-am62p5.dtsi = k3-am62p.dtsi + <delta-2>
k3-j722s.dtsi = k3-am62p5.dtsi + <delta-3>
k3-j722s-evm.dts = k3-j722s.dtsi + <detla-4>

Based on your suggestion, you seem to propose the following hierarchy:
k3-am62p-{main,mcu,thermal,wakeup}.dtsi = AM62P specific data
k3-am62p.dtsi = k3-am62p-j722s-common-main.dtsi +
		k3-am62p-j722s-common-mcu.dtsi +
		k3-am62p-j722s-common-wakeup.dtsi +
		k3-am62p-j722s-common-thermal.dtsi +
		k3-am62p-{main,mcu,thermal,wakeup}.dtsi +
		<delta-5>
k3-am62p5.dtsi = k3-am62p.dtsi + <delta-2>
k3-j722s-{main,mcu,thermal,wakeup}.dtsi = J722S specific data
k3-j722s.dtsi = k3-am62p-j722s-common-main.dtsi +
		k3-am62p-j722s-common-mcu.dtsi +
		k3-am62p-j722s-common-wakeup.dtsi +
		k3-am62p-j722s-common-thermal.dtsi +
		k3-j722s-{main,mcu,thermal,wakeup}.dtsi +
		<delta-6>
k3-j722s-evm.dts = k3-j722s.dtsi + <delta-4>

Please let me know whether the above organization of files matches what you
expect it to look like. I will post the v6 series based on your feedback.

Regards,
Siddharth.

  reply	other threads:[~2024-06-07 11:28 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-06-04  8:52 [PATCH v5 0/7] Add PCIe, SERDES and USB DT support for J722S Siddharth Vadapalli
2024-06-04  8:52 ` [PATCH v5 1/7] arm64: dts: ti: am62p: Rename am62p-{}.dtsi to am62p-j722s-common-{}.dtsi Siddharth Vadapalli
2024-06-06  7:51   ` Roger Quadros
2024-06-07 11:28     ` Siddharth Vadapalli [this message]
2024-06-10 19:31       ` Roger Quadros
2024-06-11  8:54         ` Siddharth Vadapalli
2024-06-11  9:10           ` Vignesh Raghavendra
2024-06-11 17:18             ` Roger Quadros
2024-06-12  9:11               ` Siddharth Vadapalli
2024-06-04  8:52 ` [PATCH v5 2/7] arm64: dts: ti: k3-am62p-j722s: Move AM62P specific USB1 to am62p-main.dtsi Siddharth Vadapalli
2024-06-06  8:01   ` Roger Quadros
2024-06-04  8:52 ` [PATCH v5 3/7] arm64: dts: ti: k3-j722s: Add main domain peripherals specific to J722S Siddharth Vadapalli
2024-06-06  8:02   ` Roger Quadros
2024-06-04  8:52 ` [PATCH v5 4/7] arm64: dts: ti: k3-j722s: Switch to k3-am62p-j722s-common.dtsi Siddharth Vadapalli
2024-06-06  4:05   ` Vignesh Raghavendra
2024-06-06  7:34     ` Roger Quadros
2024-06-10  6:53       ` Vignesh Raghavendra
2024-06-04  8:52 ` [PATCH v5 5/7] arm64: dts: ti: k3-serdes: Add SERDES0/SERDES1 lane-muxing macros for J722S Siddharth Vadapalli
2024-06-06  7:35   ` Roger Quadros
2024-06-04  8:52 ` [PATCH v5 6/7] arm64: dts: ti: k3-j722s-main: Add SERDES and PCIe support Siddharth Vadapalli
2024-06-06  8:04   ` Roger Quadros
2024-06-04  8:52 ` [PATCH v5 7/7] arm64: dts: ti: k3-j722s: Enable PCIe and USB support on J722S-EVM Siddharth Vadapalli
2024-06-06  8:05   ` Roger Quadros

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=902f024a-b0a1-4a0a-94e2-7cec064a91c6@ti.com \
    --to=s-vadapalli@ti.com \
    --cc=afd@ti.com \
    --cc=conor+dt@kernel.org \
    --cc=danishanwar@ti.com \
    --cc=devicetree@vger.kernel.org \
    --cc=kristo@kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=nm@ti.com \
    --cc=robh@kernel.org \
    --cc=rogerq@kernel.org \
    --cc=srk@ti.com \
    --cc=u-kumar1@ti.com \
    --cc=vigneshr@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®