From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: neil.armstrong@linaro.org,
Srinivas Kandagatla <srinivas.kandagatla@linaro.org>,
Banajit Goswami <bgoswami@quicinc.com>,
Andy Gross <agross@kernel.org>,
Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konrad.dybcio@linaro.org>,
Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>, Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>
Cc: linux-arm-msm@vger.kernel.org, alsa-devel@alsa-project.org,
linux-sound@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/5] ASoC: dt-bindings: document WCD939x Audio Codec
Date: Tue, 28 Nov 2023 10:17:34 +0100 [thread overview]
Message-ID: <91528bf4-c971-415e-afb4-51791c6dfc91@linaro.org> (raw)
In-Reply-To: <752f5347-703a-4b38-b2b1-3493d270389c@linaro.org>
On 28/11/2023 10:14, neil.armstrong@linaro.org wrote:
>>
>> Here the device exposes its version in registers, so you can easily rely
>> on the compatibility. That's also the case multiple times talked on the
>> mailing lists.
>
> ... you're right here version can be determined at runtime.
>
> But, since both are compatible, there's no primary part number, right?
>
> so why use "qcom,wcd9395-codec", "qcom,wcd9390-codec"
This one, please.
> when "qcom,wcd9390-codec", "qcom,wcd9395-codec" should
> also be valid, so in this can why not use :
Could be valid, sure, but we are humans and we treat higher number as
something newer or bigger, thus previous one feels more natural. There
are examples of this way, though.
> "qcom,wcd9390-codec", "qcom,wcd939x-codec"
> or
> "qcom,wcd9395-codec", "qcom,wcd939x-codec"
This not, because wildcards are not allowed in the compatibles. In the
past there were examples how a wildcard stopped being wild, so guideline
is: just don't use them.
Best regards,
Krzysztof
next prev parent reply other threads:[~2023-11-28 9:17 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-23 14:49 [PATCH 0/5] ASoC: codecs: add support for WCD939x Codec Neil Armstrong
2023-11-23 14:49 ` [PATCH 1/5] ASoC: dt-bindings: qcom,wcd938x: move out common properties Neil Armstrong
2023-11-24 8:29 ` Krzysztof Kozlowski
2023-11-23 14:49 ` [PATCH 2/5] ASoC: dt-bindings: document WCD939x Audio Codec Neil Armstrong
2023-11-24 8:33 ` Krzysztof Kozlowski
2023-11-28 8:59 ` Neil Armstrong
2023-11-28 9:04 ` Krzysztof Kozlowski
2023-11-28 9:14 ` neil.armstrong
2023-11-28 9:17 ` Krzysztof Kozlowski [this message]
2023-11-28 9:19 ` neil.armstrong
2023-11-23 14:49 ` [PATCH 3/5] ASoC: codec: wcd-mbhc-v2: add support when connected behind an USB-C audio mux Neil Armstrong
2023-11-23 17:38 ` Mark Brown
2023-11-28 8:59 ` Neil Armstrong
2023-11-23 14:49 ` [PATCH 4/5] ASoC: codecs: Add WCD939x Soundwire slave driver Neil Armstrong
2023-11-23 17:43 ` Mark Brown
2023-11-28 9:09 ` Neil Armstrong
2023-11-28 12:47 ` Mark Brown
2023-11-28 13:19 ` Neil Armstrong
2023-11-25 11:55 ` Konrad Dybcio
2023-11-28 9:16 ` Neil Armstrong
2023-11-29 13:45 ` Konrad Dybcio
2023-11-23 14:49 ` [PATCH 5/5] ASoC: codecs: Add WCD939x Codec driver Neil Armstrong
2023-11-24 10:19 ` Mark Brown
2023-11-28 9:18 ` Neil Armstrong
2023-11-25 12:07 ` Konrad Dybcio
2023-11-28 9:22 ` Neil Armstrong
2023-11-28 15:01 ` Neil Armstrong
2023-11-29 13:46 ` Konrad Dybcio
2023-11-29 15:12 ` neil.armstrong
2023-11-29 18:21 ` Konrad Dybcio
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=91528bf4-c971-415e-afb4-51791c6dfc91@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=agross@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=andersson@kernel.org \
--cc=bgoswami@quicinc.com \
--cc=broonie@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=konrad.dybcio@linaro.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=neil.armstrong@linaro.org \
--cc=perex@perex.cz \
--cc=robh+dt@kernel.org \
--cc=srinivas.kandagatla@linaro.org \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®