mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Jonathan Cameron <jic23@kernel.org>
To: Peter Meerwald-Stadler <pmeerw@pmeerw.net>,
	Thierry Escande <thierry.escande@collabora.com>
Cc: Gwendal Grignou <gwendal@chromium.org>,
	linux-kernel@vger.kernel.org, linux-iio@vger.kernel.org
Subject: Re: [PATCH 2/3] iio: core: Add double tap as possible gesture
Date: Mon, 19 Dec 2016 21:11:10 +0000	[thread overview]
Message-ID: <9164eb64-55cc-f175-b4c1-3fe2288e0e12@kernel.org> (raw)
In-Reply-To: <alpine.DEB.2.02.1612061223550.29508@pmeerw.net>

On 06/12/16 11:25, Peter Meerwald-Stadler wrote:
> 
>> This adds the IIO_MOD_DOUBLE_TAP entry to the iio_modifier enum and the
>> corresponding "double_tap" string to the iio_modifier_names array.
> 
> I don't think we should have gestures as channel modifiers
Agreed, though treating it like other activities (walking, running etc) gave me
the thought that maybe there are exercise classes out there somewhere in
'double tapping'.

We don't actually have a good way of handling this at the moment, but it's
definitely an 'event' in IIO parlance rather than a modifier of a channel type.

It's irritatingly non general, but perhaps an event type is needed for
gestures with some abuse of the event code format when one turns up to allow
us to encode the type?

> probably a middle layer between IIO and input subsystem is needed (could 
> be in userspace?)
Could do it in userspace, but we probably ultimately want an in kernel
consumer interface for IIO events, and do the translation in a input
bridge using that...

Certainly bridging buffered data in userspace didn't turn out as neatly
as the in kernel version.

>  
>> Signed-off-by: Gwendal Grignou <gwendal@chromium.org>
>> Signed-off-by: Thierry Escande <thierry.escande@collabora.com>
>> ---
>>  drivers/iio/industrialio-core.c | 1 +
>>  include/uapi/linux/iio/types.h  | 1 +
>>  2 files changed, 2 insertions(+)
>>
>> diff --git a/drivers/iio/industrialio-core.c b/drivers/iio/industrialio-core.c
>> index fc340ed..82ce05f 100644
>> --- a/drivers/iio/industrialio-core.c
>> +++ b/drivers/iio/industrialio-core.c
>> @@ -120,6 +120,7 @@ static const char * const iio_modifier_names[] = {
>>  	[IIO_MOD_Q] = "q",
>>  	[IIO_MOD_CO2] = "co2",
>>  	[IIO_MOD_VOC] = "voc",
>> +	[IIO_MOD_DOUBLE_TAP] = "double_tap",
>>  };
>>  
>>  /* relies on pairs of these shared then separate */
>> diff --git a/include/uapi/linux/iio/types.h b/include/uapi/linux/iio/types.h
>> index 22e5e58..47d2768 100644
>> --- a/include/uapi/linux/iio/types.h
>> +++ b/include/uapi/linux/iio/types.h
>> @@ -80,6 +80,7 @@ enum iio_modifier {
>>  	IIO_MOD_CO2,
>>  	IIO_MOD_VOC,
>>  	IIO_MOD_LIGHT_UV,
>> +	IIO_MOD_DOUBLE_TAP,
>>  };
>>  
>>  enum iio_event_type {
>>
> 

  reply	other threads:[~2016-12-19 21:11 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-12-05  9:13 [PATCH 0/3] Add ChromeOS EC Activity Sensors driver Thierry Escande
2016-12-05  9:13 ` [PATCH 1/3] mfd: cros_ec: Add activity motion sense definitions Thierry Escande
2017-01-03 15:51   ` Lee Jones
2016-12-05  9:13 ` [PATCH 2/3] iio: core: Add double tap as possible gesture Thierry Escande
2016-12-06 11:25   ` Peter Meerwald-Stadler
2016-12-19 21:11     ` Jonathan Cameron [this message]
2017-06-08  1:10       ` Gwendal Grignou
2017-06-11 14:46         ` Jonathan Cameron
2016-12-05  9:13 ` [PATCH 3/3] iio: cros_ec_activity: add ChromeOS EC Activity Sensors Thierry Escande
2016-12-07  2:15   ` kbuild test robot
2016-12-18 16:37   ` kbuild test robot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=9164eb64-55cc-f175-b4c1-3fe2288e0e12@kernel.org \
    --to=jic23@kernel.org \
    --cc=gwendal@chromium.org \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=pmeerw@pmeerw.net \
    --cc=thierry.escande@collabora.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®