Re: [PATCH v4 2/2] regulator: add SGM3804 Dual Output driver

[Neil Armstrong <neil.armstrong@linaro.org>]

Hi Mark,

On 5/6/26 09:34, Neil Armstrong wrote:
> From: KancyJoe <kancy2333@outlook.com>
> 
> Add support for the SG Micro SGM3804 Single Inductor Dual Output
> Buck/Boost Converter used to power LCD panels a provide positive
> and negative power rails with configurable voltage and active
> discharge function for each output.
> 
> The SGM3804 is powered by the enable GPIO pins inputs and only
> supports I2C write messages.
> In order to add flexibility and simplify the driver, the
> regmap cache is enabled and populated with default values
> since we can't write registers when the 2 GPIOs are down.
> 
> Signed-off-by: KancyJoe <kancy2333@outlook.com>
> Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org>
> ---
>   drivers/regulator/Kconfig             |   7 +
>   drivers/regulator/Makefile            |   1 +
>   drivers/regulator/sgm3804-regulator.c | 308 ++++++++++++++++++++++++++++++++++
>   3 files changed, 316 insertions(+)
> 

<snip>

I checked the Sahiko review and the reported issues are all false issues that
won't happen in real life.

Do you see any parts I'll need to improve ?

Thanks,
Neil