From: Neil Armstrong <neil.armstrong@linaro.org>
To: Mark Brown <broonie@kernel.org>
Cc: Liam Girdwood <lgirdwood@gmail.com>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
KancyJoe <kancy2333@outlook.com>
Subject: Re: [PATCH v4 2/2] regulator: add SGM3804 Dual Output driver
Date: Thu, 21 May 2026 13:38:55 +0200 [thread overview]
Message-ID: <e73a2332-4f51-49e3-9182-cc34cfdcda6d@linaro.org> (raw)
In-Reply-To: <6689f2b6-b369-4048-be65-4cee6d653533@sirena.org.uk>
Le 21/05/2026 à 12:21, Mark Brown a écrit :
> On Thu, May 21, 2026 at 10:17:16AM +0200, Neil Armstrong wrote:
>
>> I checked the Sahiko review and the reported issues are all false issues that
>> won't happen in real life.
>
>> Do you see any parts I'll need to improve ?
>
> I haven't looked properly given that there's two drivers for the same
> chip in flight, like I said I'd like some agreement about the way
> forward between the two submissions. I did see you follow up and no
> response from the submitter of the other driver.
Sure, I forgot to review the other driver which is the original
driver I used for this enhanced implementation, done now.
Neil
next prev parent reply other threads:[~2026-05-21 11:38 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-06 7:34 [PATCH v4 0/2] regulator: add support for " Neil Armstrong
2026-05-06 7:34 ` [PATCH v4 1/2] regulator: dt-bindings: document the SGM3804 Dual Output regulator Neil Armstrong
2026-05-13 18:10 ` Rob Herring (Arm)
2026-05-06 7:34 ` [PATCH v4 2/2] regulator: add SGM3804 Dual Output driver Neil Armstrong
2026-05-21 8:17 ` Neil Armstrong
2026-05-21 10:21 ` Mark Brown
2026-05-21 11:38 ` Neil Armstrong [this message]
2026-05-22 12:01 ` Mark Brown
2026-05-22 13:03 ` Neil Armstrong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e73a2332-4f51-49e3-9182-cc34cfdcda6d@linaro.org \
--to=neil.armstrong@linaro.org \
--cc=broonie@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=kancy2333@outlook.com \
--cc=krzk+dt@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®