mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Arnd Bergmann" <arnd@arndb.de>
To: "Peter Zijlstra" <peterz@infradead.org>
Cc: "Finn Thain" <fthain@linux-m68k.org>,
	"Geert Uytterhoeven" <geert@linux-m68k.org>,
	"Will Deacon" <will@kernel.org>,
	"Andrew Morton" <akpm@linux-foundation.org>,
	"Boqun Feng" <boqun.feng@gmail.com>,
	"Jonathan Corbet" <corbet@lwn.net>,
	"Mark Rutland" <mark.rutland@arm.com>,
	linux-kernel@vger.kernel.org,
	Linux-Arch <linux-arch@vger.kernel.org>,
	linux-m68k@vger.kernel.org, "Lance Yang" <lance.yang@linux.dev>
Subject: Re: [RFC v2 2/3] atomic: Specify alignment for atomic_t and atomic64_t
Date: Mon, 06 Oct 2025 13:09:07 +0200	[thread overview]
Message-ID: <92c5af4d-c6e9-43bf-ba2c-ce6627b8d962@app.fastmail.com> (raw)
In-Reply-To: <20251006102228.GT3245006@noisy.programming.kicks-ass.net>

On Mon, Oct 6, 2025, at 12:22, Peter Zijlstra wrote:
> On Mon, Oct 06, 2025 at 12:07:24PM +0200, Arnd Bergmann wrote:
>
>> It looks like Mark Rutland fixed the try_cmpxchg() function this
>> way in commit ec570320b09f ("locking/atomic: Correct (cmp)xchg()
>> instrumentation"), but for some reason we still have the wrong
>> annotation on the atomic_try_cmpxchg() helpers.
>
>> Mark, I've tried to modify your script to produce that output,
>> the output looks correct to me, but it makes the script more
>> complex than I liked and I'm not sure that matching on
>> "${type}"="p" is the best way to check for this.
>
> I don't see anything wrong with this. The result looks good.

Thanks for having a look, I've sent it out as a proper patch now.

      Arnd

  reply	other threads:[~2025-10-06 11:09 UTC|newest]

Thread overview: 44+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-09-14  0:45 [RFC v2 0/3] Align atomic storage Finn Thain
2025-09-14  0:45 ` [RFC v2 1/3] documentation: Discourage alignment assumptions Finn Thain
2025-09-14  0:45 ` [RFC v2 3/3] atomic: Add alignment check to instrumented atomic operations Finn Thain
2025-09-15  8:00   ` Peter Zijlstra
2025-09-15  9:38     ` Finn Thain
2025-09-15 10:06       ` Peter Zijlstra
2025-09-15 10:37         ` Finn Thain
2025-09-15 11:20           ` Arnd Bergmann
2025-09-16  0:16             ` Finn Thain
2025-09-16 10:10               ` Geert Uytterhoeven
2025-09-17  1:23                 ` Finn Thain
2025-09-16 12:37               ` Arnd Bergmann
2025-09-16 21:38                 ` Brad Boyer
2025-09-17 16:54                   ` Andreas Schwab
2025-09-17  2:14                 ` Finn Thain
2025-09-22 15:49                   ` Arnd Bergmann
2025-09-23  6:39                     ` Finn Thain
2025-09-14  0:45 ` [RFC v2 2/3] atomic: Specify alignment for atomic_t and atomic64_t Finn Thain
2025-09-15  7:13   ` Geert Uytterhoeven
2025-09-15  7:35   ` Arnd Bergmann
2025-09-15  8:06     ` Peter Zijlstra
2025-09-15  9:26     ` Finn Thain
2025-09-15  9:29       ` Arnd Bergmann
2025-09-22  7:06   ` Geert Uytterhoeven
2025-09-22  8:16     ` Finn Thain
2025-09-22  9:29       ` Geert Uytterhoeven
2025-09-22 15:21       ` Arnd Bergmann
2025-09-23  6:28         ` Finn Thain
2025-09-23  6:41           ` Arnd Bergmann
2025-09-23  8:05             ` Finn Thain
2025-09-23 19:11               ` Arnd Bergmann
2025-09-30  2:18           ` Finn Thain
2025-09-30  6:35             ` Arnd Bergmann
2025-10-01  1:03               ` Finn Thain
2025-10-01  6:44                 ` Arnd Bergmann
2025-10-06  9:25                   ` Finn Thain
2025-10-06  9:25               ` Finn Thain
2025-10-06 10:07                 ` Arnd Bergmann
2025-10-06 10:22                   ` Peter Zijlstra
2025-10-06 11:09                     ` Arnd Bergmann [this message]
2025-10-06  9:37               ` Peter Zijlstra
2025-09-30  7:41             ` Geert Uytterhoeven
2025-10-01  1:46               ` Finn Thain
2025-10-01  7:08                 ` Geert Uytterhoeven

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=92c5af4d-c6e9-43bf-ba2c-ce6627b8d962@app.fastmail.com \
    --to=arnd@arndb.de \
    --cc=akpm@linux-foundation.org \
    --cc=boqun.feng@gmail.com \
    --cc=corbet@lwn.net \
    --cc=fthain@linux-m68k.org \
    --cc=geert@linux-m68k.org \
    --cc=lance.yang@linux.dev \
    --cc=linux-arch@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-m68k@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=peterz@infradead.org \
    --cc=will@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®