mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
To: Nabige Aala <nabige.aala@oss.qualcomm.com>,
	Bjorn Andersson <andersson@kernel.org>,
	Konrad Dybcio <konradybcio@kernel.org>,
	Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>
Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org, arpit.saini@oss.qualcomm.com,
	mohit.dsor@oss.qualcomm.com
Subject: Re: [PATCH 5/5] arm64: dts: qcom: Shikra LT9611UXD support
Date: Mon, 29 Jun 2026 11:01:25 +0200	[thread overview]
Message-ID: <94cee60d-c942-437d-9136-af0e83728966@oss.qualcomm.com> (raw)
In-Reply-To: <20260627-shikra-dt-changes-v1-5-449a402673d0@oss.qualcomm.com>

On 6/27/26 12:01 PM, Nabige Aala wrote:
> From: Mohit Dsor <mohit.dsor@oss.qualcomm.com>
> 
> Device tree changes to support lt9611uxd hdmi-dsi driver.
> 
> Signed-off-by: Mohit Dsor <mohit.dsor@oss.qualcomm.com>
> ---

[...]

> +		pinctrl-names = "default";
> +		pinctrl-0 = <&lt9611_irq_pin &lt9611_rst_pin>;

property-n
property-names

in this order, file-wide, please

[...]

> +&mdss_dsi0 {
> +	vdda-supply = <&pm8150_l11>;
> +	status = "okay";

Let's keep a \n before 'status' uniformly as well

> +
> +};

Stray \n above.

[...]

> +&tlmm {
> +	lt9611_irq_pin: lt9611-irq-state {
> +		pins = "gpio85";
> +		function = "gpio";
> +		drive-strength = <2>;
> +		bias-pull-up;
> +	};
> +
> +	lt9611_rst_pin: lt9611-rst-state {
> +		pins = "gpio76";
> +		function = "gpio";
> +		drive-strength = <8>;
> +		output-high;

The driver already takes care of de/asserting this pin

Konrad

  parent reply	other threads:[~2026-06-29  9:01 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-06-27 10:01 [PATCH 0/5] arm64: qcom: dts: Add display support for Shikra Nabige Aala
2026-06-27 10:01 ` [PATCH 1/5] arm64: dts: qcom: shikra: Add MDSS display subsystem Nabige Aala
2026-06-28 12:35   ` Dmitry Baryshkov
2026-06-29  7:25     ` Nabige Aala
2026-06-29  7:45       ` Dmitry Baryshkov
2026-06-27 10:01 ` [PATCH 2/5] arm64: dts: qcom: shikra-cqm-evk: Enable display and add ili7807s panel Nabige Aala
2026-06-28 12:30   ` Dmitry Baryshkov
2026-06-29 10:54     ` Arpit Saini
2026-07-01  9:25       ` Arpit Saini
2026-06-28 12:30   ` Dmitry Baryshkov
     [not found]     ` <e8563334-e53e-4010-b7f5-9d61ef55bea3@oss.qualcomm.com>
2026-06-29  8:15       ` Dmitry Baryshkov
2026-06-29  9:57         ` Nabige Aala
2026-06-27 10:01 ` [PATCH 3/5] arm64: defconfig: Enable ILI7807S DSI panel driver Nabige Aala
2026-06-28  8:44   ` Krzysztof Kozlowski
2026-07-03  9:10     ` Nabige Aala
2026-07-03  9:17       ` Krzysztof Kozlowski
2026-07-03  9:58       ` Konrad Dybcio
2026-06-27 10:01 ` [PATCH 4/5] arm64: dts: qcom: shikra-cqs-evk: Enable display and add ili7807s panel Nabige Aala
2026-06-28 12:36   ` Dmitry Baryshkov
2026-06-29 11:39     ` Arpit Saini
2026-06-27 10:01 ` [PATCH 5/5] arm64: dts: qcom: Shikra LT9611UXD support Nabige Aala
2026-06-28  8:45   ` Krzysztof Kozlowski
2026-06-28 12:38   ` Dmitry Baryshkov
2026-06-29  9:01   ` Konrad Dybcio [this message]
2026-06-28 12:24 ` [PATCH 0/5] arm64: qcom: dts: Add display support for Shikra Dmitry Baryshkov
2026-06-29 10:09   ` Nabige Aala

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=94cee60d-c942-437d-9136-af0e83728966@oss.qualcomm.com \
    --to=konrad.dybcio@oss.qualcomm.com \
    --cc=andersson@kernel.org \
    --cc=arpit.saini@oss.qualcomm.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=konradybcio@kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mohit.dsor@oss.qualcomm.com \
    --cc=nabige.aala@oss.qualcomm.com \
    --cc=robh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®