Re: [PATCH 4/5] arm64: dts: qcom: shikra-cqs-evk: Enable display and add ili7807s panel

[Arpit Saini <arpit.saini@oss.qualcomm.com>]

Hi Dmitry,

On 6/28/2026 6:06 PM, Dmitry Baryshkov wrote:
> On Sat, Jun 27, 2026 at 03:31:38PM +0530, Nabige Aala wrote:
>> From: Arpit Saini <arpit.saini@oss.qualcomm.com>
>>
>> Enable the Shikra MDSS display subsystem on the Shikra CQS EVK
>> board and add the DLC0697 MIPI DSI display panel node.
>>
>> Signed-off-by: Arpit Saini <arpit.saini@oss.qualcomm.com>
> Missing SoB.

Ack.


>> ---
>>   arch/arm64/boot/dts/qcom/shikra-cqs-evk.dts | 104 ++++++++++++++++++++++++++++
>>   1 file changed, 104 insertions(+)
>>
>> +&mdss_dsi0 {
>> +	vdda-supply = <&pm4125_l5>;
>> +	status = "okay";
>> +
>> +	panel@0 {
>> +		compatible = "dlc,dlc0697", "ilitek,ili7807s";
>> +		reg = <0>;
>> +
>> +		reset-gpios = <&tlmm 3 GPIO_ACTIVE_LOW>;
>> +
>> +		vddi-supply = <&pm4125_l15>;
>> +		avdd-supply = <&lcd_bias>;
>> +		avee-supply = <&lcd_bias>;
> The same question regardin AVEE supply.
Ack, will update as two separate regulators.
>> +
>> +		pinctrl-0 = <&panel_bl_en &panel_rst_n &panel_te_pin>;
>> +		pinctrl-1 = <&panel_bl_en_suspend &panel_rst_n_suspend>;
>> +		pinctrl-names = "default", "sleep";
>> +
>> +		port {
>> +			panel_in: endpoint {
>> +				remote-endpoint = <&mdss_dsi0_out>;
>> +			};
>> +		};
>> +	};
>> +};
>> +
>> @@ -116,3 +174,49 @@ &wifi {
>>   
>>   	status = "okay";
>>   };
>> +
>> +&tlmm {
>> +	lcd_bias_en: lcd-bias-en-state {
>> +		pins = "gpio151";
>> +		function = "gpio";
>> +		drive-strength = <2>;
>> +		bias-disable;
>> +	};
> Order by the pin number.

Ack.

Thanks

Arpit


>
>> +
>> +	panel_bl_en: panel-bl-en-state {
>> +		pins = "gpio91";
>> +		function = "gpio";
>> +		drive-strength = <2>;
>> +		bias-disable;
>> +		output-high;
>> +	};
>> +