From: Vishnu Reddy <busanna.reddy@oss.qualcomm.com>
To: Hungyu Lin <dennylin0707@gmail.com>,
vikash.garodia@oss.qualcomm.com, bod@kernel.org,
mchehab@kernel.org
Cc: linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] media: qcom: venus: add callback parameter names
Date: Mon, 8 Jun 2026 11:52:05 +0530 [thread overview]
Message-ID: <94d5ffeb-05fc-5bc5-89e9-9381f85c314d@oss.qualcomm.com> (raw)
In-Reply-To: <20260604001859.33353-1-dennylin0707@gmail.com>
On 6/4/2026 5:48 AM, Hungyu Lin wrote:
> Naming the callback parameters improves readability and resolves
> checkpatch warnings about unnamed function pointer arguments.
>
> No functional change intended.
>
> Signed-off-by: Hungyu Lin <dennylin0707@gmail.com>
> ---
> drivers/media/platform/qcom/venus/hfi_msgs.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/media/platform/qcom/venus/hfi_msgs.c b/drivers/media/platform/qcom/venus/hfi_msgs.c
> index 47b99d5b5af7..5c2025c5acc7 100644
> --- a/drivers/media/platform/qcom/venus/hfi_msgs.c
> +++ b/drivers/media/platform/qcom/venus/hfi_msgs.c
> @@ -690,7 +690,7 @@ struct hfi_done_handler {
> u32 pkt;
> u32 pkt_sz;
> u32 pkt_sz2;
> - void (*done)(struct venus_core *, struct venus_inst *, void *);
> + void (*done)(struct venus_core *core, struct venus_inst *inst, void *packet);
> bool is_sys_pkt;
> };
>
Reviewed-by: Vishnu Reddy <busanna.reddy@oss.qualcomm.com>
prev parent reply other threads:[~2026-06-08 6:22 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-04 0:18 Hungyu Lin
2026-06-07 21:33 ` Dmitry Baryshkov
2026-06-08 6:22 ` Vishnu Reddy [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=94d5ffeb-05fc-5bc5-89e9-9381f85c314d@oss.qualcomm.com \
--to=busanna.reddy@oss.qualcomm.com \
--cc=bod@kernel.org \
--cc=dennylin0707@gmail.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=vikash.garodia@oss.qualcomm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®