* [PATCH] drm/msm/dpu: Fix variable dereferenced before check
@ 2022-06-21 11:06 sunliming
2022-06-21 17:42 ` Abhinav Kumar
0 siblings, 1 reply; 5+ messages in thread
From: sunliming @ 2022-06-21 11:06 UTC (permalink / raw)
To: quic_abhinavk, robdclark, dmitry.baryshkov
Cc: linux-kernel, sunliming, kelulanainsley, kernel test robot
Fixes the following smatch warning:
drivers/gpu/drm/msm/disp/dpu1/dpu_encoder_phys_wb.c:261
dpu_encoder_phys_wb_atomic_check() warn: variable dereferenced before check 'conn_state'
Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: sunliming <sunliming@kylinos.cn>
---
drivers/gpu/drm/msm/disp/dpu1/dpu_encoder_phys_wb.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder_phys_wb.c b/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder_phys_wb.c
index 59da348ff339..0ec809ab06e7 100644
--- a/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder_phys_wb.c
+++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder_phys_wb.c
@@ -252,11 +252,6 @@ static int dpu_encoder_phys_wb_atomic_check(
DPU_DEBUG("[atomic_check:%d, \"%s\",%d,%d]\n",
phys_enc->wb_idx, mode->name, mode->hdisplay, mode->vdisplay);
- if (!conn_state->writeback_job || !conn_state->writeback_job->fb)
- return 0;
-
- fb = conn_state->writeback_job->fb;
-
if (!conn_state || !conn_state->connector) {
DPU_ERROR("invalid connector state\n");
return -EINVAL;
@@ -267,6 +262,11 @@ static int dpu_encoder_phys_wb_atomic_check(
return -EINVAL;
}
+ if (!conn_state->writeback_job || !conn_state->writeback_job->fb)
+ return 0;
+
+ fb = conn_state->writeback_job->fb;
+
DPU_DEBUG("[fb_id:%u][fb:%u,%u]\n", fb->base.id,
fb->width, fb->height);
--
2.25.1
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] drm/msm/dpu: Fix variable dereferenced before check
2022-06-21 11:06 [PATCH] drm/msm/dpu: Fix variable dereferenced before check sunliming
@ 2022-06-21 17:42 ` Abhinav Kumar
2022-06-21 17:44 ` Abhinav Kumar
0 siblings, 1 reply; 5+ messages in thread
From: Abhinav Kumar @ 2022-06-21 17:42 UTC (permalink / raw)
To: sunliming, robdclark, dmitry.baryshkov
Cc: linux-kernel, kelulanainsley, kernel test robot, Dan Carpenter
On 6/21/2022 4:06 AM, sunliming wrote:
> Fixes the following smatch warning:
>
> drivers/gpu/drm/msm/disp/dpu1/dpu_encoder_phys_wb.c:261
> dpu_encoder_phys_wb_atomic_check() warn: variable dereferenced before check 'conn_state'
>
> Reported-by: kernel test robot <lkp@intel.com>
> Signed-off-by: sunliming <sunliming@kylinos.cn>
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Reviewed-by: Abhinav Kumar <quic_abhinavk@quicinc.com>
> ---
> drivers/gpu/drm/msm/disp/dpu1/dpu_encoder_phys_wb.c | 10 +++++-----
> 1 file changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder_phys_wb.c b/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder_phys_wb.c
> index 59da348ff339..0ec809ab06e7 100644
> --- a/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder_phys_wb.c
> +++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder_phys_wb.c
> @@ -252,11 +252,6 @@ static int dpu_encoder_phys_wb_atomic_check(
> DPU_DEBUG("[atomic_check:%d, \"%s\",%d,%d]\n",
> phys_enc->wb_idx, mode->name, mode->hdisplay, mode->vdisplay);
>
> - if (!conn_state->writeback_job || !conn_state->writeback_job->fb)
> - return 0;
> -
> - fb = conn_state->writeback_job->fb;
> -
> if (!conn_state || !conn_state->connector) {
> DPU_ERROR("invalid connector state\n");
> return -EINVAL;
> @@ -267,6 +262,11 @@ static int dpu_encoder_phys_wb_atomic_check(
> return -EINVAL;
> }
>
> + if (!conn_state->writeback_job || !conn_state->writeback_job->fb)
> + return 0;
> +
> + fb = conn_state->writeback_job->fb;
> +
> DPU_DEBUG("[fb_id:%u][fb:%u,%u]\n", fb->base.id,
> fb->width, fb->height);
>
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] drm/msm/dpu: Fix variable dereferenced before check
2022-06-21 17:42 ` Abhinav Kumar
@ 2022-06-21 17:44 ` Abhinav Kumar
2022-06-21 17:49 ` Dmitry Baryshkov
0 siblings, 1 reply; 5+ messages in thread
From: Abhinav Kumar @ 2022-06-21 17:44 UTC (permalink / raw)
To: sunliming, robdclark, dmitry.baryshkov
Cc: linux-kernel, kelulanainsley, kernel test robot, Dan Carpenter,
freedreno
Copying freedreno
On 6/21/2022 10:42 AM, Abhinav Kumar wrote:
>
>
> On 6/21/2022 4:06 AM, sunliming wrote:
>> Fixes the following smatch warning:
>>
>> drivers/gpu/drm/msm/disp/dpu1/dpu_encoder_phys_wb.c:261
>> dpu_encoder_phys_wb_atomic_check() warn: variable dereferenced before
>> check 'conn_state'
>>
>> Reported-by: kernel test robot <lkp@intel.com>
>> Signed-off-by: sunliming <sunliming@kylinos.cn>
> Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
> Reviewed-by: Abhinav Kumar <quic_abhinavk@quicinc.com>
>
>> ---
>> drivers/gpu/drm/msm/disp/dpu1/dpu_encoder_phys_wb.c | 10 +++++-----
>> 1 file changed, 5 insertions(+), 5 deletions(-)
>>
>> diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder_phys_wb.c
>> b/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder_phys_wb.c
>> index 59da348ff339..0ec809ab06e7 100644
>> --- a/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder_phys_wb.c
>> +++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder_phys_wb.c
>> @@ -252,11 +252,6 @@ static int dpu_encoder_phys_wb_atomic_check(
>> DPU_DEBUG("[atomic_check:%d, \"%s\",%d,%d]\n",
>> phys_enc->wb_idx, mode->name, mode->hdisplay,
>> mode->vdisplay);
>> - if (!conn_state->writeback_job || !conn_state->writeback_job->fb)
>> - return 0;
>> -
>> - fb = conn_state->writeback_job->fb;
>> -
>> if (!conn_state || !conn_state->connector) {
>> DPU_ERROR("invalid connector state\n");
>> return -EINVAL;
>> @@ -267,6 +262,11 @@ static int dpu_encoder_phys_wb_atomic_check(
>> return -EINVAL;
>> }
>> + if (!conn_state->writeback_job || !conn_state->writeback_job->fb)
>> + return 0;
>> +
>> + fb = conn_state->writeback_job->fb;
>> +
>> DPU_DEBUG("[fb_id:%u][fb:%u,%u]\n", fb->base.id,
>> fb->width, fb->height);
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] drm/msm/dpu: Fix variable dereferenced before check
2022-06-21 17:44 ` Abhinav Kumar
@ 2022-06-21 17:49 ` Dmitry Baryshkov
2022-06-22 17:28 ` Abhinav Kumar
0 siblings, 1 reply; 5+ messages in thread
From: Dmitry Baryshkov @ 2022-06-21 17:49 UTC (permalink / raw)
To: Abhinav Kumar
Cc: sunliming, robdclark, linux-kernel, kelulanainsley,
kernel test robot, Dan Carpenter, freedreno
On Tue, 21 Jun 2022 at 20:44, Abhinav Kumar <quic_abhinavk@quicinc.com> wrote:
>
> Copying freedreno
The patch needs to be sent to freedreno@. Otherwise it doesn't exist
in patchwork.
>
> On 6/21/2022 10:42 AM, Abhinav Kumar wrote:
> >
> >
> > On 6/21/2022 4:06 AM, sunliming wrote:
> >> Fixes the following smatch warning:
> >>
> >> drivers/gpu/drm/msm/disp/dpu1/dpu_encoder_phys_wb.c:261
> >> dpu_encoder_phys_wb_atomic_check() warn: variable dereferenced before
> >> check 'conn_state'
> >>
> >> Reported-by: kernel test robot <lkp@intel.com>
> >> Signed-off-by: sunliming <sunliming@kylinos.cn>
> > Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
> > Reviewed-by: Abhinav Kumar <quic_abhinavk@quicinc.com>
> >
> >> ---
> >> drivers/gpu/drm/msm/disp/dpu1/dpu_encoder_phys_wb.c | 10 +++++-----
> >> 1 file changed, 5 insertions(+), 5 deletions(-)
> >>
> >> diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder_phys_wb.c
> >> b/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder_phys_wb.c
> >> index 59da348ff339..0ec809ab06e7 100644
> >> --- a/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder_phys_wb.c
> >> +++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder_phys_wb.c
> >> @@ -252,11 +252,6 @@ static int dpu_encoder_phys_wb_atomic_check(
> >> DPU_DEBUG("[atomic_check:%d, \"%s\",%d,%d]\n",
> >> phys_enc->wb_idx, mode->name, mode->hdisplay,
> >> mode->vdisplay);
> >> - if (!conn_state->writeback_job || !conn_state->writeback_job->fb)
> >> - return 0;
> >> -
> >> - fb = conn_state->writeback_job->fb;
> >> -
> >> if (!conn_state || !conn_state->connector) {
> >> DPU_ERROR("invalid connector state\n");
> >> return -EINVAL;
> >> @@ -267,6 +262,11 @@ static int dpu_encoder_phys_wb_atomic_check(
> >> return -EINVAL;
> >> }
> >> + if (!conn_state->writeback_job || !conn_state->writeback_job->fb)
> >> + return 0;
> >> +
> >> + fb = conn_state->writeback_job->fb;
> >> +
> >> DPU_DEBUG("[fb_id:%u][fb:%u,%u]\n", fb->base.id,
> >> fb->width, fb->height);
--
With best wishes
Dmitry
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] drm/msm/dpu: Fix variable dereferenced before check
2022-06-21 17:49 ` Dmitry Baryshkov
@ 2022-06-22 17:28 ` Abhinav Kumar
0 siblings, 0 replies; 5+ messages in thread
From: Abhinav Kumar @ 2022-06-22 17:28 UTC (permalink / raw)
To: Dmitry Baryshkov
Cc: sunliming, robdclark, linux-kernel, kelulanainsley,
kernel test robot, Dan Carpenter, freedreno
On 6/21/2022 10:49 AM, Dmitry Baryshkov wrote:
> On Tue, 21 Jun 2022 at 20:44, Abhinav Kumar <quic_abhinavk@quicinc.com> wrote:
>>
>> Copying freedreno
>
> The patch needs to be sent to freedreno@. Otherwise it doesn't exist
> in patchwork.
Ack
Hi Sunliming
Can you please re-send this and copy freedreno email list along with the
Reviewed-by and Reported-by tags which I have given below?
Thanks
Abhinav
>
>>
>> On 6/21/2022 10:42 AM, Abhinav Kumar wrote:
>>>
>>>
>>> On 6/21/2022 4:06 AM, sunliming wrote:
>>>> Fixes the following smatch warning:
>>>>
>>>> drivers/gpu/drm/msm/disp/dpu1/dpu_encoder_phys_wb.c:261
>>>> dpu_encoder_phys_wb_atomic_check() warn: variable dereferenced before
>>>> check 'conn_state'
>>>>
>>>> Reported-by: kernel test robot <lkp@intel.com>
>>>> Signed-off-by: sunliming <sunliming@kylinos.cn>
>>> Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
>>> Reviewed-by: Abhinav Kumar <quic_abhinavk@quicinc.com>
>>>
>>>> ---
>>>> drivers/gpu/drm/msm/disp/dpu1/dpu_encoder_phys_wb.c | 10 +++++-----
>>>> 1 file changed, 5 insertions(+), 5 deletions(-)
>>>>
>>>> diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder_phys_wb.c
>>>> b/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder_phys_wb.c
>>>> index 59da348ff339..0ec809ab06e7 100644
>>>> --- a/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder_phys_wb.c
>>>> +++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder_phys_wb.c
>>>> @@ -252,11 +252,6 @@ static int dpu_encoder_phys_wb_atomic_check(
>>>> DPU_DEBUG("[atomic_check:%d, \"%s\",%d,%d]\n",
>>>> phys_enc->wb_idx, mode->name, mode->hdisplay,
>>>> mode->vdisplay);
>>>> - if (!conn_state->writeback_job || !conn_state->writeback_job->fb)
>>>> - return 0;
>>>> -
>>>> - fb = conn_state->writeback_job->fb;
>>>> -
>>>> if (!conn_state || !conn_state->connector) {
>>>> DPU_ERROR("invalid connector state\n");
>>>> return -EINVAL;
>>>> @@ -267,6 +262,11 @@ static int dpu_encoder_phys_wb_atomic_check(
>>>> return -EINVAL;
>>>> }
>>>> + if (!conn_state->writeback_job || !conn_state->writeback_job->fb)
>>>> + return 0;
>>>> +
>>>> + fb = conn_state->writeback_job->fb;
>>>> +
>>>> DPU_DEBUG("[fb_id:%u][fb:%u,%u]\n", fb->base.id,
>>>> fb->width, fb->height);
>
>
>
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2022-06-22 17:29 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-06-21 11:06 [PATCH] drm/msm/dpu: Fix variable dereferenced before check sunliming
2022-06-21 17:42 ` Abhinav Kumar
2022-06-21 17:44 ` Abhinav Kumar
2022-06-21 17:49 ` Dmitry Baryshkov
2022-06-22 17:28 ` Abhinav Kumar
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®