mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Jessica Zhang <quic_jesszhan@quicinc.com>
To: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>,
	Jun Nie <jun.nie@linaro.org>
Cc: Rob Clark <robdclark@gmail.com>,
	Abhinav Kumar <quic_abhinavk@quicinc.com>,
	Sean Paul <sean@poorly.run>,
	Marijn Suijten <marijn.suijten@somainline.org>,
	David Airlie <airlied@gmail.com>,
	"Simona Vetter" <simona@ffwll.ch>,
	<linux-arm-msm@vger.kernel.org>,
	<dri-devel@lists.freedesktop.org>,
	<freedreno@lists.freedesktop.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v3 04/15] drm/msm/dpu: decide right side per last bit
Date: Wed, 8 Jan 2025 15:41:07 -0800	[thread overview]
Message-ID: <95b83e6f-e455-4df0-b121-a1d900de0a56@quicinc.com> (raw)
In-Reply-To: <yqbze4h6obiwulmvh64r62slaiih75hzescf5tjwqgtmhqy3wi@y4uedbo5jrzu>



On 12/19/2024 2:09 PM, Dmitry Baryshkov wrote:
> On Thu, Dec 19, 2024 at 03:49:22PM +0800, Jun Nie wrote:
>> decide right side of a pair per last bit, in case of multiple
>> mixer pairs.
> 
> Proper English sentences, please. Also describe why, not what.

Hi Jun,

Can we also add a note in the commit message on why the last bit check 
works?

Thanks,

Jessica Zhang

> 
>>
>> Signed-off-by: Jun Nie <jun.nie@linaro.org>
>> Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
>> ---
>>   drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c | 5 ++---
>>   1 file changed, 2 insertions(+), 3 deletions(-)
>>
>> diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c b/drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c
>> index 7191b1a6d41b3..41c9d3e3e3c7c 100644
>> --- a/drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c
>> +++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c
>> @@ -369,11 +369,10 @@ static void _dpu_crtc_setup_blend_cfg(struct dpu_crtc_mixer *mixer,
>>   static void _dpu_crtc_program_lm_output_roi(struct drm_crtc *crtc)
>>   {
>>   	struct dpu_crtc_state *crtc_state;
>> -	int lm_idx, lm_horiz_position;
>> +	int lm_idx;
>>   
>>   	crtc_state = to_dpu_crtc_state(crtc->state);
>>   
>> -	lm_horiz_position = 0;
>>   	for (lm_idx = 0; lm_idx < crtc_state->num_mixers; lm_idx++) {
>>   		const struct drm_rect *lm_roi = &crtc_state->lm_bounds[lm_idx];
>>   		struct dpu_hw_mixer *hw_lm = crtc_state->mixers[lm_idx].hw_lm;
>> @@ -384,7 +383,7 @@ static void _dpu_crtc_program_lm_output_roi(struct drm_crtc *crtc)
>>   
>>   		cfg.out_width = drm_rect_width(lm_roi);
>>   		cfg.out_height = drm_rect_height(lm_roi);
>> -		cfg.right_mixer = lm_horiz_position++;
>> +		cfg.right_mixer = lm_idx & 0x1;
>>   		cfg.flags = 0;
>>   		hw_lm->ops.setup_mixer_out(hw_lm, &cfg);
>>   	}
>>
>> -- 
>> 2.34.1
>>
> 
> -- 
> With best wishes
> Dmitry


  reply	other threads:[~2025-01-08 23:41 UTC|newest]

Thread overview: 43+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-12-19  7:49 [PATCH v3 00/15] (no cover subject) Jun Nie
2024-12-19  7:49 ` [PATCH v3 01/15] drm/msm/dpu: Do not fix number of DSC Jun Nie
2024-12-19 22:08   ` Dmitry Baryshkov
2024-12-19  7:49 ` [PATCH v3 02/15] drm/msm/dpu: configure DSC per number in use Jun Nie
2024-12-19 22:06   ` Dmitry Baryshkov
2024-12-19  7:49 ` [PATCH v3 03/15] drm/msm/dpu: polish log for resource allocation Jun Nie
2024-12-19 22:07   ` Dmitry Baryshkov
2024-12-19  7:49 ` [PATCH v3 04/15] drm/msm/dpu: decide right side per last bit Jun Nie
2024-12-19 22:09   ` Dmitry Baryshkov
2025-01-08 23:41     ` Jessica Zhang [this message]
2025-01-09  4:35       ` Jun Nie
2025-01-09 12:14         ` Dmitry Baryshkov
2024-12-19  7:49 ` [PATCH v3 05/15] drm/msm/dpu: fix mixer number counter on allocation Jun Nie
2024-12-19 22:14   ` Dmitry Baryshkov
2025-01-09  1:29   ` Jessica Zhang
2025-01-09  4:40     ` Jun Nie
2025-01-09 12:15       ` Dmitry Baryshkov
2024-12-19  7:49 ` [PATCH v3 06/15] drm/msm/dpu: switch RM to use crtc_id rather than enc_id for allocation Jun Nie
2024-12-19  7:49 ` [PATCH v3 07/15] drm/msm/dpu: bind correct pingpong for quad pipe Jun Nie
2025-01-09 18:12   ` Jessica Zhang
2024-12-19  7:49 ` [PATCH v3 08/15] drm/msm/dpu: handle pipes as array Jun Nie
2024-12-19 22:26   ` Dmitry Baryshkov
2024-12-19  7:49 ` [PATCH v3 09/15] drm/msm/dpu: split PIPES_PER_STAGE definition per plane and mixer Jun Nie
2024-12-19 22:28   ` Dmitry Baryshkov
2024-12-19  7:49 ` [PATCH v3 10/15] drm/msm/dpu: Add pipe as trace argument Jun Nie
2024-12-19 22:29   ` Dmitry Baryshkov
2024-12-31 13:24     ` Jun Nie
2024-12-31 14:04       ` Dmitry Baryshkov
2024-12-19  7:49 ` [PATCH v3 11/15] drm/msm/dpu: blend pipes per mixer pairs config Jun Nie
2024-12-19 22:40   ` Dmitry Baryshkov
2024-12-19  7:49 ` [PATCH v3 12/15] drm/msm/dpu: support plane splitting in quad-pipe case Jun Nie
2024-12-19 23:16   ` Dmitry Baryshkov
2024-12-19  7:49 ` [PATCH v3 13/15] drm/msm/dpu: Support quad-pipe in SSPP checking Jun Nie
2024-12-19 23:23   ` Dmitry Baryshkov
2024-12-19  7:49 ` [PATCH v3 14/15] drm/msm/dpu: support SSPP assignment for quad-pipe case Jun Nie
2024-12-19 23:30   ` Dmitry Baryshkov
2024-12-19  7:49 ` [PATCH v3 15/15] drm/msm/dpu: Enable quad-pipe for DSC and dual-DSI case Jun Nie
2024-12-19 23:46   ` Dmitry Baryshkov
2025-01-03 15:49     ` Jun Nie
2025-01-03 17:51       ` Dmitry Baryshkov
2025-01-06  8:21         ` Jun Nie
2025-01-07 22:25           ` Dmitry Baryshkov
2024-12-19  7:53 ` [PATCH v3 00/15] drm/msm/dpu: Support quad pipe with dual-DSI Jun Nie

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=95b83e6f-e455-4df0-b121-a1d900de0a56@quicinc.com \
    --to=quic_jesszhan@quicinc.com \
    --cc=airlied@gmail.com \
    --cc=dmitry.baryshkov@linaro.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=freedreno@lists.freedesktop.org \
    --cc=jun.nie@linaro.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=marijn.suijten@somainline.org \
    --cc=quic_abhinavk@quicinc.com \
    --cc=robdclark@gmail.com \
    --cc=sean@poorly.run \
    --cc=simona@ffwll.ch \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®