From: Jessica Zhang <quic_jesszhan@quicinc.com>
To: Jun Nie <jun.nie@linaro.org>, Rob Clark <robdclark@gmail.com>,
"Abhinav Kumar" <quic_abhinavk@quicinc.com>,
Dmitry Baryshkov <dmitry.baryshkov@linaro.org>,
Sean Paul <sean@poorly.run>,
Marijn Suijten <marijn.suijten@somainline.org>,
David Airlie <airlied@gmail.com>,
"Simona Vetter" <simona@ffwll.ch>
Cc: <linux-arm-msm@vger.kernel.org>,
<dri-devel@lists.freedesktop.org>,
<freedreno@lists.freedesktop.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v3 05/15] drm/msm/dpu: fix mixer number counter on allocation
Date: Wed, 8 Jan 2025 17:29:24 -0800 [thread overview]
Message-ID: <da270bd6-3f7a-4100-8352-acbf14b62db5@quicinc.com> (raw)
In-Reply-To: <20241219-sm8650-v6-13-hmd-deckard-mdss-quad-upstream-32-v3-5-92c7c0a228e3@linaro.org>
On 12/18/2024 11:49 PM, Jun Nie wrote:
> Add the case to reserve multiple pairs mixers for high resolution.
> Current code only supports one pair of mixer usage case. To support
> quad-pipe usage case, two pairs of mixers are needed.
>
> Current code resets number of mixer on failure of pair's peer test and
> retry on another pair. If two pairs are needed, the failure on the test
> of 2nd pair results clearing to the 1st pair. This patch only clear the
> bit for the 2nd pair allocation before retry on another pair.
Hi Jun,
I think the commit message wording is a bit unclear. Maybe something
like "Reset the current lm_count to an even number instead of completely
clearing it. This prevents all pairs from being cleared in cases where
multiple LM pairs are needed"
>
> Signed-off-by: Jun Nie <jun.nie@linaro.org>
> ---
> drivers/gpu/drm/msm/disp/dpu1/dpu_rm.c | 6 +++++-
> 1 file changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_rm.c b/drivers/gpu/drm/msm/disp/dpu1/dpu_rm.c
> index cde3c5616f9bc..a8b01b78c02c7 100644
> --- a/drivers/gpu/drm/msm/disp/dpu1/dpu_rm.c
> +++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_rm.c
> @@ -316,7 +316,11 @@ static int _dpu_rm_reserve_lms(struct dpu_rm *rm,
> if (!rm->mixer_blks[i])
> continue;
>
> - lm_count = 0;
> + /*
> + * Clear the last bit to drop the previous primary mixer if
> + * fail to find its peer.
Same here can we reword it to something like "Reset lm_count to an even
index. This will drop the previous primary mixer if ..."
> + */
> + lm_count &= 0xfe;
Nit: Can we directly clear the first bit instead of doing an 8-bit bitmask?
Thanks,
Jessica Zhang
> lm_idx[lm_count] = i;
>
> if (!_dpu_rm_check_lm_and_get_connected_blks(rm, global_state,
>
> --
> 2.34.1
>
next prev parent reply other threads:[~2025-01-09 1:29 UTC|newest]
Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-19 7:49 [PATCH v3 00/15] (no cover subject) Jun Nie
2024-12-19 7:49 ` [PATCH v3 01/15] drm/msm/dpu: Do not fix number of DSC Jun Nie
2024-12-19 22:08 ` Dmitry Baryshkov
2024-12-19 7:49 ` [PATCH v3 02/15] drm/msm/dpu: configure DSC per number in use Jun Nie
2024-12-19 22:06 ` Dmitry Baryshkov
2024-12-19 7:49 ` [PATCH v3 03/15] drm/msm/dpu: polish log for resource allocation Jun Nie
2024-12-19 22:07 ` Dmitry Baryshkov
2024-12-19 7:49 ` [PATCH v3 04/15] drm/msm/dpu: decide right side per last bit Jun Nie
2024-12-19 22:09 ` Dmitry Baryshkov
2025-01-08 23:41 ` Jessica Zhang
2025-01-09 4:35 ` Jun Nie
2025-01-09 12:14 ` Dmitry Baryshkov
2024-12-19 7:49 ` [PATCH v3 05/15] drm/msm/dpu: fix mixer number counter on allocation Jun Nie
2024-12-19 22:14 ` Dmitry Baryshkov
2025-01-09 1:29 ` Jessica Zhang [this message]
2025-01-09 4:40 ` Jun Nie
2025-01-09 12:15 ` Dmitry Baryshkov
2024-12-19 7:49 ` [PATCH v3 06/15] drm/msm/dpu: switch RM to use crtc_id rather than enc_id for allocation Jun Nie
2024-12-19 7:49 ` [PATCH v3 07/15] drm/msm/dpu: bind correct pingpong for quad pipe Jun Nie
2025-01-09 18:12 ` Jessica Zhang
2024-12-19 7:49 ` [PATCH v3 08/15] drm/msm/dpu: handle pipes as array Jun Nie
2024-12-19 22:26 ` Dmitry Baryshkov
2024-12-19 7:49 ` [PATCH v3 09/15] drm/msm/dpu: split PIPES_PER_STAGE definition per plane and mixer Jun Nie
2024-12-19 22:28 ` Dmitry Baryshkov
2024-12-19 7:49 ` [PATCH v3 10/15] drm/msm/dpu: Add pipe as trace argument Jun Nie
2024-12-19 22:29 ` Dmitry Baryshkov
2024-12-31 13:24 ` Jun Nie
2024-12-31 14:04 ` Dmitry Baryshkov
2024-12-19 7:49 ` [PATCH v3 11/15] drm/msm/dpu: blend pipes per mixer pairs config Jun Nie
2024-12-19 22:40 ` Dmitry Baryshkov
2024-12-19 7:49 ` [PATCH v3 12/15] drm/msm/dpu: support plane splitting in quad-pipe case Jun Nie
2024-12-19 23:16 ` Dmitry Baryshkov
2024-12-19 7:49 ` [PATCH v3 13/15] drm/msm/dpu: Support quad-pipe in SSPP checking Jun Nie
2024-12-19 23:23 ` Dmitry Baryshkov
2024-12-19 7:49 ` [PATCH v3 14/15] drm/msm/dpu: support SSPP assignment for quad-pipe case Jun Nie
2024-12-19 23:30 ` Dmitry Baryshkov
2024-12-19 7:49 ` [PATCH v3 15/15] drm/msm/dpu: Enable quad-pipe for DSC and dual-DSI case Jun Nie
2024-12-19 23:46 ` Dmitry Baryshkov
2025-01-03 15:49 ` Jun Nie
2025-01-03 17:51 ` Dmitry Baryshkov
2025-01-06 8:21 ` Jun Nie
2025-01-07 22:25 ` Dmitry Baryshkov
2024-12-19 7:53 ` [PATCH v3 00/15] drm/msm/dpu: Support quad pipe with dual-DSI Jun Nie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=da270bd6-3f7a-4100-8352-acbf14b62db5@quicinc.com \
--to=quic_jesszhan@quicinc.com \
--cc=airlied@gmail.com \
--cc=dmitry.baryshkov@linaro.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=freedreno@lists.freedesktop.org \
--cc=jun.nie@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marijn.suijten@somainline.org \
--cc=quic_abhinavk@quicinc.com \
--cc=robdclark@gmail.com \
--cc=sean@poorly.run \
--cc=simona@ffwll.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®