From: Jessica Zhang <quic_jesszhan@quicinc.com>
To: Jun Nie <jun.nie@linaro.org>, Rob Clark <robdclark@gmail.com>,
"Abhinav Kumar" <quic_abhinavk@quicinc.com>,
Dmitry Baryshkov <dmitry.baryshkov@linaro.org>,
Sean Paul <sean@poorly.run>,
Marijn Suijten <marijn.suijten@somainline.org>,
David Airlie <airlied@gmail.com>,
"Simona Vetter" <simona@ffwll.ch>
Cc: <linux-arm-msm@vger.kernel.org>,
<dri-devel@lists.freedesktop.org>,
<freedreno@lists.freedesktop.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v3 07/15] drm/msm/dpu: bind correct pingpong for quad pipe
Date: Thu, 9 Jan 2025 10:12:16 -0800 [thread overview]
Message-ID: <98cd0bc9-27f4-4903-996a-86702a2eb96c@quicinc.com> (raw)
In-Reply-To: <20241219-sm8650-v6-13-hmd-deckard-mdss-quad-upstream-32-v3-7-92c7c0a228e3@linaro.org>
On 12/18/2024 11:49 PM, Jun Nie wrote:
> There are 2 interfaces and 4 pingpong in quad pipe. Map the 2nd
> interface to 3rd PP instead of the 2nd PP.
>
> Signed-off-by: Jun Nie <jun.nie@linaro.org>
> Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
Reviewed-by: Jessica Zhang <quic_jesszhan@quicinc.com>
> ---
> drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c | 15 +++++++++++++--
> 1 file changed, 13 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c b/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c
> index fd32ef468d5f9..96d06db3e4be5 100644
> --- a/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c
> +++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c
> @@ -1220,7 +1220,8 @@ static void dpu_encoder_virt_atomic_mode_set(struct drm_encoder *drm_enc,
> struct dpu_hw_blk *hw_pp[MAX_CHANNELS_PER_ENC];
> struct dpu_hw_blk *hw_ctl[MAX_CHANNELS_PER_ENC];
> struct dpu_hw_blk *hw_dsc[MAX_CHANNELS_PER_ENC];
> - int num_ctl, num_pp, num_dsc;
> + struct dpu_hw_blk *hw_lm[MAX_CHANNELS_PER_ENC];
> + int num_lm, num_ctl, num_pp, num_dsc, num_pp_per_intf;
> unsigned int dsc_mask = 0;
> int i;
>
> @@ -1275,11 +1276,21 @@ static void dpu_encoder_virt_atomic_mode_set(struct drm_encoder *drm_enc,
> dpu_enc->cur_master->hw_cdm = hw_cdm ? to_dpu_hw_cdm(hw_cdm) : NULL;
> }
>
> + num_lm = dpu_rm_get_assigned_resources(&dpu_kms->rm, global_state,
> + drm_enc->crtc, DPU_HW_BLK_LM, hw_lm, ARRAY_SIZE(hw_lm));
> +
> +
> + /*
> + * There may be 4 PP and 2 INTF for quad pipe case, so INTF is not
> + * mapped to PP 1:1. Let's calculate the stride with pipe/INTF
> + */
> + num_pp_per_intf = num_lm / dpu_enc->num_phys_encs;
> +
> for (i = 0; i < dpu_enc->num_phys_encs; i++) {
> struct dpu_encoder_phys *phys = dpu_enc->phys_encs[i];
> struct dpu_hw_ctl *ctl0 = to_dpu_hw_ctl(hw_ctl[0]);
>
> - phys->hw_pp = dpu_enc->hw_pp[i];
> + phys->hw_pp = dpu_enc->hw_pp[num_pp_per_intf * i];
> if (!phys->hw_pp) {
> DPU_ERROR_ENC(dpu_enc,
> "no pp block assigned at idx: %d\n", i);
>
> --
> 2.34.1
>
next prev parent reply other threads:[~2025-01-09 18:12 UTC|newest]
Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-19 7:49 [PATCH v3 00/15] (no cover subject) Jun Nie
2024-12-19 7:49 ` [PATCH v3 01/15] drm/msm/dpu: Do not fix number of DSC Jun Nie
2024-12-19 22:08 ` Dmitry Baryshkov
2024-12-19 7:49 ` [PATCH v3 02/15] drm/msm/dpu: configure DSC per number in use Jun Nie
2024-12-19 22:06 ` Dmitry Baryshkov
2024-12-19 7:49 ` [PATCH v3 03/15] drm/msm/dpu: polish log for resource allocation Jun Nie
2024-12-19 22:07 ` Dmitry Baryshkov
2024-12-19 7:49 ` [PATCH v3 04/15] drm/msm/dpu: decide right side per last bit Jun Nie
2024-12-19 22:09 ` Dmitry Baryshkov
2025-01-08 23:41 ` Jessica Zhang
2025-01-09 4:35 ` Jun Nie
2025-01-09 12:14 ` Dmitry Baryshkov
2024-12-19 7:49 ` [PATCH v3 05/15] drm/msm/dpu: fix mixer number counter on allocation Jun Nie
2024-12-19 22:14 ` Dmitry Baryshkov
2025-01-09 1:29 ` Jessica Zhang
2025-01-09 4:40 ` Jun Nie
2025-01-09 12:15 ` Dmitry Baryshkov
2024-12-19 7:49 ` [PATCH v3 06/15] drm/msm/dpu: switch RM to use crtc_id rather than enc_id for allocation Jun Nie
2024-12-19 7:49 ` [PATCH v3 07/15] drm/msm/dpu: bind correct pingpong for quad pipe Jun Nie
2025-01-09 18:12 ` Jessica Zhang [this message]
2024-12-19 7:49 ` [PATCH v3 08/15] drm/msm/dpu: handle pipes as array Jun Nie
2024-12-19 22:26 ` Dmitry Baryshkov
2024-12-19 7:49 ` [PATCH v3 09/15] drm/msm/dpu: split PIPES_PER_STAGE definition per plane and mixer Jun Nie
2024-12-19 22:28 ` Dmitry Baryshkov
2024-12-19 7:49 ` [PATCH v3 10/15] drm/msm/dpu: Add pipe as trace argument Jun Nie
2024-12-19 22:29 ` Dmitry Baryshkov
2024-12-31 13:24 ` Jun Nie
2024-12-31 14:04 ` Dmitry Baryshkov
2024-12-19 7:49 ` [PATCH v3 11/15] drm/msm/dpu: blend pipes per mixer pairs config Jun Nie
2024-12-19 22:40 ` Dmitry Baryshkov
2024-12-19 7:49 ` [PATCH v3 12/15] drm/msm/dpu: support plane splitting in quad-pipe case Jun Nie
2024-12-19 23:16 ` Dmitry Baryshkov
2024-12-19 7:49 ` [PATCH v3 13/15] drm/msm/dpu: Support quad-pipe in SSPP checking Jun Nie
2024-12-19 23:23 ` Dmitry Baryshkov
2024-12-19 7:49 ` [PATCH v3 14/15] drm/msm/dpu: support SSPP assignment for quad-pipe case Jun Nie
2024-12-19 23:30 ` Dmitry Baryshkov
2024-12-19 7:49 ` [PATCH v3 15/15] drm/msm/dpu: Enable quad-pipe for DSC and dual-DSI case Jun Nie
2024-12-19 23:46 ` Dmitry Baryshkov
2025-01-03 15:49 ` Jun Nie
2025-01-03 17:51 ` Dmitry Baryshkov
2025-01-06 8:21 ` Jun Nie
2025-01-07 22:25 ` Dmitry Baryshkov
2024-12-19 7:53 ` [PATCH v3 00/15] drm/msm/dpu: Support quad pipe with dual-DSI Jun Nie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=98cd0bc9-27f4-4903-996a-86702a2eb96c@quicinc.com \
--to=quic_jesszhan@quicinc.com \
--cc=airlied@gmail.com \
--cc=dmitry.baryshkov@linaro.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=freedreno@lists.freedesktop.org \
--cc=jun.nie@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marijn.suijten@somainline.org \
--cc=quic_abhinavk@quicinc.com \
--cc=robdclark@gmail.com \
--cc=sean@poorly.run \
--cc=simona@ffwll.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®