Re: [PATCH v2 1/2] xen: Silence compiler warnings

Re: [PATCH v2 1/2] xen: Silence compiler warnings

[Daniel Kiper]

David,

> On 12/07/14 22:09, Daniel Kiper wrote:
> > Add inline keyword to silence the following compiler
> > warnings if xen_efi_probe() is not used:
>
> The title and should be:
>
>     xen: make stub xen_efi_probe() static inline
>
>     Empty stub functions in headers should be inline or the compiler
>     will warn that it is unused.
>
> Do you want this to go via the Xen tree or the EFI one?

Thanks for your comment but as I can see it was
taken by Matt and now it is a part of tip.

Daniel

[PATCH v2 0/2] xen: Silence compiler warnings

[Daniel Kiper]

Hi,

Here are two patches that follow earlier Xen dom0 EFI series and
fix some compiler warnings found during detailed build tests.

Both patches should be applied to:

git://git.kernel.org/pub/scm/linux/kernel/git/mfleming/efi.git next

v2 contains fix suggested by Konrad Rzeszutek Wilk.

Daniel

PS I will be on vacation from 14th Jul till 25th Jul.

 arch/x86/xen/Makefile    |    1 +
 arch/x86/xen/efi.c       |   43 +++++++++++++++++++++++++++++++++++++++++++
 arch/x86/xen/enlighten.c |   15 +--------------
 arch/x86/xen/xen-ops.h   |    8 ++++++++
 include/xen/xen-ops.h    |    2 +-
 5 files changed, 54 insertions(+), 15 deletions(-)

Daniel Kiper (2):
      xen: Silence compiler warnings
      arch/x86/xen: Silence compiler warnings

[PATCH v2 1/2] xen: Silence compiler warnings

[Daniel Kiper]

Add inline keyword to silence the following compiler
warnings if xen_efi_probe() is not used:

  CC      arch/x86/xen/setup.o
In file included from arch/x86/xen/xen-ops.h:7:0,
                 from arch/x86/xen/setup.c:31:
include/xen/xen-ops.h:43:35: warning: ‘xen_efi_probe’ defined but not used [-Wunused-function]

Signed-off-by: Daniel Kiper <daniel.kiper@oracle.com>
---
 include/xen/xen-ops.h |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/include/xen/xen-ops.h b/include/xen/xen-ops.h
index 771bbba..7491ee5 100644
--- a/include/xen/xen-ops.h
+++ b/include/xen/xen-ops.h
@@ -40,7 +40,7 @@ bool xen_running_on_version_or_later(unsigned int major, unsigned int minor);
 #ifdef CONFIG_XEN_EFI
 extern efi_system_table_t *xen_efi_probe(void);
 #else
-static efi_system_table_t __init *xen_efi_probe(void)
+static inline efi_system_table_t __init *xen_efi_probe(void)
 {
 	return NULL;
 }
-- 
1.7.10.4

Re: [PATCH v2 1/2] xen: Silence compiler warnings

[Konrad Rzeszutek Wilk]

On July 12, 2014 5:09:47 PM EDT, Daniel Kiper <daniel.kiper@oracle.com> wrote:
>Add inline keyword to silence the following compiler
>warnings if xen_efi_probe() is not used:
>
>  CC      arch/x86/xen/setup.o
>In file included from arch/x86/xen/xen-ops.h:7:0,
>                 from arch/x86/xen/setup.c:31:
>include/xen/xen-ops.h:43:35: warning: ‘xen_efi_probe’ defined but not
>used [-Wunused-function]
>
>Signed-off-by: Daniel Kiper <daniel.kiper@oracle.com>

Reviewed-by: Konrad Rzeszutek Wilk <Konrad.wilk@oracle.com>
>---
> include/xen/xen-ops.h |    2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/include/xen/xen-ops.h b/include/xen/xen-ops.h
>index 771bbba..7491ee5 100644
>--- a/include/xen/xen-ops.h
>+++ b/include/xen/xen-ops.h
>@@ -40,7 +40,7 @@ bool xen_running_on_version_or_later(unsigned int
>major, unsigned int minor);
> #ifdef CONFIG_XEN_EFI
> extern efi_system_table_t *xen_efi_probe(void);
> #else
>-static efi_system_table_t __init *xen_efi_probe(void)
>+static inline efi_system_table_t __init *xen_efi_probe(void)
> {
> 	return NULL;
> }

Re: [PATCH v2 1/2] xen: Silence compiler warnings

[David Vrabel]

On 12/07/14 22:09, Daniel Kiper wrote:
> Add inline keyword to silence the following compiler
> warnings if xen_efi_probe() is not used:

The title and should be:

    xen: make stub xen_efi_probe() static inline

    Empty stub functions in headers should be inline or the compiler
    will warn that it is unused.

Do you want this to go via the Xen tree or the EFI one?

David