[PATCH] mfd: simple-mfd-i2c: remove select I2C_K1

[PATCH] mfd: simple-mfd-i2c: remove select I2C_K1

[Troy Mitchell]

select will force a symbol to a specific value without considering
its dependencies. As a result, the i2c-k1 driver will fail to build
when OF or COMMON_CLK are disabled.

The reason for removing I2C_K1 instead of adding a depends on condition
is to keep the possibility for other SoCs to use this PMIC.

Reported-by: kernel test robot <lkp@intel.com>
Closes: https://lore.kernel.org/oe-kbuild-all/202510211523.sSEVqPUQ-lkp@intel.com/
Signed-off-by: Troy Mitchell <troy.mitchell@linux.spacemit.com>
---
 drivers/mfd/Kconfig | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/mfd/Kconfig b/drivers/mfd/Kconfig
index 6cec1858947bf7ab5ee78beb730c95dabcb43a98..ea367c7e97f116d7585411fff5ba6bcd36882524 100644
--- a/drivers/mfd/Kconfig
+++ b/drivers/mfd/Kconfig
@@ -1258,7 +1258,6 @@ config MFD_SPACEMIT_P1
 	tristate "SpacemiT P1 PMIC"
 	depends on ARCH_SPACEMIT || COMPILE_TEST
 	depends on I2C
-	select I2C_K1
 	select MFD_SIMPLE_MFD_I2C
 	help
 	  This option supports the I2C-based SpacemiT P1 PMIC, which

---
base-commit: 3a8660878839faadb4f1a6dd72c3179c1df56787
change-id: 20251021-p1-kconfig-fix-6d2b59d03b8f

Best regards,
-- 
Troy Mitchell <troy.mitchell@linux.spacemit.com>

Re: [PATCH] mfd: simple-mfd-i2c: remove select I2C_K1

[Alex Elder]

On 10/21/25 8:58 PM, Troy Mitchell wrote:
> select will force a symbol to a specific value without considering
> its dependencies. As a result, the i2c-k1 driver will fail to build
> when OF or COMMON_CLK are disabled.

Should config I2C_K1 depend on COMMON_CLK then?

But you're right, the selecting config should ensure the
dependencies of the selected one are satisfied.

> The reason for removing I2C_K1 instead of adding a depends on condition
> is to keep the possibility for other SoCs to use this PMIC.

Acked-by: Alex Elder <elder@riscstar.com>

> 
> Reported-by: kernel test robot <lkp@intel.com>
> Closes: https://lore.kernel.org/oe-kbuild-all/202510211523.sSEVqPUQ-lkp@intel.com/
> Signed-off-by: Troy Mitchell <troy.mitchell@linux.spacemit.com>
> ---
>   drivers/mfd/Kconfig | 1 -
>   1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/mfd/Kconfig b/drivers/mfd/Kconfig
> index 6cec1858947bf7ab5ee78beb730c95dabcb43a98..ea367c7e97f116d7585411fff5ba6bcd36882524 100644
> --- a/drivers/mfd/Kconfig
> +++ b/drivers/mfd/Kconfig
> @@ -1258,7 +1258,6 @@ config MFD_SPACEMIT_P1
>   	tristate "SpacemiT P1 PMIC"
>   	depends on ARCH_SPACEMIT || COMPILE_TEST
>   	depends on I2C
> -	select I2C_K1
>   	select MFD_SIMPLE_MFD_I2C
>   	help
>   	  This option supports the I2C-based SpacemiT P1 PMIC, which
> 
> ---
> base-commit: 3a8660878839faadb4f1a6dd72c3179c1df56787
> change-id: 20251021-p1-kconfig-fix-6d2b59d03b8f
> 
> Best regards,

Re: [PATCH] mfd: simple-mfd-i2c: remove select I2C_K1

[Troy Mitchell]

On Tue, Oct 21, 2025 at 11:30:37PM -0500, Alex Elder wrote:
> On 10/21/25 8:58 PM, Troy Mitchell wrote:
> > select will force a symbol to a specific value without considering
> > its dependencies. As a result, the i2c-k1 driver will fail to build
> > when OF or COMMON_CLK are disabled.
> 
> Should config I2C_K1 depend on COMMON_CLK then?
Yes, this patch [1] registers the ILCR as a clock.

> 
> But you're right, the selecting config should ensure the
> dependencies of the selected one are satisfied.
And the config REGULATOR_SPACEMIT_P1 select MFD_SPACEMIT_P1(RTC same).
Should we change it to depends on?
> 
> > The reason for removing I2C_K1 instead of adding a depends on condition
> > is to keep the possibility for other SoCs to use this PMIC.
> 
> Acked-by: Alex Elder <elder@riscstar.com>
Thanks.

                - Troy
Link:
https://lore.kernel.org/all/20251017-k1-i2c-ilcr-v4-1-eed4903ecdb9@linux.spacemit.com/ [1]
> 
> > 
> > Reported-by: kernel test robot <lkp@intel.com>
> > Closes: https://lore.kernel.org/oe-kbuild-all/202510211523.sSEVqPUQ-lkp@intel.com/
> > Signed-off-by: Troy Mitchell <troy.mitchell@linux.spacemit.com>
> > ---
> >   drivers/mfd/Kconfig | 1 -
> >   1 file changed, 1 deletion(-)
> > 
> > diff --git a/drivers/mfd/Kconfig b/drivers/mfd/Kconfig
> > index 6cec1858947bf7ab5ee78beb730c95dabcb43a98..ea367c7e97f116d7585411fff5ba6bcd36882524 100644
> > --- a/drivers/mfd/Kconfig
> > +++ b/drivers/mfd/Kconfig
> > @@ -1258,7 +1258,6 @@ config MFD_SPACEMIT_P1
> >   	tristate "SpacemiT P1 PMIC"
> >   	depends on ARCH_SPACEMIT || COMPILE_TEST
> >   	depends on I2C
> > -	select I2C_K1
> >   	select MFD_SIMPLE_MFD_I2C
> >   	help
> >   	  This option supports the I2C-based SpacemiT P1 PMIC, which
> > 
> > ---
> > base-commit: 3a8660878839faadb4f1a6dd72c3179c1df56787
> > change-id: 20251021-p1-kconfig-fix-6d2b59d03b8f
> > 
> > Best regards,
> 
> 

Re: [PATCH] mfd: simple-mfd-i2c: remove select I2C_K1

[Troy Mitchell]

On Wed, Oct 22, 2025 at 12:37:53PM +0800, Troy Mitchell wrote:
> On Tue, Oct 21, 2025 at 11:30:37PM -0500, Alex Elder wrote:
> > On 10/21/25 8:58 PM, Troy Mitchell wrote:
> > > select will force a symbol to a specific value without considering
> > > its dependencies. As a result, the i2c-k1 driver will fail to build
> > > when OF or COMMON_CLK are disabled.
> > 
> > Should config I2C_K1 depend on COMMON_CLK then?
> Yes, this patch [1] registers the ILCR as a clock.
> 
> > 
> > But you're right, the selecting config should ensure the
> > dependencies of the selected one are satisfied.
> And the config REGULATOR_SPACEMIT_P1 select MFD_SPACEMIT_P1(RTC same).
> Should we change it to depends on?
Yixun has suggessted here[1] and I think too.

Link: https://lore.kernel.org/all/20251022004830-GYB1522542@gentoo.org/ [1]