Re: [PATCH v4 05/18] PCI: dwc: Export dw_handle_msi_irq()

[Shawn Lin <shawn.lin@rock-chips.com>]

在 2026/10/15 星期四 11:30, Koichiro Den 写道:
> Not every platform brings the iMSI-RX interrupt out as a dedicated
> line. On spear13xx and keembay it is a status bit in the SoC wrapper's
> interrupt register that the glue driver has to check and clear, and on
> dra7xx it shares the line with other sources the glue driver has to
> demultiplex. These drivers set msi_irq[0] to -ENODEV so the core does
> not install its chained handler, and service the MSIs from a handler of
> their own. spear13xx and keembay call dw_handle_msi_irq() for that.
> Both are built-in, so the function was never exported. dra7xx can be a
> module and has an MSI loop of its own.
> 

Reviewed-by: Shawn Lin <Shawn.lin@rock-chips.com>

> Export the function so that modular glue drivers can use it as well.
> The pcie-rcar-gen4 driver, where both situations apply, is the first user.
> 
> Reviewed-by: Marek Vasut <marek.vasut+renesas@mailbox.org>
> Signed-off-by: Koichiro Den <den@valinux.co.jp>
> ---
> Changes since v3:
>    - No changes.
> 
>   drivers/pci/controller/dwc/pcie-designware-host.c | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/pci/controller/dwc/pcie-designware-host.c b/drivers/pci/controller/dwc/pcie-designware-host.c
> index 77aa79ef0ccf..63b38532d069 100644
> --- a/drivers/pci/controller/dwc/pcie-designware-host.c
> +++ b/drivers/pci/controller/dwc/pcie-designware-host.c
> @@ -85,6 +85,7 @@ void dw_handle_msi_irq(struct dw_pcie_rp *pp)
>   			generic_handle_demux_domain_irq(pp->irq_domain, irq_off + pos);
>   	}
>   }
> +EXPORT_SYMBOL_GPL(dw_handle_msi_irq);
>   
>   /* Chained MSI interrupt service routine */
>   static void dw_chained_msi_isr(struct irq_desc *desc)