From: Khushit Shah <khushit.shah@nutanix.com>
To: Sean Christopherson <seanjc@google.com>
Cc: David Woodhouse <dwmw2@infradead.org>,
"pbonzini@redhat.com" <pbonzini@redhat.com>,
"kai.huang@intel.com" <kai.huang@intel.com>,
"mingo@redhat.com" <mingo@redhat.com>,
"x86@kernel.org" <x86@kernel.org>, "bp@alien8.de" <bp@alien8.de>,
"hpa@zytor.com" <hpa@zytor.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"kvm@vger.kernel.org" <kvm@vger.kernel.org>,
"dave.hansen@linux.intel.com" <dave.hansen@linux.intel.com>,
"tglx@linutronix.de" <tglx@linutronix.de>,
Jon Kohler <jon@nutanix.com>,
Shaju Abraham <shaju.abraham@nutanix.com>,
"stable@vger.kernel.org" <stable@vger.kernel.org>
Subject: Re: [PATCH v3] KVM: x86: Add x2APIC "features" to control EOI broadcast suppression
Date: Wed, 3 Dec 2025 07:45:34 +0000 [thread overview]
Message-ID: <994FA1C8-7AC2-4FD2-958D-373C0AA1553A@nutanix.com> (raw)
In-Reply-To: <aS8Vhb66UViQmY_Q@google.com>
> On 2 Dec 2025, at 10:06 PM, Sean Christopherson <seanjc@google.com> wrote:
>
> + if (cap->args[0] & KVM_X2APIC_ENABLE_SUPPRESS_EOI_BROADCAST)
> + kvm->arch.suppress_eoi_broadcast = KVM_SUPPRESS_EOI_ENABLED;
> + if (cap->args[0] & KVM_X2APIC_DISABLE_SUPPRESS_EOI_BROADCAST)
> + kvm->arch.suppress_eoi_broadcast = KVM_SUPPRESS_EOI_DISABLED;
Should this also update existing vCPUs by calling kvm_apic_set_version()
for all already-created vCPUs? or is the intent that userspace must set these flags
before any vCPUs are created? If so, should this warn if called after vcpus are
created?
QEMU currently creates vCPUs before initializing the I/O APIC, so deciding KVM’s
SEOIB behavior at vCPU initialization time is just a bit awkward. It’s manageable
either way, I just want to confirm the uAPI semantics.
For reference, the initial QEMU side patch:
https://patchew.org/QEMU/20251126093742.2110483-1-khushit.shah@nutanix.com/
next prev parent reply other threads:[~2025-12-03 7:46 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-25 18:05 Khushit Shah
2025-11-25 21:16 ` Huang, Kai
2025-12-02 9:13 ` David Woodhouse
2025-12-02 12:58 ` Khushit Shah
2025-12-02 13:31 ` David Woodhouse
2025-12-02 15:42 ` Sean Christopherson
2025-12-02 15:51 ` David Woodhouse
2025-12-02 16:36 ` Sean Christopherson
2025-12-02 17:10 ` David Woodhouse
2025-12-02 22:26 ` Sean Christopherson
2025-12-02 22:35 ` David Woodhouse
2025-12-03 0:50 ` Huang, Kai
2025-12-03 1:14 ` David Woodhouse
2025-12-03 12:25 ` David Woodhouse
2025-12-03 13:10 ` Paolo Bonzini
2025-12-03 13:32 ` David Woodhouse
2025-12-03 13:36 ` Paolo Bonzini
2025-12-03 13:55 ` David Woodhouse
2025-12-03 7:45 ` Khushit Shah [this message]
2025-12-02 16:04 ` David Woodhouse
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=994FA1C8-7AC2-4FD2-958D-373C0AA1553A@nutanix.com \
--to=khushit.shah@nutanix.com \
--cc=bp@alien8.de \
--cc=dave.hansen@linux.intel.com \
--cc=dwmw2@infradead.org \
--cc=hpa@zytor.com \
--cc=jon@nutanix.com \
--cc=kai.huang@intel.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=pbonzini@redhat.com \
--cc=seanjc@google.com \
--cc=shaju.abraham@nutanix.com \
--cc=stable@vger.kernel.org \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®