From: Chuck Lever <chuck.lever@oracle.com>
To: Miklos Szeredi <miklos@szeredi.hu>
Cc: "J. Bruce Fields" <bfields@fieldses.org>,
Jeff Layton <jlayton@redhat.com>,
Malahal Naineni <malahal@us.ibm.com>,
Steve Dickson <SteveD@redhat.com>,
linux-fsdevel@vger.kernel.org, linux-nfs@vger.kernel.org,
linux-kernel@vger.kernel.org, viro@zeniv.linux.org.uk,
hch@infradead.org, michael.brantley@deshaw.com,
sven.breuner@itwm.fraunhofer.de, pstaubach@exagrid.com,
trond.myklebust@fys.uio.no, rees@umich.edu
Subject: Re: [PATCH RFC v3] vfs: make fstatat retry once on ESTALE errors from getattr call
Date: Mon, 23 Apr 2012 11:02:32 -0400 [thread overview]
Message-ID: <9991AAC7-5256-4AFE-9722-7AF1119EE7BE@oracle.com> (raw)
In-Reply-To: <87hawasdrb.fsf@tucsk.pomaz.szeredi.hu>
On Apr 23, 2012, at 10:51 AM, Miklos Szeredi wrote:
> "J. Bruce Fields" <bfields@fieldses.org> writes:
>
>>
>> I also wonder whether it would be making too many assumptions about the
>> server or filesystem: just because ordinary posix interfaces don't allow
>> atomic replacement of a whole directory tree doesn't mean the server
>> might not have some way to do it.
>
> Exactly because posix limits the atomic replacement to empty directories
> is that this feature is not useful and is why linux can get away with
> the dead directory behavior in this case. And thinking about fixing
> this in NFS is completely pointless since no one will rely on the atomic
> replacement behavior. Fixing local filesystems is also pointless for
> the same reason.
>
> Atomic replacement of whole directory trees would indeed be more useful,
> but it's highly unlikely to be used anywhere since applications relying
> on this feature would be limited to special filesystems that allow this.
The cases I can think of have to do with file system restore, file system and block device snapshots, and so on. This type of use case may not practical on today's Linux server, but they are a reality for anyone using high-end NFS storage.
> So my statement is "ENOENT is equivalent to ESTALE if already retrying
> path lookup with LOOKUP_REVAL on any operation that takes an parent
> directory and a name (lookup, create, link, unlink, symlink, mkdir,
> rmdir, mknod, rename)."
>
> This equivalence is in the sense that it doesn't change behavior
> compared to local filesystems.
>
> For other operations ENOENT is not equivalent to ESTALE.
>
> Thanks,
> Miklos
> --
> To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
--
Chuck Lever
chuck[dot]lever[at]oracle[dot]com
next prev parent reply other threads:[~2012-04-23 15:03 UTC|newest]
Thread overview: 80+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-13 11:25 [PATCH RFC] vfs: make fstatat retry " Jeff Layton
2012-04-13 12:02 ` Jim Rees
2012-04-13 12:09 ` Jeff Layton
[not found] ` <20120413150518.GA1987@us.ibm.com>
2012-04-13 15:42 ` Jeff Layton
2012-04-13 16:07 ` Steve Dickson
2012-04-13 17:10 ` Jeff Layton
2012-04-13 17:34 ` Peter Staubach
2012-04-13 23:00 ` Jeff Layton
2012-04-14 0:57 ` Trond Myklebust
2012-04-15 19:03 ` Bernd Schubert
2012-04-15 19:27 ` J. Bruce Fields
2012-04-16 14:23 ` Bernd Schubert
2012-04-15 19:57 ` Chuck Lever
2012-04-16 11:23 ` Jeff Layton
2012-04-17 11:53 ` Steve Dickson
2012-04-16 11:36 ` Jeff Layton
2012-04-16 12:54 ` Peter Staubach
2012-04-16 16:04 ` Jeff Layton
2012-04-16 14:44 ` Bernd Schubert
2012-04-16 17:46 ` Jeff Layton
2012-04-16 19:33 ` Myklebust, Trond
2012-04-16 19:43 ` Jeff Layton
2012-04-16 20:25 ` Myklebust, Trond
2012-04-16 23:05 ` Jeff Layton
2012-04-17 11:46 ` Steve Dickson
2012-04-17 13:36 ` Jeff Layton
2012-04-17 14:14 ` Steve Dickson
2012-04-17 14:27 ` Miklos Szeredi
2012-04-17 15:02 ` Jeff Layton
2012-04-17 15:50 ` Miklos Szeredi
2012-04-17 16:03 ` Jeff Layton
2012-04-17 15:59 ` Steve Dickson
2012-04-17 13:12 ` Miklos Szeredi
2012-04-17 13:32 ` Jeff Layton
2012-04-17 14:03 ` Miklos Szeredi
2012-04-17 14:22 ` Jeff Layton
2012-04-17 14:04 ` Myklebust, Trond
2012-04-17 14:20 ` Jeff Layton
2012-04-17 15:45 ` J. Bruce Fields
2012-04-17 16:02 ` Miklos Szeredi
2012-04-17 13:39 ` Peter Staubach
2012-04-17 14:08 ` Myklebust, Trond
2012-04-17 14:48 ` Peter Staubach
2012-04-18 15:16 ` Jeff Layton
2012-04-16 19:43 ` Scott Lovenberg
2012-04-16 16:55 ` [PATCH RFC v2] " Jeff Layton
2012-04-18 11:52 ` [PATCH RFC v3] vfs: make fstatat retry once " Jeff Layton
2012-04-20 14:40 ` Jeff Layton
2012-04-20 20:18 ` Steve Dickson
2012-04-20 20:37 ` Malahal Naineni
2012-04-20 21:13 ` Jeff Layton
2012-04-22 5:40 ` Miklos Szeredi
2012-04-23 12:00 ` Jeff Layton
2012-04-23 13:00 ` J. Bruce Fields
2012-04-23 13:12 ` Jeff Layton
2012-04-23 13:34 ` J. Bruce Fields
2012-04-23 13:50 ` Jeff Layton
2012-04-23 13:54 ` J. Bruce Fields
2012-04-23 14:51 ` Miklos Szeredi
2012-04-23 15:02 ` Chuck Lever [this message]
2012-04-23 15:23 ` Miklos Szeredi
2012-04-23 17:45 ` Peter Staubach
2012-04-23 15:16 ` Jeff Layton
2012-04-23 15:28 ` Miklos Szeredi
2012-04-23 18:59 ` Jeff Layton
2012-04-20 21:13 ` Jeff Layton
2012-04-23 14:55 ` Steve Dickson
2012-04-23 15:32 ` Jeff Layton
2012-04-23 18:06 ` Steve Dickson
2012-04-23 18:33 ` Jeff Layton
2012-04-23 20:38 ` Peter Staubach
2012-04-24 14:50 ` Jeff Layton
2012-04-24 15:54 ` Miklos Szeredi
2012-04-24 16:34 ` Jeff Layton
2012-04-25 9:41 ` Miklos Szeredi
2012-04-25 12:04 ` Jeff Layton
2012-04-23 17:43 ` Peter Staubach
2012-04-23 19:06 ` Malahal Naineni
2012-04-22 4:16 ` Ric Wheeler
2012-04-23 11:20 ` Jeff Layton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9991AAC7-5256-4AFE-9722-7AF1119EE7BE@oracle.com \
--to=chuck.lever@oracle.com \
--cc=SteveD@redhat.com \
--cc=bfields@fieldses.org \
--cc=hch@infradead.org \
--cc=jlayton@redhat.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nfs@vger.kernel.org \
--cc=malahal@us.ibm.com \
--cc=michael.brantley@deshaw.com \
--cc=miklos@szeredi.hu \
--cc=pstaubach@exagrid.com \
--cc=rees@umich.edu \
--cc=sven.breuner@itwm.fraunhofer.de \
--cc=trond.myklebust@fys.uio.no \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®