* [PATCH] cpufreq: intel_pstate: Add Emerald Rapids support in no-HWP mode
@ 2023-12-13 10:28 Zhenguo Yao
2023-12-19 20:22 ` Rafael J. Wysocki
0 siblings, 1 reply; 4+ messages in thread
From: Zhenguo Yao @ 2023-12-13 10:28 UTC (permalink / raw)
To: srinivas.pandruvada, lenb
Cc: rafael, viresh.kumar, linux-pm, linux-kernel, yaozhenguo, Zhenguo Yao
Users may disable HWP in firmware, in which case intel_pstate wouldn't load
unless the CPU model is explicitly supported.
See also the following past commits:
commit df51f287b5de ("cpufreq: intel_pstate: Add Sapphire Rapids support
in no-HWP mode")
commit d8de7a44e11f ("cpufreq: intel_pstate: Add Skylake servers support")
commit 706c5328851d ("cpufreq: intel_pstate: Add Cometlake support in
no-HWP mode")
commit fbdc21e9b038 ("cpufreq: intel_pstate: Add Icelake servers support in
no-HWP mode")
commit 71bb5c82aaae ("cpufreq: intel_pstate: Add Tigerlake support in
no-HWP mode")
Signed-off-by: Zhenguo Yao <yaozhenguo1@gmail.com>
---
drivers/cpufreq/intel_pstate.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/cpufreq/intel_pstate.c b/drivers/cpufreq/intel_pstate.c
index a534a1f7f1ee..39e0a2cf7236 100644
--- a/drivers/cpufreq/intel_pstate.c
+++ b/drivers/cpufreq/intel_pstate.c
@@ -2406,6 +2406,7 @@ static const struct x86_cpu_id intel_pstate_cpu_ids[] = {
X86_MATCH(ICELAKE_X, core_funcs),
X86_MATCH(TIGERLAKE, core_funcs),
X86_MATCH(SAPPHIRERAPIDS_X, core_funcs),
+ X86_MATCH(EMERALDRAPIDS_X, core_funcs),
{}
};
MODULE_DEVICE_TABLE(x86cpu, intel_pstate_cpu_ids);
--
2.39.3
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] cpufreq: intel_pstate: Add Emerald Rapids support in no-HWP mode
2023-12-13 10:28 [PATCH] cpufreq: intel_pstate: Add Emerald Rapids support in no-HWP mode Zhenguo Yao
@ 2023-12-19 20:22 ` Rafael J. Wysocki
2023-12-19 20:33 ` srinivas pandruvada
0 siblings, 1 reply; 4+ messages in thread
From: Rafael J. Wysocki @ 2023-12-19 20:22 UTC (permalink / raw)
To: Zhenguo Yao, srinivas.pandruvada
Cc: lenb, rafael, viresh.kumar, linux-pm, linux-kernel, yaozhenguo
On Wed, Dec 13, 2023 at 11:28 AM Zhenguo Yao <yaozhenguo1@gmail.com> wrote:
>
> Users may disable HWP in firmware, in which case intel_pstate wouldn't load
> unless the CPU model is explicitly supported.
>
> See also the following past commits:
>
> commit df51f287b5de ("cpufreq: intel_pstate: Add Sapphire Rapids support
> in no-HWP mode")
> commit d8de7a44e11f ("cpufreq: intel_pstate: Add Skylake servers support")
> commit 706c5328851d ("cpufreq: intel_pstate: Add Cometlake support in
> no-HWP mode")
> commit fbdc21e9b038 ("cpufreq: intel_pstate: Add Icelake servers support in
> no-HWP mode")
> commit 71bb5c82aaae ("cpufreq: intel_pstate: Add Tigerlake support in
> no-HWP mode")
>
> Signed-off-by: Zhenguo Yao <yaozhenguo1@gmail.com>
Srinivas, any objections?
> ---
> drivers/cpufreq/intel_pstate.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/cpufreq/intel_pstate.c b/drivers/cpufreq/intel_pstate.c
> index a534a1f7f1ee..39e0a2cf7236 100644
> --- a/drivers/cpufreq/intel_pstate.c
> +++ b/drivers/cpufreq/intel_pstate.c
> @@ -2406,6 +2406,7 @@ static const struct x86_cpu_id intel_pstate_cpu_ids[] = {
> X86_MATCH(ICELAKE_X, core_funcs),
> X86_MATCH(TIGERLAKE, core_funcs),
> X86_MATCH(SAPPHIRERAPIDS_X, core_funcs),
> + X86_MATCH(EMERALDRAPIDS_X, core_funcs),
> {}
> };
> MODULE_DEVICE_TABLE(x86cpu, intel_pstate_cpu_ids);
> --
> 2.39.3
>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] cpufreq: intel_pstate: Add Emerald Rapids support in no-HWP mode
2023-12-19 20:22 ` Rafael J. Wysocki
@ 2023-12-19 20:33 ` srinivas pandruvada
2023-12-19 20:39 ` Rafael J. Wysocki
0 siblings, 1 reply; 4+ messages in thread
From: srinivas pandruvada @ 2023-12-19 20:33 UTC (permalink / raw)
To: Rafael J. Wysocki, Zhenguo Yao
Cc: lenb, viresh.kumar, linux-pm, linux-kernel, yaozhenguo
On Tue, 2023-12-19 at 21:22 +0100, Rafael J. Wysocki wrote:
> On Wed, Dec 13, 2023 at 11:28 AM Zhenguo Yao <yaozhenguo1@gmail.com>
> wrote:
> >
> > Users may disable HWP in firmware, in which case intel_pstate
> > wouldn't load
> > unless the CPU model is explicitly supported.
> >
> > See also the following past commits:
> >
> > commit df51f287b5de ("cpufreq: intel_pstate: Add Sapphire Rapids
> > support
> > in no-HWP mode")
> > commit d8de7a44e11f ("cpufreq: intel_pstate: Add Skylake servers
> > support")
> > commit 706c5328851d ("cpufreq: intel_pstate: Add Cometlake support
> > in
> > no-HWP mode")
> > commit fbdc21e9b038 ("cpufreq: intel_pstate: Add Icelake servers
> > support in
> > no-HWP mode")
> > commit 71bb5c82aaae ("cpufreq: intel_pstate: Add Tigerlake support
> > in
> > no-HWP mode")
> >
> > Signed-off-by: Zhenguo Yao <yaozhenguo1@gmail.com>
>
> Srinivas, any objections?
No.
Acked-by: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
>
> > ---
> > drivers/cpufreq/intel_pstate.c | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/drivers/cpufreq/intel_pstate.c
> > b/drivers/cpufreq/intel_pstate.c
> > index a534a1f7f1ee..39e0a2cf7236 100644
> > --- a/drivers/cpufreq/intel_pstate.c
> > +++ b/drivers/cpufreq/intel_pstate.c
> > @@ -2406,6 +2406,7 @@ static const struct x86_cpu_id
> > intel_pstate_cpu_ids[] = {
> > X86_MATCH(ICELAKE_X, core_funcs),
> > X86_MATCH(TIGERLAKE, core_funcs),
> > X86_MATCH(SAPPHIRERAPIDS_X, core_funcs),
> > + X86_MATCH(EMERALDRAPIDS_X, core_funcs),
> > {}
> > };
> > MODULE_DEVICE_TABLE(x86cpu, intel_pstate_cpu_ids);
> > --
> > 2.39.3
> >
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] cpufreq: intel_pstate: Add Emerald Rapids support in no-HWP mode
2023-12-19 20:33 ` srinivas pandruvada
@ 2023-12-19 20:39 ` Rafael J. Wysocki
0 siblings, 0 replies; 4+ messages in thread
From: Rafael J. Wysocki @ 2023-12-19 20:39 UTC (permalink / raw)
To: srinivas pandruvada, Zhenguo Yao
Cc: lenb, viresh.kumar, linux-pm, linux-kernel, yaozhenguo
On Tue, Dec 19, 2023 at 9:33 PM srinivas pandruvada
<srinivas.pandruvada@linux.intel.com> wrote:
>
> On Tue, 2023-12-19 at 21:22 +0100, Rafael J. Wysocki wrote:
> > On Wed, Dec 13, 2023 at 11:28 AM Zhenguo Yao <yaozhenguo1@gmail.com>
> > wrote:
> > >
> > > Users may disable HWP in firmware, in which case intel_pstate
> > > wouldn't load
> > > unless the CPU model is explicitly supported.
> > >
> > > See also the following past commits:
> > >
> > > commit df51f287b5de ("cpufreq: intel_pstate: Add Sapphire Rapids
> > > support
> > > in no-HWP mode")
> > > commit d8de7a44e11f ("cpufreq: intel_pstate: Add Skylake servers
> > > support")
> > > commit 706c5328851d ("cpufreq: intel_pstate: Add Cometlake support
> > > in
> > > no-HWP mode")
> > > commit fbdc21e9b038 ("cpufreq: intel_pstate: Add Icelake servers
> > > support in
> > > no-HWP mode")
> > > commit 71bb5c82aaae ("cpufreq: intel_pstate: Add Tigerlake support
> > > in
> > > no-HWP mode")
> > >
> > > Signed-off-by: Zhenguo Yao <yaozhenguo1@gmail.com>
> >
> > Srinivas, any objections?
> No.
>
> Acked-by: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
Applied as 6.8 material (with some minor edits in the changelog), thanks!
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2023-12-19 20:39 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-12-13 10:28 [PATCH] cpufreq: intel_pstate: Add Emerald Rapids support in no-HWP mode Zhenguo Yao
2023-12-19 20:22 ` Rafael J. Wysocki
2023-12-19 20:33 ` srinivas pandruvada
2023-12-19 20:39 ` Rafael J. Wysocki
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®