Re: [PATCH v2 2/2] gpio: aggregator: add gpio-aggregator DT compatible

[Krzysztof Kozlowski <krzk@kernel.org>]

On 11/02/2026 22:49, James Hilliard wrote:
>>>>>
>>>>> Regardless of the DT bindings - this change is perfectly fine. We do
>>>>
>>>> You cannot have compatible without DT bindings, so this alone is not
>>>> "perfectly fine". Maybe you wanted platform_device_id entry for
>>>> ACPI/legacy/MFD devices?
>>>>
>>>
>>> Sure you can, you just can't put it into upstream devicetree sources.
>>> We have had a compatible for gpio-sim for testing purposes for years.
>>> Why would it be illegal to enable matching of platform drivers over DT
>>> for testing purposes?
>>
>> The primary issue is undocumented ones show up in 'make
>> dt_compatible_check'. I would like that to be warning free.
> 
> Would adding it here make sense?
> https://github.com/torvalds/linux/blob/v6.19/Documentation/devicetree/bindings/incomplete-devices.yaml#L243-L245

What would you like to achieve with that? The binding patch did not have
rationale why do we want it and here is the same question - what sort of
problem is being solved by adding it to incomplete (so wrong) devices?


Best regards,
Krzysztof