mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Jiaxun Yang" <jiaxun.yang@flygoat.com>
To: "Qi Hu" <huqi@loongson.cn>, "Xi Ruoyao" <xry111@xry111.site>,
	"Huacai Chen" <chenhuacai@kernel.org>
Cc: "Xuerui Wang" <kernel@xen0n.name>,
	loongarch@lists.linux.dev, LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2] LoongArch: Clean useless vcsr in loongarch_fpu.
Date: Wed, 06 Jul 2022 21:49:43 +0100	[thread overview]
Message-ID: <9d064771-9402-4e84-96f8-4713cddf42f2@www.fastmail.com> (raw)
In-Reply-To: <c824b9ca-c9c4-1912-7845-99a0989277a4@loongson.cn>



在2022年7月6日七月 上午5:00,Qi Hu写道:
> On 2022/7/6 10:51, Xi Ruoyao wrote:
>> On Wed, 2022-07-06 at 10:35 +0800, Huacai Chen wrote:
>>
>>> Maybe Xuerui and Ruoyao have some misunderstanding. LSX/LASX will
>>> surely be upstream, this has nothing to do with cleanup VCSR16.
>>> Because FP/LSX/LASX share the same control bits in FCSR now.
>> My guess:
>>
>> Almost all behavior of vector unit is controlled by FCSR (for example,
>> the rounding of both FPU and vector unit should be controlled by FCSR
>> altogether), except one bit similar to the bit 24 of MSACSR ("flush to
>> zero") is in VCSR [^1].  And "flush to zero" is not really useful so it
>> will be removed in 3A6000, and we'll not use it for 3A5000.
> Actually, flush to zero has been removed in 3A5000.
>>
>> [^1]: A more bold guess: the hardware engineers could have just said
>> "let's wire this register called MSACSR in GS464V as FCSR16/VCSR in
>> LA464, maybe it will be useful and who knows?"  But now in practice it's
>> not useful.
>>
>> Am I correct?
> The hardware(LA464) has removed the vcsr("has but not use" is 
> incorrect), and here are some details:
>
> - For all FP operations, including LSX/LASX, they are controlled by 
> fcsr0/1/2/3.
>
> - For LSX/LASX other operations, they are *not* controlled by any other 
> CSR now. And fcsr16 to fcsr31 are reserved to control these operations 
> (now they are *undefined*).
Sorry but what do you meant by “these” here?
If it means LSX/LASX, are you trying to say that future chip’s LSX/LASX won’t be
compatible with present 3A5000? As your said fcsr16 and fcsr31 are undefined
for now.

Thanks
-

>
> - Flush to zero(MSACSR.FS) is removed and not supported.
>
> - If you use "movfcsr2gr" to read the fcsr16, the value is *UNDEFINED*.

-- 
- Jiaxun

  reply	other threads:[~2022-07-06 20:50 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-07-04 15:36 Qi Hu
2022-07-05  8:46 ` WANG Xuerui
2022-07-05  9:49   ` Xi Ruoyao
2022-07-05 10:00     ` Xi Ruoyao
2022-07-06  2:35       ` Huacai Chen
2022-07-06  2:51         ` Xi Ruoyao
2022-07-06  4:00           ` Qi Hu
2022-07-06 20:49             ` Jiaxun Yang [this message]
2022-07-07  1:29               ` Qi Hu
2022-07-07  3:05                 ` WANG Xuerui
2022-07-07  4:04                   ` Xi Ruoyao
2022-07-07  4:22                     ` WANG Xuerui
2022-07-07  6:09                       ` Qi Hu
2022-07-07  6:24                         ` WANG Xuerui
2022-07-07  6:39                           ` Qi Hu
2022-07-07  5:42                   ` Qi Hu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=9d064771-9402-4e84-96f8-4713cddf42f2@www.fastmail.com \
    --to=jiaxun.yang@flygoat.com \
    --cc=chenhuacai@kernel.org \
    --cc=huqi@loongson.cn \
    --cc=kernel@xen0n.name \
    --cc=linux-kernel@vger.kernel.org \
    --cc=loongarch@lists.linux.dev \
    --cc=xry111@xry111.site \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®