From: WANG Xuerui <kernel@xen0n.name>
To: Xi Ruoyao <xry111@xry111.site>, WANG Xuerui <kernel@xen0n.name>,
Qi Hu <huqi@loongson.cn>, Jiaxun Yang <jiaxun.yang@flygoat.com>,
Huacai Chen <chenhuacai@kernel.org>
Cc: loongarch@lists.linux.dev, LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2] LoongArch: Clean useless vcsr in loongarch_fpu.
Date: Thu, 7 Jul 2022 12:22:52 +0800 [thread overview]
Message-ID: <e67e03ae-e2d4-79e6-7f6a-5558ea9de52b@xen0n.name> (raw)
In-Reply-To: <bd889cd7b72138a12b1339a33156ff46530c20b0.camel@xry111.site>
On 2022/7/7 12:04, Xi Ruoyao wrote:
> On Thu, 2022-07-07 at 11:05 +0800, WANG Xuerui wrote:
>
>> To be frank, at this point I think you're trying to hide something.
>> (This is not your fault, blame someone else of course because they told
>> you the fact.) In the old-world kernel the VCSR a.k.a. FCSR16 is
>> certainly being saved/restored, and there's apparently no harm in doing
>> so. And if the contents are indeed "undefined", why are the code there
>> in the first place? Certainly the bits *are* meaningful, only that for
>> some reason you aren't revealing the semantics and pretending that they
>> are "undefined" and probably "do nothing externally observable" if
>> accessed in the first place.
> On a 3A5000LL, I did an experiment via a kernel module, which enables
> LSX/LASX and tries to write and read fcsr16. I tried each bit (1, 2, 4,
> 8, ..., 1 << 31) one by one. The result: no matter which bit I wrote
> into fcsr16, I always read out 0.
>
> And I've objdump'ed a kernel shipped in an early Loongnix release. It
> seems the only reference to fcsr16 is a "movgr2fcsr $r16, $r0"
> instruction.
Hmm this is weird. I can't understand why the vcsr code was there in the
first place then... I'd like to check a few Loongnix/Kylin/UOS kernels
but currently I don't have the time.
If this is the case, indeed all vcsr-related code should be removed.
Although I'm still not sure how to best word the commit message.
next prev parent reply other threads:[~2022-07-07 4:23 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-04 15:36 Qi Hu
2022-07-05 8:46 ` WANG Xuerui
2022-07-05 9:49 ` Xi Ruoyao
2022-07-05 10:00 ` Xi Ruoyao
2022-07-06 2:35 ` Huacai Chen
2022-07-06 2:51 ` Xi Ruoyao
2022-07-06 4:00 ` Qi Hu
2022-07-06 20:49 ` Jiaxun Yang
2022-07-07 1:29 ` Qi Hu
2022-07-07 3:05 ` WANG Xuerui
2022-07-07 4:04 ` Xi Ruoyao
2022-07-07 4:22 ` WANG Xuerui [this message]
2022-07-07 6:09 ` Qi Hu
2022-07-07 6:24 ` WANG Xuerui
2022-07-07 6:39 ` Qi Hu
2022-07-07 5:42 ` Qi Hu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e67e03ae-e2d4-79e6-7f6a-5558ea9de52b@xen0n.name \
--to=kernel@xen0n.name \
--cc=chenhuacai@kernel.org \
--cc=huqi@loongson.cn \
--cc=jiaxun.yang@flygoat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=loongarch@lists.linux.dev \
--cc=xry111@xry111.site \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®