From: Scott Wood <oss@buserror.net>
To: Yingjie Bai <byj.tea@gmail.com>, Michael Ellerman <mpe@ellerman.id.au>
Cc: yingjie_bai@126.com, Kumar Gala <galak@kernel.crashing.org>,
Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Paul Mackerras <paulus@samba.org>,
linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] powerpc/mpc85xx: also write addr_h to spin table for 64bit boot entry
Date: Tue, 24 Dec 2019 19:23:10 -0600 [thread overview]
Message-ID: <9e680f3798f1a771cba4b41f7a5d7fda7f534522.camel@buserror.net> (raw)
In-Reply-To: <CAFAt38F-YQUVNXEnLut0tMivYUy_OTK7G4wAHfddcmncsEpREQ@mail.gmail.com>
On Tue, 2019-12-24 at 09:35 +0800, Yingjie Bai wrote:
> Hi Michael,
> Thanks for pointing out the issue. My mistake...
> This patch should indeed make sense only when
> CONFIG_PHYS_64BIT=y
>
> I could not find corenet32_smp_defconfig, but I guess in your config,
> CONFIG_PHYS_64BIT=n ?
> I will update the patch later today
corenet32_smp_defconfig is a makefile rule that pulls in multiple config
fragments. It has CONFIG_PHYS_64BIT=y, but __pa() returns an unsigned long
regardless (which obviously needs to be fixed if DDR starting beyond 4G is to
be supported).
What 32-bit config are you using where this actually builds?
-Scott
next prev parent reply other threads:[~2019-12-25 1:33 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-25 15:15 yingjie_bai
2019-12-19 23:54 ` Scott Wood
2019-12-22 9:38 ` Michael Ellerman
2019-12-24 1:35 ` Yingjie Bai
2019-12-25 1:23 ` Scott Wood [this message]
2019-12-25 3:24 ` Yingjie Bai
2019-12-25 6:51 ` Scott Wood
2019-12-25 7:19 ` Yingjie Bai
2019-12-30 7:41 ` Yingjie Bai
2020-01-06 5:38 ` Yingjie Bai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9e680f3798f1a771cba4b41f7a5d7fda7f534522.camel@buserror.net \
--to=oss@buserror.net \
--cc=benh@kernel.crashing.org \
--cc=byj.tea@gmail.com \
--cc=galak@kernel.crashing.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mpe@ellerman.id.au \
--cc=paulus@samba.org \
--cc=yingjie_bai@126.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®