From: Scott Wood <oss@buserror.net>
To: Yingjie Bai <byj.tea@gmail.com>
Cc: Michael Ellerman <mpe@ellerman.id.au>,
yingjie_bai@126.com, Kumar Gala <galak@kernel.crashing.org>,
Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Paul Mackerras <paulus@samba.org>,
linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] powerpc/mpc85xx: also write addr_h to spin table for 64bit boot entry
Date: Wed, 25 Dec 2019 00:51:11 -0600 [thread overview]
Message-ID: <a37338283db548c58e6c36e4996a9474b1fe2038.camel@buserror.net> (raw)
In-Reply-To: <CAFAt38FnH376ioDuvyNJW=iOxbcooRRsEeVEfDudRoV4gG98SQ@mail.gmail.com>
On Wed, 2019-12-25 at 11:24 +0800, Yingjie Bai wrote:
> Hi Scott,
>
> __pa() returns 64bit in my setup.
>
> in arch/powerpc/include/asm/page.h
>
> #if defined(CONFIG_PPC32) && defined(CONFIG_BOOKE)
> #define __va(x) ((void *)(unsigned long)((phys_addr_t)(x) +
> VIRT_PHYS_OFFSET))
> #define __pa(x) ((unsigned long)(x) - VIRT_PHYS_OFFSET)
> #else
> #ifdef CONFIG_PPC64
> ...
>
>
>
> /* See Description below for VIRT_PHYS_OFFSET */
> #if defined(CONFIG_PPC32) && defined(CONFIG_BOOKE)
> #ifdef CONFIG_RELOCATABLE
> #define VIRT_PHYS_OFFSET virt_phys_offset
> #else
> #define VIRT_PHYS_OFFSET (KERNELBASE - PHYSICAL_START)
> #endif
> #endif
OK, so it's the lack of CONFIG_RELOCATABLE causing the build to fail. Ideally
we'd make __pa() consistently return phys_addr_t, even if the upper bits are
known to always be zero in a particular config.
-Scott
next prev parent reply other threads:[~2019-12-25 6:51 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-25 15:15 yingjie_bai
2019-12-19 23:54 ` Scott Wood
2019-12-22 9:38 ` Michael Ellerman
2019-12-24 1:35 ` Yingjie Bai
2019-12-25 1:23 ` Scott Wood
2019-12-25 3:24 ` Yingjie Bai
2019-12-25 6:51 ` Scott Wood [this message]
2019-12-25 7:19 ` Yingjie Bai
2019-12-30 7:41 ` Yingjie Bai
2020-01-06 5:38 ` Yingjie Bai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a37338283db548c58e6c36e4996a9474b1fe2038.camel@buserror.net \
--to=oss@buserror.net \
--cc=benh@kernel.crashing.org \
--cc=byj.tea@gmail.com \
--cc=galak@kernel.crashing.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mpe@ellerman.id.au \
--cc=paulus@samba.org \
--cc=yingjie_bai@126.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®