[PATCH v1 0/2] Macro Ordering and Typo Correction

[PATCH v1 0/2] Macro Ordering and Typo Correction

[Devendra K Verma]

These are minor and cosmetic changes.

o If the macros declaring the bit positions of a register
  are in order then it provides a good view. Corrected
  the ordering for once such register.
o Corrected the typo under the IP related data struct to
  have the correct name under respective IP structs.

Previous reviewed-by tags were part of the following
review:

https://lore.kernel.org/all/aoW7vxy2lpXEbmRq@SMW015318/
https://lore.kernel.org/all/dx5jvko7ygrqugzkt3k74l3d7lk7iauikmxrzuhvn2b4bdv5ub@s2l6zl3alx3z/#t

Devendra K Verma (2):
  dmaengine: dw-edma: Macro order as per reg bit position
  dmaengine: dw-edma: IP name corrected under its struct

 drivers/dma/dw-edma/dw-edma-pcie.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

-- 
2.43.0

[PATCH v1 1/2] dmaengine: dw-edma: Macro order as per reg bit position

[Devendra K Verma]

For a register the macros providing masks for bit ranges.
These macros if placed in order provide good view of the bits.
Placed macros in ascending order.

Signed-off-by: Devendra K Verma <devverma@amd.com>
---
 drivers/dma/dw-edma/dw-edma-pcie.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/dma/dw-edma/dw-edma-pcie.c b/drivers/dma/dw-edma/dw-edma-pcie.c
index 9f237ba916de..006dea7d6322 100644
--- a/drivers/dma/dw-edma/dw-edma-pcie.c
+++ b/drivers/dma/dw-edma/dw-edma-pcie.c
@@ -31,8 +31,8 @@
 
 #define DW_PCIE_XILINX_MDB_VSEC_DMA_ID		0x6
 #define DW_PCIE_XILINX_MDB_VSEC_ID		0x20
-#define DW_PCIE_XILINX_MDB_VSEC_DMA_BAR		GENMASK(10, 8)
 #define DW_PCIE_XILINX_MDB_VSEC_DMA_MAP		GENMASK(2, 0)
+#define DW_PCIE_XILINX_MDB_VSEC_DMA_BAR		GENMASK(10, 8)
 #define DW_PCIE_XILINX_MDB_VSEC_DMA_WR_CH	GENMASK(9, 0)
 #define DW_PCIE_XILINX_MDB_VSEC_DMA_RD_CH	GENMASK(25, 16)
 
-- 
2.43.0

[PATCH v1 2/2] dmaengine: dw-edma: IP name corrected under its struct

[Devendra K Verma]

For 'xilinx_cpm6_dma_data' struct which is CPM6 IP, the comment
under this struct has typo and mentiones 'MDB' registers when
it shall be 'CPM6' regisers.

Signed-off-by: Devendra K Verma <devverma@amd.com>
---
 drivers/dma/dw-edma/dw-edma-pcie.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/dma/dw-edma/dw-edma-pcie.c b/drivers/dma/dw-edma/dw-edma-pcie.c
index 006dea7d6322..762a693ab55b 100644
--- a/drivers/dma/dw-edma/dw-edma-pcie.c
+++ b/drivers/dma/dw-edma/dw-edma-pcie.c
@@ -146,7 +146,7 @@ static const struct dw_edma_pcie_data xilinx_mdb_data = {
 };
 
 static const struct dw_edma_pcie_data xilinx_cpm6_dma_data = {
-	/* MDB registers location */
+	/* CPM6 registers location */
 	.rg.bar				= BAR_0,
 	.rg.off				= SZ_4K,	/*  4 Kbytes */
 	.rg.sz				= SZ_8K,	/*  8 Kbytes */
-- 
2.43.0

Re: [PATCH v1 1/2] dmaengine: dw-edma: Macro order as per reg bit position

[Frank Li]

On Mon, Sep 07, 2026 at 04:24:52PM +0530, Devendra K Verma wrote:

> For a register the macros providing masks for bit ranges.
> These macros if placed in order provide good view of the bits.
> Placed macros in ascending order.

dmaengine: dw-edma: sort register field macros by bit position

Sort register field macros by bit position to improve readability.

No functional change intended.

Frank
>
> Signed-off-by: Devendra K Verma <devverma@amd.com>
> ---
>  drivers/dma/dw-edma/dw-edma-pcie.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/dma/dw-edma/dw-edma-pcie.c b/drivers/dma/dw-edma/dw-edma-pcie.c
> index 9f237ba916de..006dea7d6322 100644
> --- a/drivers/dma/dw-edma/dw-edma-pcie.c
> +++ b/drivers/dma/dw-edma/dw-edma-pcie.c
> @@ -31,8 +31,8 @@
>
>  #define DW_PCIE_XILINX_MDB_VSEC_DMA_ID		0x6
>  #define DW_PCIE_XILINX_MDB_VSEC_ID		0x20
> -#define DW_PCIE_XILINX_MDB_VSEC_DMA_BAR		GENMASK(10, 8)
>  #define DW_PCIE_XILINX_MDB_VSEC_DMA_MAP		GENMASK(2, 0)
> +#define DW_PCIE_XILINX_MDB_VSEC_DMA_BAR		GENMASK(10, 8)
>  #define DW_PCIE_XILINX_MDB_VSEC_DMA_WR_CH	GENMASK(9, 0)
>  #define DW_PCIE_XILINX_MDB_VSEC_DMA_RD_CH	GENMASK(25, 16)
>
> --
> 2.43.0
>

Re: [PATCH v1 2/2] dmaengine: dw-edma: IP name corrected under its struct

[Frank Li]

On Mon, Sep 07, 2026 at 04:24:53PM +0530, Devendra K Verma wrote:
> For 'xilinx_cpm6_dma_data' struct which is CPM6 IP, the comment
> under this struct has typo and mentiones 'MDB' registers when
> it shall be 'CPM6' regisers.
>
> Signed-off-by: Devendra K Verma <devverma@amd.com>
> ---

dmaengine: dw-edma: correct IP name in xilinx_cpm6_dma_data comment

Replace 'MDB' with 'CPM6' in the xilinx_cpm6_dma_data comment to fix
the IP name typo.

Frank

>  drivers/dma/dw-edma/dw-edma-pcie.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/dma/dw-edma/dw-edma-pcie.c b/drivers/dma/dw-edma/dw-edma-pcie.c
> index 006dea7d6322..762a693ab55b 100644
> --- a/drivers/dma/dw-edma/dw-edma-pcie.c
> +++ b/drivers/dma/dw-edma/dw-edma-pcie.c
> @@ -146,7 +146,7 @@ static const struct dw_edma_pcie_data xilinx_mdb_data = {
>  };
>
>  static const struct dw_edma_pcie_data xilinx_cpm6_dma_data = {
> -	/* MDB registers location */
> +	/* CPM6 registers location */
>  	.rg.bar				= BAR_0,
>  	.rg.off				= SZ_4K,	/*  4 Kbytes */
>  	.rg.sz				= SZ_8K,	/*  8 Kbytes */
> --
> 2.43.0
>

Re: [PATCH v1 2/2] dmaengine: dw-edma: IP name corrected under its struct

[Verma, Devendra]

On 15-Sep-26 22:17, Frank Li wrote:
> On Mon, Sep 07, 2026 at 04:24:53PM +0530, Devendra K Verma wrote:
>> For 'xilinx_cpm6_dma_data' struct which is CPM6 IP, the comment
>> under this struct has typo and mentiones 'MDB' registers when
>> it shall be 'CPM6' regisers.
>>
>> Signed-off-by: Devendra K Verma <devverma@amd.com>
>> ---
> 
> dmaengine: dw-edma: correct IP name in xilinx_cpm6_dma_data comment
> 
> Replace 'MDB' with 'CPM6' in the xilinx_cpm6_dma_data comment to fix
> the IP name typo.
> 

Thanks Frank for the suggestion!
Please check the v2 of the same series with updated titles.

-Devendra

> Frank
> 
>>   drivers/dma/dw-edma/dw-edma-pcie.c | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/dma/dw-edma/dw-edma-pcie.c b/drivers/dma/dw-edma/dw-edma-pcie.c
>> index 006dea7d6322..762a693ab55b 100644
>> --- a/drivers/dma/dw-edma/dw-edma-pcie.c
>> +++ b/drivers/dma/dw-edma/dw-edma-pcie.c
>> @@ -146,7 +146,7 @@ static const struct dw_edma_pcie_data xilinx_mdb_data = {
>>   };
>>
>>   static const struct dw_edma_pcie_data xilinx_cpm6_dma_data = {
>> -	/* MDB registers location */
>> +	/* CPM6 registers location */
>>   	.rg.bar				= BAR_0,
>>   	.rg.off				= SZ_4K,	/*  4 Kbytes */
>>   	.rg.sz				= SZ_8K,	/*  8 Kbytes */
>> --
>> 2.43.0
>>

Re: [PATCH v1 2/2] dmaengine: dw-edma: IP name corrected under its struct

[Verma, Devendra]

On 15-Sep-26 22:17, Frank Li wrote:
> On Mon, Sep 07, 2026 at 04:24:53PM +0530, Devendra K Verma wrote:
>> For 'xilinx_cpm6_dma_data' struct which is CPM6 IP, the comment
>> under this struct has typo and mentiones 'MDB' registers when
>> it shall be 'CPM6' regisers.
>>
>> Signed-off-by: Devendra K Verma <devverma@amd.com>
>> ---
> 
> dmaengine: dw-edma: correct IP name in xilinx_cpm6_dma_data comment
> 
> Replace 'MDB' with 'CPM6' in the xilinx_cpm6_dma_data comment to fix
> the IP name typo.
> 

Thank you for the suggestion. Please check the v2 of the same patch
series.

-Devendra

> Frank
> 
>>   drivers/dma/dw-edma/dw-edma-pcie.c | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/dma/dw-edma/dw-edma-pcie.c b/drivers/dma/dw-edma/dw-edma-pcie.c
>> index 006dea7d6322..762a693ab55b 100644
>> --- a/drivers/dma/dw-edma/dw-edma-pcie.c
>> +++ b/drivers/dma/dw-edma/dw-edma-pcie.c
>> @@ -146,7 +146,7 @@ static const struct dw_edma_pcie_data xilinx_mdb_data = {
>>   };
>>
>>   static const struct dw_edma_pcie_data xilinx_cpm6_dma_data = {
>> -	/* MDB registers location */
>> +	/* CPM6 registers location */
>>   	.rg.bar				= BAR_0,
>>   	.rg.off				= SZ_4K,	/*  4 Kbytes */
>>   	.rg.sz				= SZ_8K,	/*  8 Kbytes */
>> --
>> 2.43.0
>>