* Re: nvmet_fc: add defer_req callback for deferment of cmd buffer return
[not found] <20170811194419.4F5D82205C@pdx-korg-gitolite-1.ci.codeaurora.org>
@ 2017-08-14 14:19 ` Dave Jones
2017-08-14 16:38 ` Christoph Hellwig
0 siblings, 1 reply; 3+ messages in thread
From: Dave Jones @ 2017-08-14 14:19 UTC (permalink / raw)
To: Linux Kernel Mailing List; +Cc: James Smart, Christoph Hellwig
On Fri, Aug 11, 2017 at 07:44:19PM +0000, Linux Kernel wrote:
> Web: https://git.kernel.org/torvalds/c/0fb228d30b8d72bfee51f57e638d412324d44a11
> Commit: 0fb228d30b8d72bfee51f57e638d412324d44a11
> Parent: 758f3735580c21b8a36d644128af6608120a1dde
> Refname: refs/heads/master
> Author: James Smart <jsmart2021@gmail.com>
> AuthorDate: Tue Aug 1 15:12:39 2017 -0700
> Committer: Christoph Hellwig <hch@lst.de>
> CommitDate: Thu Aug 10 11:06:38 2017 +0200
>
> nvmet_fc: add defer_req callback for deferment of cmd buffer return
> +
> + /* Cleanup defer'ed IOs in queue */
> + list_for_each_entry(deferfcp, &queue->avail_defer_list, req_list) {
> + list_del(&deferfcp->req_list);
> + kfree(deferfcp);
> + }
Shouldn't this be list_for_each_entry_safe ?
Dave
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: nvmet_fc: add defer_req callback for deferment of cmd buffer return
2017-08-14 14:19 ` nvmet_fc: add defer_req callback for deferment of cmd buffer return Dave Jones
@ 2017-08-14 16:38 ` Christoph Hellwig
2017-08-14 17:57 ` James Smart
0 siblings, 1 reply; 3+ messages in thread
From: Christoph Hellwig @ 2017-08-14 16:38 UTC (permalink / raw)
To: Dave Jones, Linux Kernel Mailing List, James Smart, Christoph Hellwig
On Mon, Aug 14, 2017 at 10:19:24AM -0400, Dave Jones wrote:
> > +
> > + /* Cleanup defer'ed IOs in queue */
> > + list_for_each_entry(deferfcp, &queue->avail_defer_list, req_list) {
> > + list_del(&deferfcp->req_list);
> > + kfree(deferfcp);
> > + }
>
> Shouldn't this be list_for_each_entry_safe ?
It should. James, can you send a fixup?
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: nvmet_fc: add defer_req callback for deferment of cmd buffer return
2017-08-14 16:38 ` Christoph Hellwig
@ 2017-08-14 17:57 ` James Smart
0 siblings, 0 replies; 3+ messages in thread
From: James Smart @ 2017-08-14 17:57 UTC (permalink / raw)
To: Christoph Hellwig, Dave Jones, Linux Kernel Mailing List
On 8/14/2017 9:38 AM, Christoph Hellwig wrote:
> On Mon, Aug 14, 2017 at 10:19:24AM -0400, Dave Jones wrote:
>> > +
>> > + /* Cleanup defer'ed IOs in queue */
>> > + list_for_each_entry(deferfcp, &queue->avail_defer_list, req_list) {
>> > + list_del(&deferfcp->req_list);
>> > + kfree(deferfcp);
>> > + }
>>
>> Shouldn't this be list_for_each_entry_safe ?
>
> It should. James, can you send a fixup?
>
yes - I was had already identified this fix and in the process of
putting it out.
-- james
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-08-14 17:57 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <20170811194419.4F5D82205C@pdx-korg-gitolite-1.ci.codeaurora.org>
2017-08-14 14:19 ` nvmet_fc: add defer_req callback for deferment of cmd buffer return Dave Jones
2017-08-14 16:38 ` Christoph Hellwig
2017-08-14 17:57 ` James Smart
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®