From: Kuogee Hsieh <quic_khsieh@quicinc.com>
To: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>,
Stephen Boyd <swboyd@chromium.org>, <agross@kernel.org>,
<airlied@gmail.com>, <andersson@kernel.org>, <daniel@ffwll.ch>,
<dianders@chromium.org>, <robdclark@gmail.com>, <sean@poorly.run>,
<vkoul@kernel.org>
Cc: <quic_abhinavk@quicinc.com>, <quic_sbillaka@quicinc.com>,
<freedreno@lists.freedesktop.org>,
<dri-devel@lists.freedesktop.org>,
<linux-arm-msm@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2] drm/msm/dp: do not complete dp_aux_cmd_fifo_tx() if irq is not for aux transfer
Date: Thu, 15 Dec 2022 13:23:07 -0800 [thread overview]
Message-ID: <9fc3cd6c-8ae3-ce9c-435b-76e0e641d960@quicinc.com> (raw)
In-Reply-To: <d41e29a9-5da6-3843-5018-9674e7d56505@linaro.org>
On 12/15/2022 1:15 PM, Dmitry Baryshkov wrote:
> On 15/12/2022 22:10, Stephen Boyd wrote:
>> Quoting Dmitry Baryshkov (2022-12-15 10:46:42)
>>> On 15/12/2022 20:32, Kuogee Hsieh wrote:
>>>> if (!aux->cmd_busy)
>>>> return;
>>>>
>>>> if (aux->native)
>>>> - dp_aux_native_handler(aux, isr);
>>>> + ret = dp_aux_native_handler(aux, isr);
>>>> else
>>>> - dp_aux_i2c_handler(aux, isr);
>>>> + ret = dp_aux_i2c_handler(aux, isr);
>>>>
>>>> - complete(&aux->comp);
>>>> + if (ret == IRQ_HANDLED)
>>>> + complete(&aux->comp);
>>>
>>> Can you just move the complete() into the individual handling
>>> functions?
>>> Then you won't have to return the error code from dp_aux_*_handler() at
>>> all. You can check `isr' in that function and call complete if there
>>> was
>>> any error.
>>
>> I'd prefer we apply my patch and pass the irqreturn_t variable to the
>> caller of this function so spurious irqs are shutdown. Should I send it
>> as a proper patch?
>
> I'm for handling the spurious IRQs in a proper way. However I believe
> that it's not related to the issue Kuogee is trying to fix.
>
> Thus I think we should have two separate patches: one fixing the EDID
> corruption issue (for which the proper fix is !isr check, IIUC) and
> the irqreturn_t. And for the irqreturn_t it might be beneficial to
> move complete() call to the dp_aux_foo_handler(). Or might be not.
> That would depend on the patch itself.
>
>
ok, I will split this patch into two.
next prev parent reply other threads:[~2022-12-15 21:23 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-15 18:32 Kuogee Hsieh
2022-12-15 18:46 ` Dmitry Baryshkov
2022-12-15 20:10 ` Stephen Boyd
2022-12-15 20:12 ` Kuogee Hsieh
2022-12-15 21:15 ` Dmitry Baryshkov
2022-12-15 21:23 ` Kuogee Hsieh [this message]
2022-12-15 21:57 ` Abhinav Kumar
2022-12-15 20:30 ` Abhinav Kumar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9fc3cd6c-8ae3-ce9c-435b-76e0e641d960@quicinc.com \
--to=quic_khsieh@quicinc.com \
--cc=agross@kernel.org \
--cc=airlied@gmail.com \
--cc=andersson@kernel.org \
--cc=daniel@ffwll.ch \
--cc=dianders@chromium.org \
--cc=dmitry.baryshkov@linaro.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=freedreno@lists.freedesktop.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=quic_abhinavk@quicinc.com \
--cc=quic_sbillaka@quicinc.com \
--cc=robdclark@gmail.com \
--cc=sean@poorly.run \
--cc=swboyd@chromium.org \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®