Re: [PATCH 7/7] nova-core: mm: Add data structures for page table management

[Joel Fernandes <joelagnelf@nvidia.com>]

> On Oct 22, 2025, at 7:22 AM, Alexandre Courbot <acourbot@nvidia.com> wrote:
> 
> On Tue Oct 21, 2025 at 3:55 AM JST, Joel Fernandes wrote:
> <snip>
>> +#![expect(dead_code)]
>> +
>> +/// Memory size constants
>> +pub(crate) const KB: usize = 1024;
>> +pub(crate) const MB: usize = KB * 1024;
> 
> You can use `kernel::types::SZ_1K` and `SZ_1M` instead.
> 
>> +
>> +/// Page size: 4 KiB
>> +pub(crate) const PAGE_SIZE: usize = 4 * KB;
> 
> SZ_4K exists as well. :)

Thanks a lot, will do.

- Joel


>