arch/x86_64/kernel/pci-calgary.c(600): remark #593: variable "bbar" was set but

arch/x86_64/kernel/pci-calgary.c(600): remark #593: variable "bbar" was set but

[d binderman]

Hello there,

I just tried to compile Linux kernel 2.6.18.3 with the Intel C
C compiler.

The compiler said

arch/x86_64/kernel/pci-calgary.c(600): remark #593: variable "bbar" was set 
but never used
arch/x86_64/kernel/pci-calgary.c(601): remark #593: variable "busnum" was 
set but never used

The source code is

    void __iomem *bbar;
    unsigned char busnum;

I have checked the source code and I agree with the compiler.
Suggest delete local variables.

Regards

David Binderman

_________________________________________________________________
Be the first to hear what's new at MSN - sign up to our free newsletters! 
http://www.msn.co.uk/newsletters

[PATCH x86-64] Calgary: remove unused vars

[Muli Ben-Yehuda]

On Wed, Nov 22, 2006 at 11:45:24AM +0000, d binderman wrote:
> 
> Hello there,
> 
> I just tried to compile Linux kernel 2.6.18.3 with the Intel C
> C compiler.
> 
> The compiler said
> 
> arch/x86_64/kernel/pci-calgary.c(600): remark #593: variable "bbar" was set 
> but never used
> arch/x86_64/kernel/pci-calgary.c(601): remark #593: variable "busnum" was 
> set but never used
> 
> The source code is
> 
>    void __iomem *bbar;
>    unsigned char busnum;
> 
> I have checked the source code and I agree with the compiler.
> Suggest delete local variables.

Thanks, I agree. Andi, please apply.

[PATCH x86-64] Calgary: remove unused vars

Spotted by d binderman <dcb314@hotmail.com>.

Signed-off-by: Muli Ben-Yehuda <muli@il.ibm.com>

diff -r aed4939c234b -r acb0eb3ee9c3 arch/x86_64/kernel/pci-calgary.c
--- a/arch/x86_64/kernel/pci-calgary.c	Mon Nov 20 22:44:19 2006 +0200
+++ b/arch/x86_64/kernel/pci-calgary.c	Wed Nov 22 14:08:19 2006 +0200
@@ -653,13 +653,8 @@ static void __init calgary_reserve_regio
 static void __init calgary_reserve_regions(struct pci_dev *dev)
 {
 	unsigned int npages;
-	void __iomem *bbar;
-	unsigned char busnum;
 	u64 start;
 	struct iommu_table *tbl = dev->sysdata;
-
-	bbar = tbl->bbar;
-	busnum = dev->bus->number;
 
 	/* reserve bad_dma_address in case it's a legal address */
 	iommu_range_reserve(tbl, bad_dma_address, 1);