variable used before it is set

variable used before it is set

[d binderman]

I just tried to compile the Linux Kernel version 2.6.11.12
with the most excellent Intel C compiler. It said

net/bridge/netfilter/ebt_log.c(91): remark #592: variable "u" is used before 
its value is set
        printk(" IP tos=0x%02X, IP proto=%d", u.iph.tos,
                                              ^
I agree with the compiler. Suggest code rework.

Regards

David Binderman

_________________________________________________________________
Want to block unwanted pop-ups? Download the free MSN Toolbar now!  
http://toolbar.msn.co.uk/

Re: variable used before it is set

[David S. Miller]

From: "d binderman" <dcb314@hotmail.com>
Date: Tue, 28 Jun 2005 09:16:56 +0000

> net/bridge/netfilter/ebt_log.c(91): remark #592: variable "u" is used before 
> its value is set
>         printk(" IP tos=0x%02X, IP proto=%d", u.iph.tos,
>                                               ^
> I agree with the compiler. Suggest code rework.

I added this bug, I'll fix it.  It should use iph->tos
instead, and the entire 'u' array on the local stack
removed since there are then no more users of it.

Re: variable used before it is set

[Jörn Engel]

On Tue, 28 June 2005 09:16:56 +0000, d binderman wrote:
> 
> I just tried to compile the Linux Kernel version 2.6.11.12
> with the most excellent Intel C compiler. It said
> 
> net/bridge/netfilter/ebt_log.c(91): remark #592: variable "u" is used 
> before its value is set
>        printk(" IP tos=0x%02X, IP proto=%d", u.iph.tos,
>                                              ^
> I agree with the compiler. Suggest code rework.

Thank you for the reports.  But I fear that some of them may go
unnoticed by the responsible maintainers.  Could you go through
/usr/src/linux/MAINTAINERS and add relevant people and/or mailing
lists to the Cc: list?

Netfilter folks added, just to give an example.

Jörn

-- 
The story so far:
In the beginning the Universe was created.  This has made a lot
of people very angry and been widely regarded as a bad move.
-- Douglas Adams