From: Ricardo Ribalda Delgado <ricardo.ribalda@gmail.com>
To: David Laight <David.Laight@aculab.com>
Cc: Alan Stern <stern@rowland.harvard.edu>,
Felipe Balbi <balbi@ti.com>,
"gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
Kernel development list <linux-kernel@vger.kernel.org>,
USB list <linux-usb@vger.kernel.org>,
"joe@perches.com" <joe@perches.com>,
"auttamchandani@logicube.com" <auttamchandani@logicube.com>
Subject: Re: [PATCH 3/5] usb: gadget: net2280: Pass checkpacth.pl test
Date: Tue, 20 May 2014 10:55:43 +0200 [thread overview]
Message-ID: <CAPybu_1FnfFKT-X-VNP+HgAKjitJSVy0O2GY5uY+icS8RwfrcA@mail.gmail.com> (raw)
In-Reply-To: <063D6719AE5E284EB5DD2968C1650D6D17249DE6@AcuExch.aculab.com>
Not for grep...
But if this is an issue I have no problem going back to the original.
We can spend a whole year just talking about codestyle.
On Tue, May 20, 2014 at 10:52 AM, David Laight <David.Laight@aculab.com> wrote:
> From: Alan Stern
> ...
>> > -static struct usb_request *
>> > -net2280_alloc_request (struct usb_ep *_ep, gfp_t gfp_flags)
>> > +static struct usb_request *net2280_alloc_request(struct usb_ep *_ep,
>> > + gfp_t gfp_flags)
>>
>> What's with the extreme indentation on the continuation line? The
>> style used here is for continuation lines to be indented by two stops
>> relative to the first line.
>
> Also why move the line break?
> The Linux kernel has both styles, and the original one (with the
> function name starting in column 1) makes it much easier to search
> to the definition.
>
> David
>
>
>
--
Ricardo Ribalda
next prev parent reply other threads:[~2014-05-20 8:56 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-19 19:11 [PATCH 0/5] usb: gadget: net2280: Code cleanout Ricardo Ribalda Delgado
2014-05-19 19:11 ` [PATCH 1/5] usb: gadget: net2280: Refactor queues_show Ricardo Ribalda Delgado
2014-05-19 19:11 ` [PATCH 2/5] usb: gadget: net2280: Use S_I macros Ricardo Ribalda Delgado
2014-05-19 19:30 ` Alan Stern
2014-05-19 19:35 ` Ricardo Ribalda Delgado
2014-05-19 20:03 ` Alan Stern
2014-05-19 19:11 ` [PATCH 3/5] usb: gadget: net2280: Pass checkpacth.pl test Ricardo Ribalda Delgado
2014-05-19 19:39 ` Alan Stern
2014-05-20 8:52 ` David Laight
2014-05-20 8:55 ` Ricardo Ribalda Delgado [this message]
2014-05-19 19:11 ` [PATCH 4/5] usb: gadget: net2280: Code Cleanup Ricardo Ribalda Delgado
2014-05-19 19:43 ` Alan Stern
2014-05-19 19:44 ` Ricardo Ribalda Delgado
2014-05-19 20:02 ` Alan Stern
2014-05-19 19:11 ` [PATCH 5/5] usb: gadget: net2280: Use pr_* function Ricardo Ribalda Delgado
2014-05-19 19:16 ` Joe Perches
2014-05-19 19:33 ` Ricardo Ribalda Delgado
2014-05-19 19:42 ` Joe Perches
2014-05-19 19:43 ` Ricardo Ribalda Delgado
2014-05-19 19:44 ` Alan Stern
2014-05-19 20:03 ` Ricardo Ribalda Delgado
2014-05-19 20:17 ` Alan Stern
2014-05-19 20:29 ` Joe Perches
2014-05-19 20:41 ` Ricardo Ribalda Delgado
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAPybu_1FnfFKT-X-VNP+HgAKjitJSVy0O2GY5uY+icS8RwfrcA@mail.gmail.com \
--to=ricardo.ribalda@gmail.com \
--cc=David.Laight@aculab.com \
--cc=auttamchandani@logicube.com \
--cc=balbi@ti.com \
--cc=gregkh@linuxfoundation.org \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=stern@rowland.harvard.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®