Compile warning in 2.5.66-bk latest

Compile warning in 2.5.66-bk latest

[Stephen Hemminger]

Using gcc 3.2 with latest 2.5.66-bk

gcc -Wp,-MD,drivers/block/.elevator.o.d -D__KERNEL__ -Iinclude -Wall -Wstrict-prototypes -Wno-trigraphs -O2 -fno-strict-aliasing -fno-common -pipe -mpreferred-stack-boundary=2 -march=pentium4 -Iinclude/asm-i386/mach-default -nostdinc -iwithprefix include    -DKBUILD_BASENAME=elevator -DKBUILD_MODNAME=elevator -c -o drivers/block/.tmp_elevator.o drivers/block/elevator.c
fs/jbd/transaction.c:670:53: warning: pasting "KERN_ERR" and ""Possible IO failure.\n"" does not give a valid preprocessing token

RE: Compile warning in 2.5.66-bk latest

[Hua Zhong]

Hi Andrew:

It's probably another change set in the file (J_EXPECT_JH).

I don't have gcc 3.2 installed so I could not verify, but maybe the
following patch could fix it.

Maybe a better fix is to define all J_EXPECTxxx as sth like:

#define J_EXPECT(expr, why, params...)		__journal_expect(expr, why, ##
params)

as why is always needed.

diff -urN linux-2.5/include/linux/jbd.h linux-2.5-new/include/linux/jbd.h
--- linux-2.5/include/linux/jbd.h	Thu Apr  3 11:29:43 2003
+++ linux-2.5-new/include/linux/jbd.h	Thu Apr  3 21:48:25 2003
@@ -275,7 +275,7 @@
 	do {								     \
 		if (!(expr)) {						     \
 			printk(KERN_ERR "EXT3-fs unexpected failure: %s;\n", # expr); \
-			printk(KERN_ERR ## why);			     \
+			printk(KERN_ERR why);			     \
 		}							     \
 	} while (0)
 #define J_EXPECT(expr, why...)		__journal_expect(expr, ## why)

> -----Original Message-----
> From: Stephen Hemminger [mailto:shemminger@osdl.org]
> Sent: Thursday, April 03, 2003 2:17 PM
> To: Hua Zhong
> Cc: Linux Kernel Mailing List
> Subject: Compile warning in 2.5.66-bk latest
>
>
> Using gcc 3.2 with latest 2.5.66-bk
>
> gcc -Wp,-MD,drivers/block/.elevator.o.d -D__KERNEL__ -Iinclude
> -Wall -Wstrict-prototypes -Wno-trigraphs -O2 -fno-strict-aliasing
> -fno-common -pipe -mpreferred-stack-boundary=2 -march=pentium4
> -Iinclude/asm-i386/mach-default -nostdinc -iwithprefix include
> -DKBUILD_BASENAME=elevator -DKBUILD_MODNAME=elevator -c -o
> drivers/block/.tmp_elevator.o drivers/block/elevator.c
> fs/jbd/transaction.c:670:53: warning: pasting "KERN_ERR" and
> ""Possible IO failure.\n"" does not give a valid preprocessing token
>
>
>

Re: Compile warning in 2.5.66-bk latest

[Stephen Hemminger]

On Thu, 3 Apr 2003 19:00:14 -0800
"Hua Zhong" <hzhong@cisco.com> wrote:

> Hi Andrew:
> 
> It's probably another change set in the file (J_EXPECT_JH).
> 
> I don't have gcc 3.2 installed so I could not verify, but maybe the
> following patch could fix it.
> 

This compiles and runs fine for me.


> Maybe a better fix is to define all J_EXPECTxxx as sth like:
> 
> #define J_EXPECT(expr, why, params...)		__journal_expect(expr, why, ##
> params)
> 
> as why is always needed.
> 
> diff -urN linux-2.5/include/linux/jbd.h linux-2.5-new/include/linux/jbd.h
> --- linux-2.5/include/linux/jbd.h	Thu Apr  3 11:29:43 2003
> +++ linux-2.5-new/include/linux/jbd.h	Thu Apr  3 21:48:25 2003
> @@ -275,7 +275,7 @@
>  	do {								     \
>  		if (!(expr)) {						     \
>  			printk(KERN_ERR "EXT3-fs unexpected failure: %s;\n", # expr); \
> -			printk(KERN_ERR ## why);			     \
> +			printk(KERN_ERR why);			     \
>  		}							     \
>  	} while (0)
>  #define J_EXPECT(expr, why...)		__journal_expect(expr, ## why)
> 
> > -----Original Message-----
> > From: Stephen Hemminger [mailto:shemminger@osdl.org]
> > Sent: Thursday, April 03, 2003 2:17 PM
> > To: Hua Zhong
> > Cc: Linux Kernel Mailing List
> > Subject: Compile warning in 2.5.66-bk latest
> >
> >
> > Using gcc 3.2 with latest 2.5.66-bk
> >
> > gcc -Wp,-MD,drivers/block/.elevator.o.d -D__KERNEL__ -Iinclude
> > -Wall -Wstrict-prototypes -Wno-trigraphs -O2 -fno-strict-aliasing
> > -fno-common -pipe -mpreferred-stack-boundary=2 -march=pentium4
> > -Iinclude/asm-i386/mach-default -nostdinc -iwithprefix include
> > -DKBUILD_BASENAME=elevator -DKBUILD_MODNAME=elevator -c -o
> > drivers/block/.tmp_elevator.o drivers/block/elevator.c
> > fs/jbd/transaction.c:670:53: warning: pasting "KERN_ERR" and
> > ""Possible IO failure.\n"" does not give a valid preprocessing token
> >
> >
> >